From a57309451bfb0007976aae9684cdc98eab4025b5 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 29 Oct 2021 16:02:00 +0900 Subject: [PATCH 01/16] Release version 0.18.1 Changes: - Set child subreaper attribute Change-Id: I04a882e3f3d4a9c3611bf3035be10f6e3316d351 Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 4a6e3dd..b0a556a 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.0 +Version: 0.18.1 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From 40a09d54f5dc014a3fb276bfbbaafd61b5f0ec26 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 29 Oct 2021 16:56:39 +0900 Subject: [PATCH 02/16] Adjust sending startup signal After creating the app socket, the startup signal will be sent. Requires: - https://review.tizen.org/gerrit/#/c/platform/core/appfw/aul-1/+/265335/ - https://review.tizen.org/gerrit/#/c/platform/core/appfw/amd/+/265818/ - https://review.tizen.org/gerrit/#/c/platform/core/appfw/launchpad/+/265825/ Change-Id: Ib06bdf45b51b44bc9225b40333bb0b30968951b4 Signed-off-by: Hwankyu Jhun --- src/launchpad-process-pool/src/launchpad.c | 2 +- src/lib/launchpad/src/launchpad_lib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/launchpad-process-pool/src/launchpad.c b/src/launchpad-process-pool/src/launchpad.c index 3d57531..516079c 100644 --- a/src/launchpad-process-pool/src/launchpad.c +++ b/src/launchpad-process-pool/src/launchpad.c @@ -1269,7 +1269,6 @@ static int __prepare_exec(const char *appid, const char *app_path, if (ret != SECURITY_MANAGER_SUCCESS) return PAD_ERR_REJECTED; - _send_cmd_to_amd(APP_STARTUP_SIGNAL); if (bundle_get_type(kb, AUL_K_SDK) == BUNDLE_TYPE_NONE) _setup_stdio(basename(app_path)); @@ -1309,6 +1308,7 @@ static int __prepare_exec(const char *appid, const char *app_path, return PAD_ERR_FAILED; } + _send_cmd_to_amd(APP_STARTUP_SIGNAL); return 0; } diff --git a/src/lib/launchpad/src/launchpad_lib.c b/src/lib/launchpad/src/launchpad_lib.c index c4e7a95..e14894f 100644 --- a/src/lib/launchpad/src/launchpad_lib.c +++ b/src/lib/launchpad/src/launchpad_lib.c @@ -102,7 +102,6 @@ static int __prepare_exec(const char *appid, const char *app_path, return -1; } - _send_cmd_to_amd(APP_STARTUP_SIGNAL); _setup_stdio(basename(app_path)); ret = buxton_open(&bxt_cli, NULL, NULL); @@ -159,6 +158,7 @@ static int __prepare_exec(const char *appid, const char *app_path, if (ret < 0) return -1; + _send_cmd_to_amd(APP_STARTUP_SIGNAL); return 0; } -- 2.7.4 From 5cd1f3dfa1d17422fdae54e9c27bac15e7d83819 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 3 Nov 2021 12:58:54 +0900 Subject: [PATCH 03/16] Release version 0.18.2 Changes: - Adjust sending startup signal Change-Id: I19da8d0663214b98cdc7163a0e40ae71e50c8044 Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index b0a556a..55021a7 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.1 +Version: 0.18.2 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From a8f63eec9bca4a3a58699294b4c6216d5240c1d0 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Thu, 11 Nov 2021 12:49:01 +0900 Subject: [PATCH 04/16] Fix id file creation The child process writes zero to the id file. When calling the aul_initialize(), the process will write one to the id file. This is to check the socket status of the running application. Requires: - https://review.tizen.org/gerrit/#/c/platform/core/appfw/launchpad/+/266359/ - https://review.tizen.org/gerrit/#/c/platform/core/appfw/aul-1/+/266360/ - https://review.tizen.org/gerrit/#/c/platform/core/appfw/amd/+/266361/ Change-Id: I0abe08650b60d4e97f039ffaa16a20c299054110 Signed-off-by: Hwankyu Jhun --- src/lib/common/src/launchpad_common.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/lib/common/src/launchpad_common.c b/src/lib/common/src/launchpad_common.c index 17ab641..7bfd547 100644 --- a/src/lib/common/src/launchpad_common.c +++ b/src/lib/common/src/launchpad_common.c @@ -1415,17 +1415,18 @@ int _verify_proc_caps(void) int _prepare_id_file(void) { char path[PATH_MAX]; - int fd; + FILE* fp; snprintf(path, sizeof(path), "/run/aul/apps/%u/%d/%s", getuid(), getpid(), getenv("AUL_APPID")); - fd = open(path, O_CREAT | O_WRONLY | O_TRUNC, 0600); - if (fd < 0) { - _E("Failed to create %s. errno(%d)", path, errno); + fp = fopen(path, "w"); + if (!fp) { + _E("fopen() is failed. path(%s), errno(%d)", path, errno); return -1; } - close(fd); + fprintf(fp, "0"); + fclose(fp); return 0; } -- 2.7.4 From cc7260d6b75def08f89403f84d18d21741c239fa Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Thu, 11 Nov 2021 15:55:26 +0900 Subject: [PATCH 05/16] Release version 0.18.3 Changes: - Fix id file creation Change-Id: I0b553892f17f4db6ba5006c4ffcc67774b8df075 Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 55021a7..722c450 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.2 +Version: 0.18.3 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From 19b2e5d053ac77fb217336ae4b9d0f14d705d78d Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Thu, 11 Nov 2021 23:54:47 +0900 Subject: [PATCH 06/16] Revert "Fix id file creation" This reverts commit a8f63eec9bca4a3a58699294b4c6216d5240c1d0. Change-Id: I27d0dc189801f6665d08ac49b70c532d90d822c6 --- src/lib/common/src/launchpad_common.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/lib/common/src/launchpad_common.c b/src/lib/common/src/launchpad_common.c index 7bfd547..17ab641 100644 --- a/src/lib/common/src/launchpad_common.c +++ b/src/lib/common/src/launchpad_common.c @@ -1415,18 +1415,17 @@ int _verify_proc_caps(void) int _prepare_id_file(void) { char path[PATH_MAX]; - FILE* fp; + int fd; snprintf(path, sizeof(path), "/run/aul/apps/%u/%d/%s", getuid(), getpid(), getenv("AUL_APPID")); - fp = fopen(path, "w"); - if (!fp) { - _E("fopen() is failed. path(%s), errno(%d)", path, errno); + fd = open(path, O_CREAT | O_WRONLY | O_TRUNC, 0600); + if (fd < 0) { + _E("Failed to create %s. errno(%d)", path, errno); return -1; } + close(fd); - fprintf(fp, "0"); - fclose(fp); return 0; } -- 2.7.4 From f5df7f8ca4021264635fd3167b6a25a487f374ce Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 19 Nov 2021 13:09:28 +0900 Subject: [PATCH 07/16] Handle a new command To monitor the state of the launchpad, AMD will connect to the launchpad and maintain the connection. Change-Id: Ib8a9eaf30b4beaa1e40a0c46a7752c4b5e4ea86f Signed-off-by: Hwankyu Jhun --- src/launchpad-process-pool/src/launchpad.c | 9 +++++++++ src/lib/common/inc/launchpad_common.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/launchpad-process-pool/src/launchpad.c b/src/launchpad-process-pool/src/launchpad.c index 516079c..c269006 100644 --- a/src/launchpad-process-pool/src/launchpad.c +++ b/src/launchpad-process-pool/src/launchpad.c @@ -183,6 +183,7 @@ static int MAX_CPU_CHECK_COUNT; static io_channel_h __logger_channel; static io_channel_h __label_monitor_channel; static io_channel_h __launchpad_channel; +static int __client_fd = -1; static candidate_process_context_t *__add_slot(int type, int loader_id, int caller_pid, const char *loader_name, @@ -2224,6 +2225,14 @@ static bool __handle_launch_event(int fd, io_condition_e cond, void *data) close(clifd); clifd = -1; goto end; + case PAD_CMD_CONNECT: + _W("Connected. fd(%d)", clifd); + if (__client_fd != -1) + close(__client_fd); + + __client_fd = clifd; + clifd = -1; + goto end; } INIT_PERF(kb); diff --git a/src/lib/common/inc/launchpad_common.h b/src/lib/common/inc/launchpad_common.h index ff257a1..a1a7784 100644 --- a/src/lib/common/inc/launchpad_common.h +++ b/src/lib/common/inc/launchpad_common.h @@ -49,6 +49,7 @@ #define PAD_CMD_PING 15 #define PAD_CMD_UPDATE_APP_TYPE 16 #define PAD_CMD_PREPARE_APP_DEFINED_LOADER 17 +#define PAD_CMD_CONNECT 18 #define LAUNCHPAD_LAUNCH_SIGNAL 83 #define LAUNCHPAD_DEAD_SIGNAL 61 -- 2.7.4 From 042679dfda641407961f81f39fda7e38946e92b5 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Mon, 22 Nov 2021 09:10:56 +0900 Subject: [PATCH 08/16] Release version 0.18.4 Changes: - Revert "Fix id file creation" - Handle a new command Change-Id: Ide571a8478c4f272642ff83b7882814b516ef413 Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 722c450..c64a1d0 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.3 +Version: 0.18.4 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From e5a05f3bbc4b997071b26882a21baba11fe54ddb Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 4 Feb 2022 13:56:38 +0900 Subject: [PATCH 09/16] Change mount namespace When executing the debug tool process, the child process has to change the mount namespace to the mount namespace of the target process if the option is 'attach'. Change-Id: I9db343a70f614d18d291018ecab04a4db2b8fec0 Signed-off-by: Hwankyu Jhun --- src/launchpad-process-pool/inc/launchpad_debug.h | 1 + src/launchpad-process-pool/src/launchpad.c | 3 +++ src/launchpad-process-pool/src/launchpad_debug.c | 33 ++++++++++++++++++++++++ 3 files changed, 37 insertions(+) diff --git a/src/launchpad-process-pool/inc/launchpad_debug.h b/src/launchpad-process-pool/inc/launchpad_debug.h index a866270..1697900 100644 --- a/src/launchpad-process-pool/inc/launchpad_debug.h +++ b/src/launchpad-process-pool/inc/launchpad_debug.h @@ -20,6 +20,7 @@ #include #include +int _debug_change_mount_namespace(void); int _debug_create_extra_argv(int *arg, char ***argv); int _debug_create_argv(int *argc, char ***argv, bool *attach); void _debug_destroy_argv(int argc, char **argv); diff --git a/src/launchpad-process-pool/src/launchpad.c b/src/launchpad-process-pool/src/launchpad.c index c269006..b4907f0 100644 --- a/src/launchpad-process-pool/src/launchpad.c +++ b/src/launchpad-process-pool/src/launchpad.c @@ -1263,6 +1263,9 @@ static int __prepare_exec(const char *appid, const char *app_path, if (ret < 0) return PAD_ERR_FAILED; + if (bundle_get_type(kb, AUL_K_SDK) != BUNDLE_TYPE_NONE) + _debug_change_mount_namespace(); + /* SET PRIVILEGES*/ _W("security_manager_prepare_app ++"); ret = security_manager_prepare_app(appid); diff --git a/src/launchpad-process-pool/src/launchpad_debug.c b/src/launchpad-process-pool/src/launchpad_debug.c index 37934e0..8040f45 100644 --- a/src/launchpad-process-pool/src/launchpad_debug.c +++ b/src/launchpad-process-pool/src/launchpad_debug.c @@ -23,6 +23,7 @@ #include #include #include +#include #include "debugger_info.h" #include "key.h" @@ -38,6 +39,32 @@ static debugger_info_h __debugger_info; static GList *__debug_argv_list; static GList *__extra_argv_list; +int _debug_change_mount_namespace(void) +{ + const char *pid_str; + char buf[PATH_MAX]; + int ret; + int fd; + + pid_str = getenv("TARGET_PID"); + if (pid_str == NULL) + return 0; + + snprintf(buf, sizeof(buf), "/proc/%s/ns/mnt", pid_str); + fd = open(buf, O_RDONLY); + if (fd < 0) { + _E("open() is failed. path(%s), errno(%d)", buf, errno); + return -1; + } + + ret = setns(fd, CLONE_NEWNS); + close(fd); + if (ret != 0) + _E("setns() is failed. errno(%d)", errno); + + return ret; +} + int _debug_create_extra_argv(int *argc, char ***argv) { int new_argc; @@ -296,6 +323,12 @@ static void __add_debug_argv(gpointer data, gpointer user_data) __debug_argv_list = g_list_append(__debug_argv_list, strdup(str_arr[i])); + if (!strcmp(key, "__DLP_ATTACH_ARG__")) { + if (isdigit(str_arr[i][0])) { + _D("Target PID: %s", str_arr[i]); + setenv("TARGET_PID", str_arr[i], 1); + } + } } if (str_arr) -- 2.7.4 From a3af73971ba754fed91d9dc3cf7d7f93d42d14fe Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 4 Feb 2022 14:31:35 +0900 Subject: [PATCH 10/16] Release version 0.18.5 Changes: - Change mount namespace Change-Id: Icc5ef1d3cb40c612436b5e6ef08ee629b37f755d Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index c64a1d0..1fdcb6a 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.4 +Version: 0.18.5 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From 61bc8b0ae15955585af3edbd1fd9d1c615e89301 Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Thu, 24 Feb 2022 09:43:09 +0900 Subject: [PATCH 11/16] Fix static analysis issue Changes: - Adds checking that the variable is nullptr. Change-Id: I632547066e972cf99d7f2c99b2464b39029e7b24 Signed-off-by: Changgyu Choi --- src/launchpad-parser/launchpad_parser_plugin.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/launchpad-parser/launchpad_parser_plugin.cc b/src/launchpad-parser/launchpad_parser_plugin.cc index 8ccee30..f873673 100644 --- a/src/launchpad-parser/launchpad_parser_plugin.cc +++ b/src/launchpad-parser/launchpad_parser_plugin.cc @@ -142,6 +142,9 @@ int LaunchpadParser::Upgrade(xmlDocPtr doc, std::string pkgid) { int LaunchpadParser::UnInstall(xmlDocPtr doc, std::string pkgid) { xmlNode* root = xmlDocGetRootElement(doc); + if (root == nullptr) + return -1; + for (xmlNode* node = root->children; node; node = node->next) { if (!node->name) continue; -- 2.7.4 From 1e7e6c764c9756c18dfaf34d81399d698e6f5413 Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Thu, 24 Feb 2022 09:56:54 +0900 Subject: [PATCH 12/16] Release version 0.18.6 Changes: - Fix static analysis issue Change-Id: I51bccb92f6af801441171d771217b30b605eae81 Signed-off-by: Changgyu Choi --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 1fdcb6a..2c4104c 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.5 +Version: 0.18.6 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From 49826a7ac0f6e289a7fca10ac0d471a3cc3a03da Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Fri, 18 Mar 2022 09:50:48 +0900 Subject: [PATCH 13/16] Add logs for debugging Change-Id: Ie8e96eea8d08aa6b4024045c4c60caaa3f353093 Signed-off-by: Changgyu Choi --- src/launchpad-process-pool/src/launchpad.c | 44 ++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/src/launchpad-process-pool/src/launchpad.c b/src/launchpad-process-pool/src/launchpad.c index b4907f0..104f426 100644 --- a/src/launchpad-process-pool/src/launchpad.c +++ b/src/launchpad-process-pool/src/launchpad.c @@ -1489,7 +1489,10 @@ static bool __handle_loader_event(int fd, io_condition_e cond, void *data) cpc->prepared = true; cpc->send_fd = client_fd; - SECURE_LOGD("Type %d candidate process was connected, " + SECURE_LOGI("Type %d candidate process was connected, " + "pid: %d", cpc->type, cpc->pid); + + _print_hwc_log("Type %d candidate process was connected, " "pid: %d", cpc->type, cpc->pid); cpc->client_channel = _io_channel_create(client_fd, IO_IN | IO_HUP, @@ -2116,10 +2119,12 @@ static void __update_slot_state(candidate_process_context_t *cpc, int method, switch (method) { case METHOD_OUT_OF_MEMORY: if ((force || cpc->deactivation_method & method) && - __is_low_memory()) + __is_low_memory()) { + _W("Low memory, deactivate slot %d", cpc->type); __deactivate_slot(cpc); - else + } else { __activate_slot(cpc); + } break; case METHOD_TTL: if (force || cpc->deactivation_method & method) @@ -2767,12 +2772,37 @@ static int __verify_loader_caps(const char *loader) return 0; } +static void __get_app_type_string(loader_info_t *info, char buf[], int size) +{ + GList *iter = info->app_types; + char *app_type; + char *ptr = buf; + int len; + + while (iter) { + app_type = (char *)iter->data; + iter = g_list_next(iter); + len = strlen(app_type); + if (size < len + 1) + return; + + strncpy(ptr, app_type, size); + ptr += len; + size -= len; + if (iter) { + (*ptr++) = ' '; + size--; + } + } +} + static void __add_slot_from_info(gpointer data, gpointer user_data) { loader_info_t *info = (loader_info_t *)data; candidate_process_context_t *cpc; bundle_raw *extra = NULL; int len; + char buf[2048] = {0, }; if (!strcmp(info->exe, "null")) { cpc = __add_slot(LAUNCHPAD_LOADER_TYPE_USER + user_slot_offset, @@ -2821,7 +2851,12 @@ static void __add_slot_from_info(gpointer data, gpointer user_data) info->type = LAUNCHPAD_LOADER_TYPE_USER + user_slot_offset; user_slot_offset++; - } + __get_app_type_string(info, buf, sizeof(buf)); + _I("candidate slot. app-type(%s) loader-type(%d)", + buf, info->type); + _print_hwc_log("candidate slot. app-type(%s) loader-type(%d)", + buf, info->type); + } } static int __add_default_slots(void) @@ -3277,4 +3312,3 @@ int main(int argc, char **argv) return -1; } - -- 2.7.4 From dc9feb7667544365f5021b3261ff75f882d9ce23 Mon Sep 17 00:00:00 2001 From: Changgyu Choi Date: Fri, 18 Mar 2022 15:39:22 +0900 Subject: [PATCH 14/16] Release version 0.18.7 Changes: - Add logs for debugging Change-Id: I35a39180bd86fe4c1c324bf5258d5411e6b9fa06 Signed-off-by: Changgyu Choi --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 2c4104c..9d1238f 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.6 +Version: 0.18.7 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4 From 9a7688474a189bbf663df76836a7c62bfd0c2673 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Tue, 22 Mar 2022 07:55:04 +0900 Subject: [PATCH 15/16] Remove executable file check Checking the executable file can be slow when the system is boot up. It causes performance degrdation of AMD. This patch is to prevent performance degradation. Change-Id: I0133598ce003e49b1d238266600b5fc415df3eeb Signed-off-by: Hwankyu Jhun --- src/launchpad-process-pool/src/launchpad.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/launchpad-process-pool/src/launchpad.c b/src/launchpad-process-pool/src/launchpad.c index 104f426..37fd7a3 100644 --- a/src/launchpad-process-pool/src/launchpad.c +++ b/src/launchpad-process-pool/src/launchpad.c @@ -2151,7 +2151,6 @@ static bool __handle_launch_event(int fd, io_condition_e cond, void *data) appinfo_t *menu_info = NULL; candidate_process_context_t *cpc = NULL; candidate_process_context_t *org_cpc = NULL; - const char *installed_storage; const char *app_path = NULL; int pid = -1; int clifd = -1; @@ -2269,22 +2268,6 @@ static bool __handle_launch_event(int fd, io_condition_e cond, void *data) goto end; } - installed_storage = bundle_get_val(kb, AUL_K_INSTALLED_STORAGE); - if (!installed_storage || strcmp(installed_storage, "external") != 0) { - if (menu_info->app_type && - (!strcmp(menu_info->app_type, "capp") || - !strcmp(menu_info->app_type, "c++app"))) { - if (access(app_path, X_OK) != 0) { - ret = -errno; - _E("%s is not executable. errno(%d)", - app_path, errno); - __send_result_to_caller(clifd, ret); - clifd = -1; - goto end; - } - } - } - if (menu_info->hwacc == NULL) { _E("[launchpad] Failed to find H/W acceleration type"); __send_result_to_caller(clifd, -EINVAL); -- 2.7.4 From 5981e0f1f4c3545fb43366887a22465fb51b983f Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Tue, 22 Mar 2022 09:15:39 +0900 Subject: [PATCH 16/16] Release version 0.18.8 Changes: - Remove executable file check Change-Id: I8f333a398b043479d993285a262ca9c0776ad929 Signed-off-by: Hwankyu Jhun --- packaging/launchpad.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/launchpad.spec b/packaging/launchpad.spec index 9d1238f..e2fcb05 100644 --- a/packaging/launchpad.spec +++ b/packaging/launchpad.spec @@ -1,6 +1,6 @@ Name: launchpad Summary: Launchpad for launching applications -Version: 0.18.7 +Version: 0.18.8 Release: 1 Group: Application Framework/Daemons License: Apache-2.0 -- 2.7.4