From 0b54948185d1f29a053402be5f044473358c4217 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 19 Mar 2019 19:06:14 +0900 Subject: [PATCH 01/16] Update package version to 0.1.24 Change-Id: Id6736a14d4d81559e580cddcb47cf581c6233677 Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 90eb845..6a3656d 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -1,6 +1,6 @@ Name: capi-ui-autofill Summary: Autofill Library -Version: 0.1.23 +Version: 0.1.24 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From 4b68e75a9392e00eab4cbf14ad01e672aead1ad6 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 21 Mar 2019 10:05:08 +0900 Subject: [PATCH 02/16] Fix documentation Change-Id: I7f4cd293d0c98e61a539f1885e3e9e40f27e4025 Signed-off-by: Jihoon Kim --- include/autofill_common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/autofill_common.h b/include/autofill_common.h index 8ab7ed6..dbf44d3 100644 --- a/include/autofill_common.h +++ b/include/autofill_common.h @@ -825,7 +825,7 @@ int autofill_fill_response_group_destroy(autofill_fill_response_group_h h); int autofill_fill_response_group_clone(autofill_fill_response_group_h h, autofill_fill_response_group_h *clone); /** - * @brief Adds autofill item in an autofill fil response group. + * @brief Adds autofill item in an autofill fill response group. * @since_tizen 5.5 * @param[in] h The autofill fill response group handle * @param[in] it The autofill fill response item handle @@ -1170,6 +1170,7 @@ int autofill_error_info_set_error_code(autofill_error_info_h ei, autofill_error_ * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error * @retval #AUTOFILL_ERROR_INVALID_PARAMETER Invalid parameter + * @see get_error_message() */ int autofill_error_info_get_error_code(autofill_error_info_h ei, autofill_error_e *error_code); -- 2.7.4 From 6b98da4a96ef15efa93ef70214cf76a6bc892519 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 22 Mar 2019 15:45:28 +0900 Subject: [PATCH 03/16] Update package version to 0.1.25 Change-Id: Iba75ed39d94ea8f3e5e175b835ad41ff374645d1 Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 6a3656d..e0031e4 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -1,6 +1,6 @@ Name: capi-ui-autofill Summary: Autofill Library -Version: 0.1.24 +Version: 0.1.25 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From d76b22c8295d11649848077b410d4286f8ef8389 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 5 Apr 2019 15:23:38 +0900 Subject: [PATCH 04/16] Fix coding style Change-Id: I71ac295aa1ae3eda54a59d0d977eda9c83db7e60 Signed-off-by: Jihoon Kim --- include/autofill_common.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/autofill_common.h b/include/autofill_common.h index dbf44d3..c8f7512 100644 --- a/include/autofill_common.h +++ b/include/autofill_common.h @@ -39,8 +39,7 @@ extern "C" { * * @since_tizen 5.5 */ -typedef enum -{ +typedef enum { AUTOFILL_HINT_CREDIT_CARD_EXPIRATION_DATE, /**< Autofill hint for a credit card expiration date */ AUTOFILL_HINT_CREDIT_CARD_EXPIRATION_DAY, /**< Autofill hint for a credit card expiration day */ AUTOFILL_HINT_CREDIT_CARD_EXPIRATION_MONTH, /**< Autofill hint for a credit card expiration month */ -- 2.7.4 From 0748052932b20355db6c901b3cbe2631aaf38765 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Mon, 8 Apr 2019 14:15:25 +0900 Subject: [PATCH 05/16] Remove unnecessary codes Change-Id: I39bde0053bdb138ddfbf72505e71bb938c22e3ea Signed-off-by: Jihoon Kim --- service_lib/autofill_service.c | 34 ++-------------------------------- 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/service_lib/autofill_service.c b/service_lib/autofill_service.c index 4c7654d..5307ff3 100644 --- a/service_lib/autofill_service.c +++ b/service_lib/autofill_service.c @@ -347,34 +347,6 @@ static void __destroy_client(gpointer data) free(handle); } -static void __message_create(rpc_port_stub_AutofillSvcPort_context_h context, - void *user_data) -{ - LOGD(""); - char *sender = NULL; - - rpc_port_stub_AutofillSvcPort_context_get_sender(context, &sender); - if (!sender) - return; - - LOGD("sender(%s)", sender); - free(sender); -} - -static void __message_terminate(rpc_port_stub_AutofillSvcPort_context_h context, - void *user_data) -{ - LOGD(""); - char *sender = NULL; - - rpc_port_stub_AutofillSvcPort_context_get_sender(context, &sender); - if (!sender) - return; - - LOGD("sender(%s)", sender); - free(sender); -} - static int __message_register(rpc_port_stub_AutofillSvcPort_context_h context, rpc_port_AutofillSvcPort_autofill_svc_auth_info_cb_h auth_info_cb, rpc_port_AutofillSvcPort_autofill_svc_fill_response_cb_h fill_response_received_cb, @@ -388,8 +360,6 @@ static int __message_register(rpc_port_stub_AutofillSvcPort_context_h context, if (!sender) return -1; - LOGD("sender(%s)", sender); - autofill_svc_s *client; client = __create_client(sender, auth_info_cb, fill_response_received_cb, send_error_cb); free(sender); @@ -430,8 +400,8 @@ EXPORT_API int autofill_service_initialize(void) int ret; rpc_port_stub_AutofillSvcPort_callback_s callback = { - __message_create, - __message_terminate, + NULL, + NULL, __message_register, __message_unregister, __auth_info_request_cb, -- 2.7.4 From 7b286ed05c78bdcc860d811bc68f85cb5a384103 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Mon, 15 Apr 2019 19:04:26 +0900 Subject: [PATCH 06/16] Change as appropriate log level Change-Id: I21e941be996a0ae99f8f73e9fa1f2f3fdb56ca1c Signed-off-by: Jihoon Kim --- client/autofill.c | 6 +++--- manager/autofill_manager.c | 6 +++--- service_lib/autofill_service.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/client/autofill.c b/client/autofill.c index 768392b..a3706eb 100644 --- a/client/autofill.c +++ b/client/autofill.c @@ -197,7 +197,7 @@ static void __error_info_recv_cb(void *user_data, rpc_port_autofill_error_info_h autofill_error_info_set_app_id(eih, app_id); autofill_error_info_set_error_code(eih, error_code); - LOGD("error code : %x", error_code); + LOGI("error code : %x", error_code); if (app_id) free(app_id); @@ -240,7 +240,7 @@ static void __on_connected(rpc_port_proxy_AutofillAppPort_h h, void *user_data) //LCOV_EXCL_START static void __on_disconnected(rpc_port_proxy_AutofillAppPort_h h, void *user_data) { - LOGD("disconnected"); + LOGI("disconnected"); autofill_h ah = user_data; if (ah) { @@ -255,7 +255,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillAppPort_h h, void *user_dat static void __on_rejected(rpc_port_proxy_AutofillAppPort_h h, void *user_data) { - LOGD("rejected"); + LOGI("rejected"); autofill_h ah = user_data; diff --git a/manager/autofill_manager.c b/manager/autofill_manager.c index b452824..4998d0e 100644 --- a/manager/autofill_manager.c +++ b/manager/autofill_manager.c @@ -40,7 +40,7 @@ struct autofill_manager_s { static void __on_connected(rpc_port_proxy_AutofillManagerPort_h h, void *user_data) { autofill_manager_h amh = user_data; - LOGI("[__RPC_PORT__] connected"); + LOGI("connected"); if (amh->connection_callback) amh->connection_callback(amh, AUTOFILL_MANAGER_CONNECTION_STATUS_CONNECTED, amh->connection_userdata); @@ -50,7 +50,7 @@ static void __on_connected(rpc_port_proxy_AutofillManagerPort_h h, void *user_da static void __on_disconnected(rpc_port_proxy_AutofillManagerPort_h h, void *user_data) { autofill_manager_h amh = user_data; - LOGD("disconnected"); + LOGI("disconnected"); if (amh->connection_callback) amh->connection_callback(amh, AUTOFILL_MANAGER_CONNECTION_STATUS_DISCONNECTED, amh->connection_userdata); @@ -61,7 +61,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillManagerPort_h h, void *user static void __on_rejected(rpc_port_proxy_AutofillManagerPort_h h, void *user_data) { autofill_manager_h amh = user_data; - LOGD("rejected"); + LOGI("rejected"); if (amh->connection_callback) amh->connection_callback(amh, AUTOFILL_MANAGER_CONNECTION_STATUS_REJECTED, amh->connection_userdata); diff --git a/service_lib/autofill_service.c b/service_lib/autofill_service.c index 5307ff3..590f2d5 100644 --- a/service_lib/autofill_service.c +++ b/service_lib/autofill_service.c @@ -412,7 +412,7 @@ EXPORT_API int autofill_service_initialize(void) ret = rpc_port_stub_AutofillSvcPort_register(&callback, NULL); if (ret != 0) - LOGI("Failed to register message"); + LOGW("Failed to register message"); else LOGI("Succeeded to register message"); -- 2.7.4 From 82ccaf8ced5f02ad1329af0363c0b3718bc8372e Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 18 Apr 2019 17:24:02 +0900 Subject: [PATCH 07/16] Update package version to 0.1.26 Change-Id: I429cf5b3ef11035c30d312e7976527b5b425a78a Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index e0031e4..508dbd5 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -1,6 +1,6 @@ Name: capi-ui-autofill Summary: Autofill Library -Version: 0.1.25 +Version: 0.1.26 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From 669bbb5dfc78d7d8fec6af3d8157d967263d1de8 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 3 May 2019 11:32:52 +0900 Subject: [PATCH 08/16] Add view title information in save view info Change-Id: I07bb03eec89059c0a54ea90855d56ae581bd8e85 Signed-off-by: Jihoon Kim --- client/autofill.c | 3 ++- common/autofill_save_view_info.c | 31 +++++++++++++++++++++++++++++++ include/autofill_common.h | 24 ++++++++++++++++++++++++ include/autofill_private.h | 1 + service_lib/autofill_service.c | 7 +++++++ tidl/autofill.tidl | 1 + tidl/autofill_service.tidl | 1 + 7 files changed, 67 insertions(+), 1 deletion(-) diff --git a/client/autofill.c b/client/autofill.c index a3706eb..c53c86e 100644 --- a/client/autofill.c +++ b/client/autofill.c @@ -383,6 +383,7 @@ EXPORT_API int autofill_commit(autofill_h ah, autofill_save_view_info_h vi) rpc_port_autofill_save_view_info_create(&vih); rpc_port_autofill_save_view_info_set_view_id(vih, vi->view_id); + rpc_port_autofill_save_view_info_set_view_title(vih, vi->view_title); Eina_List *l; autofill_save_item_h it; @@ -423,7 +424,7 @@ EXPORT_API int autofill_commit(autofill_h ah, autofill_save_view_info_h vi) rpc_port_autofill_save_item_destroy(aih); } - LOGD("app id : %s, view id : %s", vi->app_id, vi->view_id); + LOGD("app id : %s, view id : '%s', view title : '%s'", vi->app_id, vi->view_id, vi->view_title); int ret = rpc_port_proxy_AutofillAppPort_invoke_commit(ah->rpc_h, ah->context_id, vih); diff --git a/common/autofill_save_view_info.c b/common/autofill_save_view_info.c index 5185e1e..2fadfee 100644 --- a/common/autofill_save_view_info.c +++ b/common/autofill_save_view_info.c @@ -58,6 +58,11 @@ EXPORT_API int autofill_save_view_info_destroy(autofill_save_view_info_h vi) vi->view_id = NULL; } + if (vi->view_title) { + free(vi->view_title); + vi->view_title = NULL; + } + // release memory autofill item list autofill_save_item_h it_h; EINA_LIST_FREE(vi->autofill_save_item_list, it_h) @@ -121,6 +126,32 @@ EXPORT_API int autofill_save_view_info_get_view_id(autofill_save_view_info_h vi, return AUTOFILL_ERROR_NONE; } +EXPORT_API int autofill_save_view_info_set_view_title(autofill_save_view_info_h vi, const char *view_title) +{ + if (!vi || !view_title) + return AUTOFILL_ERROR_INVALID_PARAMETER; + + if (vi->view_title) + free(vi->view_title); + + vi->view_title = strdup(view_title); + + return AUTOFILL_ERROR_NONE; +} + +EXPORT_API int autofill_save_view_info_get_view_title(autofill_save_view_info_h vi, char **view_title) +{ + if (!vi || !view_title) + return AUTOFILL_ERROR_INVALID_PARAMETER; + + if (!vi->view_title) + return AUTOFILL_ERROR_OPERATION_FAILED; + + *view_title = strdup(vi->view_title); + + return AUTOFILL_ERROR_NONE; +} + EXPORT_API int autofill_save_view_info_add_item(autofill_save_view_info_h vi, autofill_save_item_h it) { if (!vi || !it) diff --git a/include/autofill_common.h b/include/autofill_common.h index c8f7512..6d8d1da 100644 --- a/include/autofill_common.h +++ b/include/autofill_common.h @@ -662,6 +662,30 @@ int autofill_save_view_info_set_view_id(autofill_save_view_info_h vi, const char int autofill_save_view_info_get_view_id(autofill_save_view_info_h vi, char **view_id); /** + * @brief Sets the view title in autofill save view information. + * @since_tizen 5.5 + * @param[in] vi The autofill view info handle + * @param[in] view_title The view title + * @return 0 on success, otherwise a negative error value + * @retval #AUTOFILL_ERROR_NONE No error + * @retval #AUTOFILL_ERROR_INVALID_PARAMETER Invalid parameter + */ +int autofill_save_view_info_set_view_title(autofill_save_view_info_h vi, const char *view_title); + +/** + * @brief Gets the view title in autofill save view information. + * @since_tizen 5.5 + * @remarks @a view_title must be released using free(). + * @param[in] vi The autofill view info handle + * @param[out] view_title The view title + * @return 0 on success, otherwise a negative error value + * @retval #AUTOFILL_ERROR_NONE No error + * @retval #AUTOFILL_ERROR_INVALID_PARAMETER Invalid parameter + * @retval #AUTOFILL_ERROR_OPERATION_FAILED Operation failure + */ +int autofill_save_view_info_get_view_title(autofill_save_view_info_h vi, char **view_title); + +/** * @brief Adds autofill save item in autofill save view information. * @since_tizen 5.5 * @param[in] vi The autofill save view info handle diff --git a/include/autofill_private.h b/include/autofill_private.h index 363cf85..31012b2 100644 --- a/include/autofill_private.h +++ b/include/autofill_private.h @@ -50,6 +50,7 @@ struct autofill_view_info_s { struct autofill_save_view_info_s { char *app_id; // app ID char *view_id; // view unique ID or web page URL (URL started with http:// or https://) + char *view_title; // view title Eina_List *autofill_save_item_list; // autofill_save_item_h list }; diff --git a/service_lib/autofill_service.c b/service_lib/autofill_service.c index 590f2d5..ebca4b5 100644 --- a/service_lib/autofill_service.c +++ b/service_lib/autofill_service.c @@ -227,9 +227,11 @@ static void __autofill_commit_cb(rpc_port_stub_AutofillSvcPort_context_h context { char *app_id = NULL; char *view_id = NULL; + char *view_title = NULL; rpc_port_autofill_svc_save_view_info_get_app_id(vi, &app_id); rpc_port_autofill_svc_save_view_info_get_view_id(vi, &view_id); + rpc_port_autofill_svc_save_view_info_get_view_title(vi, &view_title); LOGD("app id : %s, view id : %s", app_id, view_id); @@ -237,6 +239,7 @@ static void __autofill_commit_cb(rpc_port_stub_AutofillSvcPort_context_h context autofill_save_view_info_create(&view_info); autofill_save_view_info_set_app_id(view_info, app_id); autofill_save_view_info_set_view_id(view_info, view_id); + autofill_save_view_info_set_view_title(view_info, view_title); rpc_port_autofill_svc_save_view_info_foreach_items(vi, __save_item_cb, view_info); @@ -252,6 +255,10 @@ static void __autofill_commit_cb(rpc_port_stub_AutofillSvcPort_context_h context if (view_id) { free(view_id); } + + if (view_title) { + free(view_title); + } } static void __terminate_received_cb(rpc_port_stub_AutofillSvcPort_context_h context, void *user_data) diff --git a/tidl/autofill.tidl b/tidl/autofill.tidl index fbf53b4..bfac23d 100644 --- a/tidl/autofill.tidl +++ b/tidl/autofill.tidl @@ -21,6 +21,7 @@ struct autofill_save_item { struct autofill_save_view_info { string view_id; + string view_title; list items; } diff --git a/tidl/autofill_service.tidl b/tidl/autofill_service.tidl index 31a4809..ffe3dc1 100644 --- a/tidl/autofill_service.tidl +++ b/tidl/autofill_service.tidl @@ -23,6 +23,7 @@ struct autofill_svc_save_item { struct autofill_svc_save_view_info { string app_id; string view_id; + string view_title; list items; } -- 2.7.4 From aff2faa298afd4b5d36249a265dc02d99f500470 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 7 May 2019 19:35:44 +0900 Subject: [PATCH 09/16] Update package version to 0.1.27 Change-Id: I7f4c905ea3df7bf786f8f4b9f5da7f73d01fb4e2 Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 508dbd5..7add489 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -1,6 +1,6 @@ Name: capi-ui-autofill Summary: Autofill Library -Version: 0.1.26 +Version: 0.1.27 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From 6a01fae69a47f0e5d28a54270c674b3eb769905e Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 8 May 2019 13:58:05 +0900 Subject: [PATCH 10/16] Use appropriate preposition in doxygen of getting APIs Change-Id: Ib157a500532149b9874727b83dbe361d5c5d7bfc Signed-off-by: Jihoon Kim --- include/autofill_common.h | 58 +++++++++++++++++++++++------------------------ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/include/autofill_common.h b/include/autofill_common.h index 6d8d1da..5a6ad96 100644 --- a/include/autofill_common.h +++ b/include/autofill_common.h @@ -208,7 +208,7 @@ int autofill_item_clone(autofill_item_h it, autofill_item_h *clone); int autofill_item_set_autofill_hint(autofill_item_h it, autofill_hint_e hint); /** - * @brief Gets the autofill hint in an autofill item. + * @brief Gets the autofill hint from an autofill item. * @since_tizen 5.5 * @param[in] it The autofill item handle * @param[out] hint The autofill hint @@ -230,7 +230,7 @@ int autofill_item_get_autofill_hint(autofill_item_h it, autofill_hint_e *hint); int autofill_item_set_id(autofill_item_h it, const char *id); /** - * @brief Gets the autofill ID in an autofill item. + * @brief Gets the autofill ID from an autofill item. * @since_tizen 5.5 * @remarks @a id must be released using free(). * @param[in] it The autofill item handle @@ -254,7 +254,7 @@ int autofill_item_get_id(autofill_item_h it, char **id); int autofill_item_set_label(autofill_item_h it, const char *label); /** - * @brief Gets the autofill label in an autofill item. + * @brief Gets the autofill label from an autofill item. * @since_tizen 5.5 * @remarks @a label must be released using free(). * @param[in] it The autofill item handle @@ -278,7 +278,7 @@ int autofill_item_get_label(autofill_item_h it, char **label); int autofill_item_set_sensitive_data(autofill_item_h it, bool sensitive); /** - * @brief Gets the sensitive data in an autofill item. + * @brief Gets the sensitive data from an autofill item. * @since_tizen 5.5 * @param[in] it The autofill item handle * @param[out] sensitive The sensitive data or not @@ -300,7 +300,7 @@ int autofill_item_get_sensitive_data(autofill_item_h it, bool *sensitive); int autofill_item_set_value(autofill_item_h it, const char *value); /** - * @brief Gets the autofill value in an autofill item. + * @brief Gets the autofill value from an autofill item. * @since_tizen 5.5 * @remarks @a value must be released using free(). * @param[in] it The autofill item handle @@ -346,7 +346,7 @@ int autofill_auth_info_destroy(autofill_auth_info_h ai); int autofill_auth_info_set_app_id(autofill_auth_info_h ai, const char *app_id); /** - * @brief Gets the app id in autofill authentication information. + * @brief Gets the app id from autofill authentication information. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). * @param[in] ai The autofill authentication information handle @@ -370,7 +370,7 @@ int autofill_auth_info_get_app_id(autofill_auth_info_h ai, char **app_id); int autofill_auth_info_set_view_id(autofill_auth_info_h ai, const char *view_id); /** - * @brief Gets the view id in autofill authentication information. + * @brief Gets the view id from autofill authentication information. * @since_tizen 5.5 * @remarks @a view_id must be released using free(). * @param[in] ai The autofill authentication information handle @@ -394,7 +394,7 @@ int autofill_auth_info_get_view_id(autofill_auth_info_h ai, char **view_id); int autofill_auth_info_set_autofill_data_present(autofill_auth_info_h ai, bool autofill_data_present); /** - * @brief Gets the 'autofill data present' attribute in autofill authentication information. + * @brief Gets the 'autofill data present' attribute from autofill authentication information. * @since_tizen 5.5 * @param[in] ai The autofill authentication information handle * @param[out] autofill_data_present The autofill data presence @@ -416,7 +416,7 @@ int autofill_auth_info_get_autofill_data_present(autofill_auth_info_h ai, bool * int autofill_auth_info_set_authentication_needed(autofill_auth_info_h ai, bool authentication_needed); /** - * @brief Gets the 'authentication needed' attribute in autofill authentication information. + * @brief Gets the 'authentication needed' attribute from autofill authentication information. * @since_tizen 5.5 * @param[in] ai The autofill authentication information handle * @param[out] authentication_needed The authentication need @@ -438,7 +438,7 @@ int autofill_auth_info_get_authentication_needed(autofill_auth_info_h ai, bool * int autofill_auth_info_set_service_name(autofill_auth_info_h ai, const char *service_name); /** - * @brief Gets the service name in autofill authentication information. + * @brief Gets the service name from autofill authentication information. * @since_tizen 5.5 * @remarks @a service_name must be released using free(). * @param[in] ai The autofill authentication information handle @@ -462,7 +462,7 @@ int autofill_auth_info_get_service_name(autofill_auth_info_h ai, char **service_ int autofill_auth_info_set_service_message(autofill_auth_info_h ai, const char *service_message); /** - * @brief Gets the service message in autofill authentication information. + * @brief Gets the service message from autofill authentication information. * @since_tizen 5.5 * @remarks @a service_message must be released using free(). * @param[in] ai The autofill authentication information handle @@ -486,7 +486,7 @@ int autofill_auth_info_get_service_message(autofill_auth_info_h ai, char **servi int autofill_auth_info_set_service_logo_image_path(autofill_auth_info_h ai, const char *service_logo_image_path); /** - * @brief Gets the service logo image path in autofill authentication information. + * @brief Gets the service logo image path from autofill authentication information. * @since_tizen 5.5 * @remarks @a service_logo_image_path must be released using free(). * @param[in] ai The autofill authentication information handle @@ -532,7 +532,7 @@ int autofill_view_info_destroy(autofill_view_info_h vi); int autofill_view_info_set_app_id(autofill_view_info_h vi, const char *app_id); /** - * @brief Gets the app id in autofill view information. + * @brief Gets the app id from autofill view information. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). * @param[in] vi The autofill view info handle @@ -556,7 +556,7 @@ int autofill_view_info_get_app_id(autofill_view_info_h vi, char **app_id); int autofill_view_info_set_view_id(autofill_view_info_h vi, const char *view_id); /** - * @brief Gets the view id in autofill view information. + * @brief Gets the view id from autofill view information. * @since_tizen 5.5 * @remarks @a view_id must be released using free(). * @param[in] vi The autofill view info handle @@ -625,7 +625,7 @@ int autofill_save_view_info_destroy(autofill_save_view_info_h vi); int autofill_save_view_info_set_app_id(autofill_save_view_info_h vi, const char *app_id); /** - * @brief Gets the app ID in autofill save view information. + * @brief Gets the app ID from autofill save view information. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). * @param[in] vi The autofill view info handle @@ -649,7 +649,7 @@ int autofill_save_view_info_get_app_id(autofill_save_view_info_h vi, char **app_ int autofill_save_view_info_set_view_id(autofill_save_view_info_h vi, const char *view_id); /** - * @brief Gets the view ID in autofill save view information. + * @brief Gets the view ID from autofill save view information. * @since_tizen 5.5 * @remarks @a view_id must be released using free(). * @param[in] vi The autofill view info handle @@ -673,7 +673,7 @@ int autofill_save_view_info_get_view_id(autofill_save_view_info_h vi, char **vie int autofill_save_view_info_set_view_title(autofill_save_view_info_h vi, const char *view_title); /** - * @brief Gets the view title in autofill save view information. + * @brief Gets the view title from autofill save view information. * @since_tizen 5.5 * @remarks @a view_title must be released using free(). * @param[in] vi The autofill view info handle @@ -741,7 +741,7 @@ int autofill_fill_response_destroy(autofill_fill_response_h h); int autofill_fill_response_set_app_id(autofill_fill_response_h h, const char *app_id); /** - * @brief Gets the app ID in an autofill fill response. + * @brief Gets the app ID from an autofill fill response. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). * @param[in] h The autofill fill response handle @@ -765,7 +765,7 @@ int autofill_fill_response_get_app_id(autofill_fill_response_h h, char **app_id) int autofill_fill_response_set_view_id(autofill_fill_response_h h, const char *view_id); /** - * @brief Gets the view ID in an autofill fill response. + * @brief Gets the view ID from an autofill fill response. * @since_tizen 5.5 * @remarks @a view_id must be released using free(). * @param[in] h The autofill fill response handle @@ -919,7 +919,7 @@ int autofill_fill_response_item_clone(autofill_fill_response_item_h it, autofill int autofill_fill_response_item_set_id(autofill_fill_response_item_h it, const char *id); /** - * @brief Gets the autofill ID in an autofill fill response item. + * @brief Gets the autofill ID from an autofill fill response item. * @since_tizen 5.5 * @remarks @a id must be released using free(). * @param[in] it The autofill fill response item handle @@ -943,7 +943,7 @@ int autofill_fill_response_item_get_id(autofill_fill_response_item_h it, char ** int autofill_fill_response_item_set_value(autofill_fill_response_item_h it, const char *value); /** - * @brief Gets the autofill value in an autofill fill response item. + * @brief Gets the autofill value from an autofill fill response item. * @since_tizen 5.5 * @remarks @a value must be released using free(). * @param[in] it The autofill fill response item handle @@ -967,7 +967,7 @@ int autofill_fill_response_item_get_value(autofill_fill_response_item_h it, char int autofill_fill_response_item_set_presentation_text(autofill_fill_response_item_h it, const char *presentation_text); /** - * @brief Gets the presentation text in an autofill fill response item. + * @brief Gets the presentation text from an autofill fill response item. * @since_tizen 5.5 * @remarks @a presentation_text must be released using free(). * @param[in] it The autofill fill response item handle @@ -1024,7 +1024,7 @@ int autofill_save_item_clone(autofill_save_item_h it, autofill_save_item_h *clon int autofill_save_item_set_autofill_hint(autofill_save_item_h it, autofill_hint_e hint); /** - * @brief Gets the autofill hint in an autofill save item. + * @brief Gets the autofill hint from an autofill save item. * @since_tizen 5.5 * @param[in] it The autofill save item handle * @param[out] hint The autofill hint @@ -1046,7 +1046,7 @@ int autofill_save_item_get_autofill_hint(autofill_save_item_h it, autofill_hint_ int autofill_save_item_set_id(autofill_save_item_h it, const char *id); /** - * @brief Gets the autofill ID in an autofill save item. + * @brief Gets the autofill ID from an autofill save item. * @since_tizen 5.5 * @remarks @a id must be released using free(). * @param[in] it The autofill save item handle @@ -1070,7 +1070,7 @@ int autofill_save_item_get_id(autofill_save_item_h it, char **id); int autofill_save_item_set_label(autofill_save_item_h it, const char *label); /** - * @brief Gets the autofill label in an autofill save item. + * @brief Gets the autofill label from an autofill save item. * @since_tizen 5.5 * @remarks @a label must be released using free(). * @param[in] it The autofill save item handle @@ -1094,7 +1094,7 @@ int autofill_save_item_get_label(autofill_save_item_h it, char **label); int autofill_save_item_set_sensitive_data(autofill_save_item_h it, bool sensitive); /** - * @brief Gets the sensitive data in an autofill save item. + * @brief Gets the sensitive data from an autofill save item. * @since_tizen 5.5 * @param[in] it The autofill save item handle * @param[out] sensitive The sensitive data or not @@ -1116,7 +1116,7 @@ int autofill_save_item_get_sensitive_data(autofill_save_item_h it, bool *sensiti int autofill_save_item_set_value(autofill_save_item_h it, const char *value); /** - * @brief Gets the autofill value in an autofill save item. + * @brief Gets the autofill value from an autofill save item. * @since_tizen 5.5 * @remarks @a value must be released using free(). * @param[in] it The autofill save item handle @@ -1162,7 +1162,7 @@ int autofill_error_info_destroy(autofill_error_info_h ei); int autofill_error_info_set_app_id(autofill_error_info_h ei, const char *app_id); /** - * @brief Gets the app id in autofill error information. + * @brief Gets the app id from autofill error information. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). * @param[in] ei The autofill error information handle @@ -1186,7 +1186,7 @@ int autofill_error_info_get_app_id(autofill_error_info_h ei, char **app_id); int autofill_error_info_set_error_code(autofill_error_info_h ei, autofill_error_e error_code); /** - * @brief Gets the error code in autofill error information. + * @brief Gets the error code from autofill error information. * @since_tizen 5.5 * @param[in] ei The autofill error information handle * @param[out] error_code The autofill error code -- 2.7.4 From bc4a4ace3734393aec392e7bce966922f044abc7 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 16 May 2019 14:50:46 +0900 Subject: [PATCH 11/16] Fix build dependency Change-Id: Idff8d285821d61db09dc77a63ed2567d16f9f6e9 Signed-off-by: Jihoon Kim --- common/CMakeLists.txt | 2 +- packaging/capi-ui-autofill.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt index 6280293..2cfe2ac 100644 --- a/common/CMakeLists.txt +++ b/common/CMakeLists.txt @@ -7,7 +7,7 @@ SET(maintainer "Jihoon Kim ") SET(description "Autofill Common APIs") SET(service "ui") SET(submodule "autofill-common") -SET(dependents "capi-base-common dlog eina efl glib-2.0 rpc-port") +SET(dependents "capi-base-common dlog eina") SET(LIBDIR ${LIB_INSTALL_DIR}) SET(Services diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 7add489..9a8c9be 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -12,7 +12,7 @@ BuildRequires: pkgconfig(capi-base-common) BuildRequires: pkgconfig(capi-appfw-service-application) BuildRequires: pkgconfig(dlog) BuildRequires: pkgconfig(eina) -BuildRequires: pkgconfig(efl) +BuildRequires: pkgconfig(ecore) BuildRequires: pkgconfig(rpc-port) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(cynara-client) -- 2.7.4 From ac6d684c6441d38f6bd060f45ad66fd1ce9cb618 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 16 May 2019 15:12:10 +0900 Subject: [PATCH 12/16] Add build dependency for autofill daemon Change-Id: I0d691fce7e252fd5087ec61521ac396674474229 Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 1 + 1 file changed, 1 insertion(+) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 9a8c9be..86b764c 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -19,6 +19,7 @@ BuildRequires: pkgconfig(cynara-client) BuildRequires: pkgconfig(cynara-session) BuildRequires: pkgconfig(capi-appfw-app-manager) BuildRequires: pkgconfig(capi-appfw-preference) +Requires: org.tizen.autofilld Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig -- 2.7.4 From b69adf69c20b87be47109ffa9d7c46c5096bccaa Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 28 May 2019 19:44:22 +0900 Subject: [PATCH 13/16] Update package version to 0.1.28 Change-Id: I3157b99dda56c74b9d7f3096ce6ae7f49adeaef0 Signed-off-by: Jihoon Kim --- packaging/capi-ui-autofill.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-ui-autofill.spec b/packaging/capi-ui-autofill.spec index 86b764c..c87118c 100644 --- a/packaging/capi-ui-autofill.spec +++ b/packaging/capi-ui-autofill.spec @@ -1,6 +1,6 @@ Name: capi-ui-autofill Summary: Autofill Library -Version: 0.1.27 +Version: 0.1.28 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From 9af24a47f9377c64177b8b2b3bb6f8de152fb1a8 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 30 May 2019 19:12:10 +0900 Subject: [PATCH 14/16] Remove unused lines Change-Id: I75223bfb93207b6ff020a3e7f2cd768ca0de0433 Signed-off-by: Jihoon Kim --- CMakeLists.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 71a1b45..27785ee 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -9,7 +9,6 @@ SET(VERSION 0.2.44) FIND_PROGRAM(UNAME NAMES uname) EXEC_PROGRAM("${UNAME}" ARGS "-m" OUTPUT_VARIABLE "ARCH") -#ADD_DEFINITIONS("-DTTS_LIBDIR=\"${LIBDIR}\"") ADD_DEFINITIONS("-Werror") ## Include common directory ## @@ -18,9 +17,6 @@ INCLUDE_DIRECTORIES("${CMAKE_SOURCE_DIR}/common") ## Dependent packages ## INCLUDE(FindPkgConfig) -## API ## -#ADD_SUBDIRECTORY(include) - ## Autofill common library ## ADD_SUBDIRECTORY(common) -- 2.7.4 From 5a11f1a7865e7d0c9e704187947ef466ddf0815a Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 5 Jun 2019 14:08:33 +0900 Subject: [PATCH 15/16] Fix documentation about autofill save view Change-Id: I6a72eebf4602b3d33931a4ba76993c085abc74d6 Signed-off-by: Jihoon Kim --- include/autofill_common.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/include/autofill_common.h b/include/autofill_common.h index 5a6ad96..1ce7fca 100644 --- a/include/autofill_common.h +++ b/include/autofill_common.h @@ -595,7 +595,7 @@ int autofill_view_info_foreach_item(autofill_view_info_h vi, autofill_item_cb ca * @brief Creates autofill save view information. * @since_tizen 5.5 * @remarks If the function succeeds, @a vi handle must be released with autofill_save_view_info_destroy() - * @param[out] vi The autofill view info handle + * @param[out] vi The handle of autofill for the saving view * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error * @retval #AUTOFILL_ERROR_INVALID_PARAMETER Invalid parameter @@ -616,7 +616,7 @@ int autofill_save_view_info_destroy(autofill_save_view_info_h vi); /** * @brief Sets the app ID in autofill save view information. * @since_tizen 5.5 - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[in] app_id The app ID * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -628,7 +628,7 @@ int autofill_save_view_info_set_app_id(autofill_save_view_info_h vi, const char * @brief Gets the app ID from autofill save view information. * @since_tizen 5.5 * @remarks @a app_id must be released using free(). - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[out] app_id The app ID * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -640,7 +640,7 @@ int autofill_save_view_info_get_app_id(autofill_save_view_info_h vi, char **app_ /** * @brief Sets the view ID in autofill save view information. * @since_tizen 5.5 - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[in] view_id The view ID * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -652,7 +652,7 @@ int autofill_save_view_info_set_view_id(autofill_save_view_info_h vi, const char * @brief Gets the view ID from autofill save view information. * @since_tizen 5.5 * @remarks @a view_id must be released using free(). - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[out] view_id The view ID * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -662,9 +662,9 @@ int autofill_save_view_info_set_view_id(autofill_save_view_info_h vi, const char int autofill_save_view_info_get_view_id(autofill_save_view_info_h vi, char **view_id); /** - * @brief Sets the view title in autofill save view information. + * @brief Sets the title of the view having autofill entries. * @since_tizen 5.5 - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[in] view_title The view title * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -673,10 +673,10 @@ int autofill_save_view_info_get_view_id(autofill_save_view_info_h vi, char **vie int autofill_save_view_info_set_view_title(autofill_save_view_info_h vi, const char *view_title); /** - * @brief Gets the view title from autofill save view information. + * @brief Gets the title of the view having autofill entries. * @since_tizen 5.5 * @remarks @a view_title must be released using free(). - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[out] view_title The view title * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -688,7 +688,7 @@ int autofill_save_view_info_get_view_title(autofill_save_view_info_h vi, char ** /** * @brief Adds autofill save item in autofill save view information. * @since_tizen 5.5 - * @param[in] vi The autofill save view info handle + * @param[in] vi The handle of autofill for the saving view * @param[in] it The autofill save item handle * @return 0 on success, otherwise a negative error value * @retval #AUTOFILL_ERROR_NONE No error @@ -699,7 +699,7 @@ int autofill_save_view_info_add_item(autofill_save_view_info_h vi, autofill_save /** * @brief Retrieves all items in autofill save view information. * @since_tizen 5.5 - * @param[in] vi The autofill view info handle + * @param[in] vi The handle of autofill for the saving view * @param[in] callback The callback function to register * @param[in] user_data The user data to be passed to the callback function * @return 0 on success, otherwise a negative error value -- 2.7.4 From 2bea274dea97cff9cf0a07787147b9f54fb88247 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 3 Jul 2019 16:10:38 +0900 Subject: [PATCH 16/16] Change log level Change-Id: I8c92125befbe304089af06c244197606823cbb01 Signed-off-by: Jihoon Kim --- client/autofill.c | 6 +++--- manager/autofill_manager.c | 14 +++++++------- service_lib/autofill_service.c | 12 ++++++------ 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/client/autofill.c b/client/autofill.c index c53c86e..17edcdd 100644 --- a/client/autofill.c +++ b/client/autofill.c @@ -49,7 +49,7 @@ static bool fill_response_item_cb(rpc_port_autofill_response_item_h response_ite rpc_port_autofill_response_item_get_presentation_text(response_items, &presentation_text); rpc_port_autofill_response_item_get_value(response_items, &value); - LOGD("id : %s, presentation text : %s, value : %s", id, presentation_text, value); + SECURE_LOGD("id : %s, presentation text : %s, value : %s", id, presentation_text, value); autofill_fill_response_item_h ritem; @@ -255,7 +255,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillAppPort_h h, void *user_dat static void __on_rejected(rpc_port_proxy_AutofillAppPort_h h, void *user_data) { - LOGI("rejected"); + LOGW("Connection rejected"); autofill_h ah = user_data; @@ -316,7 +316,7 @@ EXPORT_API int autofill_destroy(autofill_h ah) EXPORT_API int autofill_connect(autofill_h ah, autofill_connection_status_changed_cb callback, void *user_data) { - LOGD("autofill connect. handle : %p", ah); + LOGI("autofill connect. handle : %p", ah); int ret; diff --git a/manager/autofill_manager.c b/manager/autofill_manager.c index 4998d0e..9baadc8 100644 --- a/manager/autofill_manager.c +++ b/manager/autofill_manager.c @@ -61,7 +61,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillManagerPort_h h, void *user static void __on_rejected(rpc_port_proxy_AutofillManagerPort_h h, void *user_data) { autofill_manager_h amh = user_data; - LOGI("rejected"); + LOGW("rejected"); if (amh->connection_callback) amh->connection_callback(amh, AUTOFILL_MANAGER_CONNECTION_STATUS_REJECTED, amh->connection_userdata); @@ -72,7 +72,7 @@ EXPORT_API int autofill_manager_create(autofill_manager_h *amh) { int ret; - LOGD("autofill manager initialize"); + LOGI("autofill manager initialize"); if (!amh) { LOGW("[ERROR] Invalid paramater"); @@ -111,7 +111,7 @@ EXPORT_API int autofill_manager_create(autofill_manager_h *amh) EXPORT_API int autofill_manager_destroy(autofill_manager_h amh) { - LOGD("autofill manager deinitialize"); + LOGI("autofill manager deinitialize"); if (!amh) { LOGW("[ERROR] Invalid paramater"); @@ -140,7 +140,7 @@ EXPORT_API int autofill_manager_destroy(autofill_manager_h amh) EXPORT_API int autofill_manager_connect(autofill_manager_h amh, autofill_manager_connection_status_changed_cb callback, void *user_data) { - LOGD("autofill manager connect"); + LOGI("autofill manager connect"); int ret; @@ -179,7 +179,7 @@ EXPORT_API int autofill_manager_connect(autofill_manager_h amh, autofill_manager EXPORT_API int autofill_manager_set_autofill_service(autofill_manager_h amh, const char *app_id) { - LOGD("autofill manager set autofill service"); + LOGI("autofill manager set autofill service. app id : %s", app_id); if (!amh || !app_id) { LOGW("[ERROR] parameter is NULL"); @@ -206,7 +206,7 @@ EXPORT_API int autofill_manager_set_autofill_service(autofill_manager_h amh, con EXPORT_API int autofill_manager_get_autofill_service(autofill_manager_h amh, char **service_app_id) { - LOGD("autofill manager get autofill service"); + LOGI("autofill manager get autofill service"); if (!amh || !service_app_id) { LOGW("[ERROR] parameter is NULL"); @@ -225,7 +225,7 @@ EXPORT_API int autofill_manager_get_autofill_service(autofill_manager_h amh, cha char *app_id = rpc_port_proxy_AutofillManagerPort_invoke_get_autofill_service(amh->rpc_h); if (app_id) { - LOGD("service id : %s", app_id); + LOGI("service id : %s", app_id); *service_app_id = strdup(app_id); free(app_id); return AUTOFILL_ERROR_NONE; diff --git a/service_lib/autofill_service.c b/service_lib/autofill_service.c index ebca4b5..3ddaf7c 100644 --- a/service_lib/autofill_service.c +++ b/service_lib/autofill_service.c @@ -91,7 +91,7 @@ bool __autofill_item_cb(rpc_port_autofill_svc_item_h items, void *user_data) rpc_port_autofill_svc_item_get_value(items, &value); autofill_item_set_value(ai, value); if (value) { - LOGD("value : %s", value); + SECURE_LOGD("value : %s", value); free(value); } @@ -140,7 +140,7 @@ bool __save_item_cb(rpc_port_autofill_svc_save_item_h items, void *user_data) rpc_port_autofill_svc_save_item_get_value(items, &value); autofill_save_item_set_value(ai, value); if (value) { - LOGD("value : %s", value); + SECURE_LOGD("value : %s", value); free(value); } @@ -263,7 +263,7 @@ static void __autofill_commit_cb(rpc_port_stub_AutofillSvcPort_context_h context static void __terminate_received_cb(rpc_port_stub_AutofillSvcPort_context_h context, void *user_data) { - LOGD(""); + LOGI("Receive terminate request"); if (g_autofill_service_terminate_received_cb) g_autofill_service_terminate_received_cb(g_autofill_service_terminate_received_data); @@ -402,7 +402,7 @@ static void __message_unregister(rpc_port_stub_AutofillSvcPort_context_h context EXPORT_API int autofill_service_initialize(void) { - LOGD("autofill service initialize"); + LOGI("autofill service initialize"); int ret; @@ -428,7 +428,7 @@ EXPORT_API int autofill_service_initialize(void) EXPORT_API int autofill_service_deinitialize(void) { - LOGD("autofill service deinitialize"); + LOGI("autofill service deinitialize"); if (__client_list) { g_list_free_full(__client_list, __destroy_client); @@ -556,7 +556,7 @@ bool __fill_response_item_cb(autofill_fill_response_item_h it, void * user_data) autofill_fill_response_item_get_value(it, &value); autofill_fill_response_item_get_presentation_text(it, &presentation_text); - LOGD("it : %p, id : %s, value : %s, presentation text : %s", it, id, value, presentation_text); + SECURE_LOGD("it : %p, id : %s, value : %s, presentation text : %s", it, id, value, presentation_text); rpc_port_autofill_svc_response_item_create(&ritem_h); rpc_port_autofill_svc_response_item_set_id(ritem_h, id); -- 2.7.4