From f3135ee0c9067b1ada8b51c426b7f1d1d2e2be89 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Mon, 16 Oct 2017 10:16:12 +0900 Subject: [PATCH 01/16] Release version 0.1.2 Changes: - Fix the description - Exclude some lines from lcov - Fix a logical error Change-Id: Ie655c557bf47e123e0290e0a3b14586e46ee397d Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 2d61eb7..5fdea2c 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.1 +Version: 0.1.2 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From acf42114129aed41d1de86c86cb5ced66e736fc0 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Tue, 31 Oct 2017 14:39:16 +0900 Subject: [PATCH 02/16] Add exceptions and descriptions - The minimum value of the periodic interval is 10 minutes. - The maximum value of the requirement timeout is 10000 ms. - If the developer sets the job to a one-time and persistent, calling job_scheduler_schedule() will be failed. Change-Id: I060f33732a521c94d569294cf9c9b2e4d1bfce2e Signed-off-by: Hwankyu Jhun --- include/job_info.h | 10 ++++++++++ src/job_info.c | 9 +++++++++ 2 files changed, 19 insertions(+) diff --git a/include/job_info.h b/include/job_info.h index cf4a6d2..84e0eee 100644 --- a/include/job_info.h +++ b/include/job_info.h @@ -111,30 +111,40 @@ int job_info_set_periodic(job_info_h job_info, unsigned int interval); /** * @brief Sets the job to be automatically scheduled after the device reboots. * @since_tizen 4.0 + * @remarks If it's a one-time job, setting it to a persistent job returns + * a negative error value on scheduling by using job_scheduler_schedule(). * @param[in] job_info The job info handle * @param[in] persistent @c true, if the job needs to be automatically scheduled * @return @c 0 on success, * otherwise a negative error value * @retval #JOB_ERROR_NONE Successful * @retval #JOB_ERROR_INVALID_PARAMETER Invalid parameter + * @see job_info_set_once() + * @see job_scheduler_schedule() */ int job_info_set_persistent(job_info_h job_info, bool persistent); /** * @brief Sets the job not to be repeated. * @since_tizen 4.0 + * @remarks If it's a persistent job, setting it to a one-time job returns + * a negative error value on scheduling by using job_scheduler_schedule(). * @param[in] job_info The job info handle * @param[in] once @c true, if the job does not need to be repeated * @return @c 0 on success, * otherwise a negative error value * @retval #JOB_ERROR_NONE Successful * @retval #JOB_ERROR_INVALID_PARAMETER Invalid parameter + * @see job_info_set_persistent() + * @see job_scheduler_schedule() */ int job_info_set_once(job_info_h job_info, bool once); /** * @brief Sets the timeout interval of the requirements. * @since_tizen 4.0 + * @remarks If the requirements are not satisfied within the timeout value, + * the job does not start. * @param[in] job_info The job info handle * @param[in] timeout The timeout interval (ms) * @return @c 0 on success, diff --git a/src/job_info.c b/src/job_info.c index 12e9f94..534e39c 100644 --- a/src/job_info.c +++ b/src/job_info.c @@ -37,6 +37,9 @@ #define ARRAY_SIZE(x) ((sizeof(x)) / (sizeof(x[0]))) +#define MAX_REQ_TIMEOUT 10000 +#define MIN_PERIODIC_INTERVAL 10 + struct job_info_s { char *job_id; unsigned int interval; /* Periodic */ @@ -133,6 +136,9 @@ API int job_info_set_periodic(job_info_h job_info, unsigned int interval) __LINE__, NULL); } + if (interval < MIN_PERIODIC_INTERVAL) + interval = MIN_PERIODIC_INTERVAL; + job_info->interval = interval; return JOB_ERROR_NONE; @@ -212,6 +218,9 @@ API int job_info_set_requirement_timeout(job_info_h job_info, __LINE__, NULL); } + if (timeout > MAX_REQ_TIMEOUT) + timeout = MAX_REQ_TIMEOUT; + job_info->timeout = timeout; return JOB_ERROR_NONE; -- 2.7.4 From a6f8e85ab71b8bff7f1140952a2f9b93ec31e26d Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Thu, 9 Nov 2017 11:32:17 +0900 Subject: [PATCH 03/16] Release version 0.1.3 Changes: - Add exceptions and descriptions Change-Id: I40d746d1f91c9067e2574eff35f5b83305a3b9a6 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 5fdea2c..e92d3e8 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.2 +Version: 0.1.3 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From fe523f5bc6e389a41e95459135c8852bc9d66109 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 7 Dec 2018 14:02:26 +0900 Subject: [PATCH 04/16] Fix a wrong log format Change-Id: I653197ea2d893e19349bf9ef97096e2487324990 Signed-off-by: Hwankyu Jhun --- src/job_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/job_scheduler.c b/src/job_scheduler.c index 97345fd..c67feac 100644 --- a/src/job_scheduler.c +++ b/src/job_scheduler.c @@ -705,7 +705,7 @@ static int __add_int_attr_eq(ctx_sched_job_context_h context, r = ctx_sched_job_context_attribute_add_eq_int(context, name, value); if (r != 0) { /* LCOV_EXCL_START */ - _E("Failed to add integer value(%s) - %d", value, r); + _E("Failed to add integer value(%d) - %d", value, r); return r; /* LCOV_EXCL_STOP */ } -- 2.7.4 From 443e87081b7884b6e4d3fe7dde716c2d702d0e63 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Fri, 7 Dec 2018 14:15:20 +0900 Subject: [PATCH 05/16] Release version 0.1.4 Changes: - Fix a wrong log format Change-Id: Iea3d65f3102eb6137d20c06e737e8bad36d9ab6f Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index e92d3e8..1f4d0a6 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.3 +Version: 0.1.4 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From 3df6dd79ddc9ff8d53c3d9a1ca9c36a57687b958 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 20 Feb 2019 09:41:55 +0900 Subject: [PATCH 06/16] Make weak dependencies - Uses "Recommends" instead of "Requires" Change-Id: I52dad9584e64ad28aeda95a2bb6e6f60c1d4cf87 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 1f4d0a6..22ab353 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -20,7 +20,7 @@ BuildRequires: pkgconfig(cynara-creds-self) BuildRequires: pkgconfig(cynara-session) BuildRequires: pkgconfig(cynara-client) -Requires: amd-mod-job-scheduler +Recommends: amd-mod-job-scheduler %description Job Scheduler library in Tizen C API -- 2.7.4 From 877ec8c1f2ee3f8ce496278cd96503edf8f8e453 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 20 Feb 2019 13:33:34 +0900 Subject: [PATCH 07/16] Release version 0.1.5 Changes: - Make weak dependencies Change-Id: Iee0398cca31046815df2a27127c3917a52653127 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 22ab353..5b97c65 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.4 +Version: 0.1.5 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From b029e1783c2261b22d0a3906cb5c757e527823cd Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 10 Jul 2019 13:43:38 +0900 Subject: [PATCH 08/16] Make a gcov package for measuring coverage easier Change-Id: I541144e249430ccdd55503af5e3b6882d5ceb7d5 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 5b97c65..4d92fe1 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -28,17 +28,32 @@ Job Scheduler library in Tizen C API %package devel Summary: Job Scheduler library in Tizen C API (Development) Group: System/API -Requires: %{name} = %{version}-%{release} +Requires: %{name} = %{version} %description devel An Application library in SLP C API (Development) package. +%if 0%{?gcov:1} +%package gcov +Summary: Job Scheduler library(gcov) +Group: System/API + +%description gcov +gcov objects of a job scheduler library +%endif %prep %setup -q cp %{SOURCE1001} . %build +%if 0%{?gcov:1} +export CFLAGS+=" -fprofile-arcs -ftest-coverage" +export CXXFLAGS+=" -fprofile-arcs -ftest-coverage" +export FFLAGS+=" -fprofile-arcs -ftest-coverage" +export LDFLAGS+=" -lgcov" +%endif + MAJORVER=`echo %{version} | awk 'BEGIN {FS="."}{print $1}'` %cmake -DFULLVER=%{version} \ -DMAJORVER=${MAJORVER} \ @@ -46,10 +61,20 @@ MAJORVER=`echo %{version} | awk 'BEGIN {FS="."}{print $1}'` %__make %{?jobs:-j%jobs} +%if 0%{?gcov:1} +mkdir -p gcov-obj +find . -name '*.gcno' -exec cp '{}' gcov-obj ';' +%endif + %install rm -rf %{buildroot} %make_install +%if 0%{?gcov:1} +mkdir -p %{buildroot}%{_datadir}/gcov/obj +install -m 0644 gcov-obj/* %{buildroot}%{_datadir}/gcov/obj +%endif + %post -p /sbin/ldconfig %postun -p /sbin/ldconfig @@ -63,3 +88,8 @@ rm -rf %{buildroot} %{_includedir}/appfw/*.h %{_libdir}/pkgconfig/capi-appfw-job-scheduler.pc %{_libdir}/libcapi-appfw-job-scheduler.so + +%if 0%{?gcov:1} +%files gcov +%{_datadir}/gcov/obj/* +%endif -- 2.7.4 From fb57cec2551540af9d9473f5957e97885826e18d Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Mon, 15 Jul 2019 14:01:05 +0900 Subject: [PATCH 09/16] Release version 0.1.6 Changes: - Make a gcov package for measuring coverage easier Change-Id: I9339f1b3cb77aec1b8ce2d3290a8c0e78576bc76 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 4d92fe1..6c42b4e 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.5 +Version: 0.1.6 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From 063d6881189363aa9bca4505449cd434f8785c1a Mon Sep 17 00:00:00 2001 From: "SukHyung, Kang" Date: Wed, 13 Nov 2019 14:29:36 +0900 Subject: [PATCH 10/16] Fix api reference for job scheduler Change-Id: If5d199e51e7566fd04b6efad5e7ba9e846fc0166 Signed-off-by: SukHyung, Kang --- include/job_scheduler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/job_scheduler.h b/include/job_scheduler.h index ff3ae46..796cbf6 100644 --- a/include/job_scheduler.h +++ b/include/job_scheduler.h @@ -213,7 +213,7 @@ int job_scheduler_foreach_job(job_scheduler_foreach_job_cb callback, void *user_ * @see job_scheduler_service_remove() * @see job_service_start_cb() * @see job_service_stop_cb() - * @see job_scheduler_job_finished() + * @see job_scheduler_notify_job_finished() * @see #job_service_callback_s */ int job_scheduler_service_add(const char *job_id, job_service_callback_s *callback, void *user_data, job_service_h *job_service); -- 2.7.4 From cfb1a3bff8a4d942eadbafa44306f4c9a80a3df6 Mon Sep 17 00:00:00 2001 From: "SukHyung, Kang" Date: Thu, 14 Nov 2019 16:42:02 +0900 Subject: [PATCH 11/16] Release version 0.1.7 Changes: - Fix api reference for job scheduler Change-Id: I68098fab4ecf1967e87e9eec0083e04ff97acb22 Signed-off-by: SukHyung, Kang --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 6c42b4e..b2f229e 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.6 +Version: 0.1.7 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From a1ea91dd2e3d7c65f28d24dea6b082ad3fcdc27a Mon Sep 17 00:00:00 2001 From: Inkyun Kil Date: Fri, 6 Dec 2019 16:56:48 +0900 Subject: [PATCH 12/16] Update doc file for new link Change-Id: I25a7829e96771cba617525019e3724f5f199c7ec Signed-off-by: Inkyun Kil --- doc/appfw_job_scheduler_doc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/appfw_job_scheduler_doc.h b/doc/appfw_job_scheduler_doc.h index d0ee39b..5fb0011 100755 --- a/doc/appfw_job_scheduler_doc.h +++ b/doc/appfw_job_scheduler_doc.h @@ -38,7 +38,7 @@ * It is recommended to use features in your application for reliability. * You can check if the device supports the related features for this API by using @ref CAPI_SYSTEM_SYSTEM_INFO_MODULE, and control your application's actions accordingly. * To ensure your application is only running on devices with specific features, please define the features in your manifest file using the manifest editor in the SDK. - * More details on using features in your application can be found in Feature Element. + * More details on using features in your application can be found in Feature Element. */ #endif /* __TIZEN_APPFW_JOB_SCHEDULER_DOC_H__ */ -- 2.7.4 From 3125dee2970e00a3dc8c2cb25c0e13debe013c0a Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Tue, 9 Jun 2020 08:02:06 +0900 Subject: [PATCH 13/16] Release version 0.1.8 Changes: - Update doc file for new link Change-Id: I889dad179db8f73728a4d257924d85d11d6dcadc Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index b2f229e..1200908 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.7 +Version: 0.1.8 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4 From 851c6ce1b086044d0c078a322ac7f5bbe42cd940 Mon Sep 17 00:00:00 2001 From: "SukHyung, Kang" Date: Tue, 6 Oct 2020 09:48:33 +0900 Subject: [PATCH 14/16] Change documentation for job scheduler Change-Id: Ibecd19c1f4c19e71fa1476d4bba17b71dcf3ddea Signed-off-by: SukHyung, Kang --- doc/appfw_job_scheduler_doc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/appfw_job_scheduler_doc.h b/doc/appfw_job_scheduler_doc.h index 5fb0011..db47e7c 100755 --- a/doc/appfw_job_scheduler_doc.h +++ b/doc/appfw_job_scheduler_doc.h @@ -38,7 +38,7 @@ * It is recommended to use features in your application for reliability. * You can check if the device supports the related features for this API by using @ref CAPI_SYSTEM_SYSTEM_INFO_MODULE, and control your application's actions accordingly. * To ensure your application is only running on devices with specific features, please define the features in your manifest file using the manifest editor in the SDK. - * More details on using features in your application can be found in Feature Element. + * More details on featuring your application can be found from Feature Element. */ #endif /* __TIZEN_APPFW_JOB_SCHEDULER_DOC_H__ */ -- 2.7.4 From f418f08480b3e14de7a1ee94ba5f7b02e826470e Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 16 Dec 2020 14:56:26 +0900 Subject: [PATCH 15/16] Fix doc - Removes unnecessary HTML link for feature Change-Id: I243b0fc32352ef0d79224d2c1f5943a4f5a77bc0 Signed-off-by: Hwankyu Jhun --- doc/appfw_job_scheduler_doc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/appfw_job_scheduler_doc.h b/doc/appfw_job_scheduler_doc.h index db47e7c..d98f761 100755 --- a/doc/appfw_job_scheduler_doc.h +++ b/doc/appfw_job_scheduler_doc.h @@ -30,10 +30,10 @@ * * @section CAPI_JOB_SCHEDULER_MODULE_FEATURE Related Features * Some job trigger events and some functions are related with the following features: - * - http://tizen.org/feature/network.wifi - * - http://tizen.org/feature/location.gps - * - http://tizen.org/feature/battery - * - http://tizen.org/feature/usb.host + * - %http://tizen.org/feature/network.wifi + * - %http://tizen.org/feature/location.gps + * - %http://tizen.org/feature/battery + * - %http://tizen.org/feature/usb.host * * It is recommended to use features in your application for reliability. * You can check if the device supports the related features for this API by using @ref CAPI_SYSTEM_SYSTEM_INFO_MODULE, and control your application's actions accordingly. -- 2.7.4 From 726950b8d330a1722447067ca3c5ff4ebb305084 Mon Sep 17 00:00:00 2001 From: Hwankyu Jhun Date: Wed, 16 Dec 2020 14:58:31 +0900 Subject: [PATCH 16/16] Release version 0.1.9 Changes: - Change documentation for job scheduler - Fix doc Change-Id: I50b29fadd2ca5933aa4d4b8a20291c3adb3b76f9 Signed-off-by: Hwankyu Jhun --- packaging/capi-appfw-job-scheduler.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/capi-appfw-job-scheduler.spec b/packaging/capi-appfw-job-scheduler.spec index 1200908..d60feda 100644 --- a/packaging/capi-appfw-job-scheduler.spec +++ b/packaging/capi-appfw-job-scheduler.spec @@ -1,6 +1,6 @@ Name: capi-appfw-job-scheduler Summary: Job Scheduler library -Version: 0.1.8 +Version: 0.1.9 Release: 0 Group: System/API License: Apache-2.0 -- 2.7.4