From 48a6c5a2953fcb3156d839200ce81471c73eab17 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 2 Jun 2016 13:49:19 +0900 Subject: [PATCH 01/16] sensord: move operate_sensor function to sensor_client_info - it would be better to move operate_sensor() to sensor_client_info class, because it is only related with that class. - because "operate_sensor" name is ambiguous, rename it to set_pause_policy. Change-Id: I593f1380015e7d38ed413e5cda8141718942d23a Signed-off-by: kibak.yoon --- src/client/client.cpp | 2 +- src/client/sensor_client_info.cpp | 24 ++++++++++++++++++++++++ src/client/sensor_client_info.h | 2 ++ src/client/sensor_event_listener.cpp | 34 ---------------------------------- src/client/sensor_event_listener.h | 3 --- 5 files changed, 27 insertions(+), 38 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index 7effcda..e818bd8 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -164,7 +164,7 @@ static void power_save_state_cb(keynode_t *node, void *data) while (it_sensor != sensors.end()) { sensor_client_info::get_instance().get_sensor_rep(*it_sensor, prev_rep); - sensor_event_listener::get_instance().operate_sensor(*it_sensor, cur_power_save_state); + sensor_client_info::get_instance().set_pause_policy(*it_sensor, cur_power_save_state); sensor_client_info::get_instance().get_sensor_rep(*it_sensor, cur_rep); change_sensor_rep(*it_sensor, prev_rep, cur_rep); diff --git a/src/client/sensor_client_info.cpp b/src/client/sensor_client_info.cpp index 6ac154c..fcd4e80 100644 --- a/src/client/sensor_client_info.cpp +++ b/src/client/sensor_client_info.cpp @@ -616,6 +616,30 @@ bool sensor_client_info::is_event_active(int handle, unsigned int event_type, un return true; } +void sensor_client_info::set_pause_policy(sensor_id_t sensor, int pause_policy) +{ + sensor_handle_info_map handles_info; + + get_sensor_handle_info(sensor, handles_info); + + for (auto it_handle = handles_info.begin(); it_handle != handles_info.end(); ++it_handle) { + if (it_handle->second.m_sensor_id != sensor) + continue; + + if (pause_policy && (it_handle->second.m_pause_policy & pause_policy)) { + if (it_handle->second.m_sensor_state == SENSOR_STATE_STARTED) { + set_sensor_state(it_handle->first, SENSOR_STATE_PAUSED); + _I("%s's %s[%d] is paused", get_client_name(), get_sensor_name(sensor), it_handle->first); + } + } else { + if (it_handle->second.m_sensor_state == SENSOR_STATE_PAUSED) { + set_sensor_state(it_handle->first, SENSOR_STATE_STARTED); + _I("%s's %s[%d] is resumed", get_client_name(), get_sensor_name(sensor), it_handle->first); + } + } + } +} + void sensor_client_info::clear(void) { close_command_channel(); diff --git a/src/client/sensor_client_info.h b/src/client/sensor_client_info.h index ac3a56f..1d2ba9b 100644 --- a/src/client/sensor_client_info.h +++ b/src/client/sensor_client_info.h @@ -107,6 +107,8 @@ public: void get_sensor_handle_info(sensor_id_t sensor, sensor_handle_info_map &handles_info); void get_all_handle_info(sensor_handle_info_map &handles_info); + void set_pause_policy(sensor_id_t sensor, int power_save_state); + void clear(void); sensor_client_info(); diff --git a/src/client/sensor_event_listener.cpp b/src/client/sensor_event_listener.cpp index 1b9cd07..ec8da17 100644 --- a/src/client/sensor_event_listener.cpp +++ b/src/client/sensor_event_listener.cpp @@ -60,40 +60,6 @@ sensor_event_listener& sensor_event_listener::get_instance(void) return inst; } -bool sensor_event_listener::start_handle(int handle) -{ - return m_client_info.set_sensor_state(handle, SENSOR_STATE_STARTED); -} - -bool sensor_event_listener::stop_handle(int handle) -{ - return m_client_info.set_sensor_state(handle, SENSOR_STATE_STOPPED); -} - -void sensor_event_listener::operate_sensor(sensor_id_t sensor, int power_save_state) -{ - sensor_handle_info_map handles_info; - - m_client_info.get_sensor_handle_info(sensor, handles_info); - - for (auto it_handle = handles_info.begin(); it_handle != handles_info.end(); ++it_handle) { - if (it_handle->second.m_sensor_id != sensor) - continue; - - if ((it_handle->second.m_sensor_state == SENSOR_STATE_STARTED) && - power_save_state && - (it_handle->second.m_pause_policy & power_save_state)) { - m_client_info.set_sensor_state(it_handle->first, SENSOR_STATE_PAUSED); - _I("%s's %s[%d] is paused", get_client_name(), get_sensor_name(sensor), it_handle->first); - - } else if ((it_handle->second.m_sensor_state == SENSOR_STATE_PAUSED) && - (!power_save_state || !(it_handle->second.m_pause_policy & power_save_state))) { - m_client_info.set_sensor_state(it_handle->first, SENSOR_STATE_STARTED); - _I("%s's %s[%d] is resumed", get_client_name(), get_sensor_name(sensor), it_handle->first); - } - } -} - client_callback_info* sensor_event_listener::handle_calibration_cb(sensor_handle_info &handle_info, unsigned event_type, unsigned long long time, int accuracy) { unsigned int cal_event_type = get_calibration_event_type(event_type); diff --git a/src/client/sensor_event_listener.h b/src/client/sensor_event_listener.h index 5bb92ab..417d0ad 100644 --- a/src/client/sensor_event_listener.h +++ b/src/client/sensor_event_listener.h @@ -66,10 +66,7 @@ typedef void (*hup_observer_t)(void); class sensor_event_listener { public: static sensor_event_listener& get_instance(void); - bool start_handle(int handle); - bool stop_handle(int handle); - void operate_sensor(sensor_id_t sensor, int power_save_state); void get_listening_sensors(sensor_id_vector &sensors); bool start_event_listener(void); -- 2.7.4 From cba95e8c6a0981d952980ea07f2fb4354a9df709 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 2 Jun 2016 14:07:47 +0900 Subject: [PATCH 02/16] sensord: change to use is_started() instead of using member variable directly - it would be better to use member function Change-Id: I2475768459215731d36bdd3ef00df263688c4431 Signed-off-by: kibak.yoon --- src/client/sensor_client_info.cpp | 28 ++++++++++++---------------- src/client/sensor_event_listener.cpp | 4 ++-- src/client/sensor_handle_info.cpp | 5 +++++ src/client/sensor_handle_info.h | 3 +++ 4 files changed, 22 insertions(+), 18 deletions(-) diff --git a/src/client/sensor_client_info.cpp b/src/client/sensor_client_info.cpp index fcd4e80..62de536 100644 --- a/src/client/sensor_client_info.cpp +++ b/src/client/sensor_client_info.cpp @@ -410,7 +410,6 @@ bool sensor_client_info::get_active_batch(sensor_id_t sensor, unsigned int &inte unsigned int min_interval = POLL_MAX_HZ_MS; unsigned int min_latency = std::numeric_limits::max(); - bool active_sensor_found = false; unsigned int _interval; unsigned int _latency; @@ -420,17 +419,16 @@ bool sensor_client_info::get_active_batch(sensor_id_t sensor, unsigned int &inte while (it_handle != m_sensor_handle_infos.end()) { if ((it_handle->second.m_sensor_id == sensor) && - (it_handle->second.m_sensor_state == SENSOR_STATE_STARTED)) { - active_sensor_found = true; - it_handle->second.get_batch(_interval, _latency); - min_interval = (_interval < min_interval) ? _interval : min_interval; - min_latency = (_latency < min_latency) ? _latency : min_latency; + it_handle->second.is_started()) { + it_handle->second.get_batch(_interval, _latency); + min_interval = (_interval < min_interval) ? _interval : min_interval; + min_latency = (_latency < min_latency) ? _latency : min_latency; } ++it_handle; } - if (!active_sensor_found) { + if (!is_sensor_active(sensor)) { _D("Active sensor[%#llx] is not found for client %s", sensor, get_client_name()); return false; } @@ -444,7 +442,6 @@ bool sensor_client_info::get_active_batch(sensor_id_t sensor, unsigned int &inte unsigned int sensor_client_info::get_active_pause_policy(sensor_id_t sensor) { int active_pause = SENSORD_PAUSE_ALL; - bool active_sensor_found = false; int pause; AUTOLOCK(m_handle_info_lock); @@ -453,16 +450,15 @@ unsigned int sensor_client_info::get_active_pause_policy(sensor_id_t sensor) while (it_handle != m_sensor_handle_infos.end()) { if ((it_handle->second.m_sensor_id == sensor) && - (it_handle->second.m_sensor_state == SENSOR_STATE_STARTED)) { - active_sensor_found = true; - pause = it_handle->second.m_pause_policy; - active_pause = (pause < active_pause) ? pause: active_pause; + it_handle->second.is_started()) { + pause = it_handle->second.m_pause_policy; + active_pause = (pause < active_pause) ? pause: active_pause; } ++it_handle; } - if (!active_sensor_found) + if (!is_sensor_active(sensor)) _D("Active sensor[%#llx] is not found for client %s", sensor, get_client_name()); return active_pause; @@ -510,8 +506,8 @@ void sensor_client_info::get_active_event_types(sensor_id_t sensor, event_type_v while (it_handle != m_sensor_handle_infos.end()) { if ((it_handle->second.m_sensor_id == sensor) && - (it_handle->second.m_sensor_state == SENSOR_STATE_STARTED)) - it_handle->second.get_reg_event_types(event_types); + it_handle->second.is_started()) + it_handle->second.get_reg_event_types(event_types); ++it_handle; } @@ -586,7 +582,7 @@ bool sensor_client_info::is_sensor_active(sensor_id_t sensor) while (it_handle != m_sensor_handle_infos.end()) { if ((it_handle->second.m_sensor_id == sensor) && - (it_handle->second.m_sensor_state == SENSOR_STATE_STARTED)) + it_handle->second.is_started()) return true; ++it_handle; diff --git a/src/client/sensor_event_listener.cpp b/src/client/sensor_event_listener.cpp index ec8da17..80c280b 100644 --- a/src/client/sensor_event_listener.cpp +++ b/src/client/sensor_event_listener.cpp @@ -128,8 +128,8 @@ void sensor_event_listener::handle_events(void* event) event_info = sensor_handle_info.get_reg_event_info(event_type); if ((sensor_handle_info.m_sensor_id != sensor_id) || - (sensor_handle_info.m_sensor_state != SENSOR_STATE_STARTED) || - !event_info) + !sensor_handle_info.is_started() || + !event_info) continue; if (event_info->m_fired) diff --git a/src/client/sensor_handle_info.cpp b/src/client/sensor_handle_info.cpp index 175c567..b394990 100644 --- a/src/client/sensor_handle_info.cpp +++ b/src/client/sensor_handle_info.cpp @@ -160,3 +160,8 @@ unsigned int sensor_handle_info::get_reg_event_count(void) { return m_reg_event_infos.size(); } + +bool sensor_handle_info::is_started(void) +{ + return (m_sensor_state == SENSOR_STATE_STARTED); +} diff --git a/src/client/sensor_handle_info.h b/src/client/sensor_handle_info.h index f64b2a6..28e5a01 100644 --- a/src/client/sensor_handle_info.h +++ b/src/client/sensor_handle_info.h @@ -54,6 +54,9 @@ public: void clear_all_events(void); static unsigned long long renew_event_id(void); + + bool is_started(void); + private: event_info_map m_reg_event_infos; static unsigned long long m_event_id; -- 2.7.4 From a305da78e60760135f49e9783b8d6f39cb04d791 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 2 Jun 2016 14:11:04 +0900 Subject: [PATCH 03/16] sensord: support the passive mode which listens sensor event only if a client wants to be listening sensor event which other clients start sensor, use sensord_set_passive_mode() before sensord_register_event(). Change-Id: Idbe59ed663c8a0bc268c406afcdc8cac13286b98 Signed-off-by: kibak.yoon --- src/client/client.cpp | 34 ++++++++++++++++++++++++++++++++++ src/client/sensor_client_info.cpp | 30 ++++++++++++++++++++++++++++++ src/client/sensor_client_info.h | 4 ++++ src/client/sensor_handle_info.cpp | 13 ++++++++++++- src/client/sensor_handle_info.h | 21 ++++++++++++--------- src/client/sensor_internal.h | 1 + 6 files changed, 93 insertions(+), 10 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index e818bd8..769aa9d 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -682,6 +682,28 @@ API bool sensord_disconnect(int handle) _I("%s disconnects with %s[%d]", get_client_name(), get_sensor_name(sensor_id), handle); + if (sensor_client_info::get_instance().get_passive_mode(handle)) { + _W("%s[%d] for %s is on passive mode while disconnecting.", + get_sensor_name(sensor_id), handle, get_client_name()); + + command_channel *cmd_channel; + event_type_vector event_types; + sensor_client_info::get_instance().get_active_event_types(sensor_id, event_types); + + for (auto it = event_types.begin(); it != event_types.end(); ++it) + sensord_unregister_event(handle, *it); + + if (!sensor_client_info::get_instance().get_command_channel(sensor_id, &cmd_channel)) { + _E("client %s failed to get command channel for %s", get_client_name(), get_sensor_name(sensor_id)); + return false; + } + + if (!cmd_channel->cmd_unset_batch()) { + _E("Sending cmd_unset_interval(%d, %s) failed for %s", client_id, get_sensor_name(sensor_id), get_client_name()); + return false; + } + } + if (sensor_state != SENSOR_STATE_STOPPED) { _W("%s[%d] for %s is not stopped before disconnecting.", get_sensor_name(sensor_id), handle, get_client_name()); @@ -781,6 +803,9 @@ API bool sensord_unregister_event(int handle, unsigned int event_type) sensor_client_info::get_instance().get_sensor_rep(sensor_id, cur_rep); ret = change_sensor_rep(sensor_id, prev_rep, cur_rep); + if (sensor_client_info::get_instance().get_passive_mode(handle)) + sensor_client_info::get_instance().set_passive_mode(handle, false); + if (!ret) sensor_client_info::get_instance().register_event(handle, event_type, prev_interval, prev_latency, prev_cb, prev_user_data); @@ -1197,3 +1222,12 @@ API bool sensord_register_hub_event(int handle, unsigned int event_type, unsigne return false; } +API bool sensord_set_passive_mode(int handle, bool passive) +{ + if (!sensor_client_info::get_instance().set_passive_mode(handle, passive)) { + _E("Failed to set passive mode %d", passive); + return false; + } + + return true; +} diff --git a/src/client/sensor_client_info.cpp b/src/client/sensor_client_info.cpp index 62de536..08b5a9d 100644 --- a/src/client/sensor_client_info.cpp +++ b/src/client/sensor_client_info.cpp @@ -213,6 +213,36 @@ bool sensor_client_info::set_sensor_state(int handle, int sensor_state) return true; } +bool sensor_client_info::get_passive_mode(int handle) +{ + AUTOLOCK(m_handle_info_lock); + + auto it_handle = m_sensor_handle_infos.find(handle); + + if (it_handle == m_sensor_handle_infos.end()) { + _E("Handle[%d] is not found for client %s", handle, get_client_name()); + return false; + } + + return it_handle->second.get_passive_mode(); +} + +bool sensor_client_info::set_passive_mode(int handle, bool passive) +{ + AUTOLOCK(m_handle_info_lock); + + auto it_handle = m_sensor_handle_infos.find(handle); + + if (it_handle == m_sensor_handle_infos.end()) { + _E("Handle[%d] is not found for client %s", handle, get_client_name()); + return false; + } + + it_handle->second.set_passive_mode(passive); + + return true; +} + bool sensor_client_info::set_sensor_pause_policy(int handle, int pause_policy) { AUTOLOCK(m_handle_info_lock); diff --git a/src/client/sensor_client_info.h b/src/client/sensor_client_info.h index 1d2ba9b..7c46323 100644 --- a/src/client/sensor_client_info.h +++ b/src/client/sensor_client_info.h @@ -74,6 +74,10 @@ public: bool set_sensor_params(int handle, int sensor_state, int sensor_pause_policy); bool get_sensor_params(int handle, int &sensor_state, int &sensor_pause_policy); bool set_sensor_state(int handle, int sensor_state); + + bool get_passive_mode(int handle); + bool set_passive_mode(int handle, bool passive); + bool set_sensor_pause_policy(int handle, int pause_policy); bool set_event_batch(int handle, unsigned int event_type, unsigned int interval, unsigned int latency); bool set_accuracy(int handle, int accuracy); diff --git a/src/client/sensor_handle_info.cpp b/src/client/sensor_handle_info.cpp index b394990..f1e9c65 100644 --- a/src/client/sensor_handle_info.cpp +++ b/src/client/sensor_handle_info.cpp @@ -34,6 +34,7 @@ sensor_handle_info::sensor_handle_info() , m_accuracy(-1) , m_accuracy_cb(NULL) , m_accuracy_user_data(NULL) +, m_passive(false) { } @@ -161,7 +162,17 @@ unsigned int sensor_handle_info::get_reg_event_count(void) return m_reg_event_infos.size(); } +bool sensor_handle_info::get_passive_mode(void) +{ + return m_passive; +} + +void sensor_handle_info::set_passive_mode(bool passive) +{ + m_passive = passive; +} + bool sensor_handle_info::is_started(void) { - return (m_sensor_state == SENSOR_STATE_STARTED); + return (m_sensor_state == SENSOR_STATE_STARTED) || m_passive; } diff --git a/src/client/sensor_handle_info.h b/src/client/sensor_handle_info.h index 28e5a01..c74c3a5 100644 --- a/src/client/sensor_handle_info.h +++ b/src/client/sensor_handle_info.h @@ -30,15 +30,6 @@ typedef std::unordered_map event_info_map; class sensor_handle_info { public: - int m_handle; - sensor_id_t m_sensor_id; - int m_sensor_state; - int m_pause_policy; - int m_bad_accuracy; - int m_accuracy; - sensor_accuracy_changed_cb_t m_accuracy_cb; - void *m_accuracy_user_data; - sensor_handle_info(); ~sensor_handle_info(); @@ -55,8 +46,20 @@ public: void clear_all_events(void); static unsigned long long renew_event_id(void); + bool get_passive_mode(void); + void set_passive_mode(bool passive); bool is_started(void); + int m_handle; + sensor_id_t m_sensor_id; + int m_sensor_state; + int m_pause_policy; + int m_bad_accuracy; + int m_accuracy; + sensor_accuracy_changed_cb_t m_accuracy_cb; + void *m_accuracy_user_data; + bool m_passive; + private: event_info_map m_reg_event_infos; static unsigned long long m_event_id; diff --git a/src/client/sensor_internal.h b/src/client/sensor_internal.h index c4c3fce..3cc6641 100644 --- a/src/client/sensor_internal.h +++ b/src/client/sensor_internal.h @@ -386,6 +386,7 @@ int sensord_external_connect(const char *key, sensor_external_command_cb_t cb, v bool sensord_external_disconnect(int handle); bool sensord_external_post(int handle, unsigned long long timestamp, const float* data, int data_cnt); +bool sensord_set_passive_mode(int handle, bool passive); /** * @} */ -- 2.7.4 From da9123180996923a1449f47d5a4965ca4780ffc2 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Wed, 8 Jun 2016 20:18:58 +0900 Subject: [PATCH 04/16] sensord: restore attributes after sensor daemon is restarted sensor attributes also has to restored when daemon is restarted, like listener, interval, batch latency. Change-Id: Id9bfb37fc9ab9b71caca08639f2106710a65741f Signed-off-by: kibak.yoon --- src/client/client.cpp | 42 +++++++++++++++++++++++++++++++++++++++ src/client/sensor_client_info.cpp | 32 +++++++++++++++++++++++++++++ src/client/sensor_client_info.h | 24 +++++++--------------- src/client/sensor_handle_info.h | 6 ++++++ 4 files changed, 87 insertions(+), 17 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index 769aa9d..e26ba85 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -172,6 +172,40 @@ static void power_save_state_cb(keynode_t *node, void *data) } } +bool restore_attributes(int client_id, sensor_id_t sensor, command_channel *cmd_channel) +{ + sensor_handle_info_map handle_infos; + + sensor_client_info::get_instance().get_sensor_handle_info(sensor, handle_infos); + + for (auto it_handles = handle_infos.begin(); it_handles != handle_infos.end(); ++it_handles) { + sensor_handle_info info = it_handles->second; + + for (auto it = info.attributes_int.begin(); it != info.attributes_int.end(); ++it) { + int attribute = it->first; + int value = it->second; + if (!cmd_channel->cmd_set_attribute_int(attribute, value)) { + _E("Failed to send cmd_set_attribute_int(%d, %d) for %s", + client_id, value, get_client_name()); + return false; + } + } + + for (auto it = info.attributes_str.begin(); it != info.attributes_str.end(); ++it) { + int attribute = it->first; + const char *value = it->second.c_str(); + int value_len = it->second.size(); + if (!cmd_channel->cmd_set_attribute_str(attribute, value, value_len)) { + _E("Failed to send cmd_set_attribute_str(%d, %d, %s) for %s", + client_id, value_len, value, get_client_name()); + return false; + } + } + } + + return true; +} + void restore_session(void) { AUTOLOCK(lock); @@ -233,6 +267,10 @@ void restore_session(void) goto FAILED; } + if (!restore_attributes(client_id, *it_sensor, cmd_channel)) { + _E("Failed to restore attributes(%s) for %s", get_sensor_name(*it_sensor), get_client_name()); + goto FAILED; + } ++it_sensor; } @@ -1074,6 +1112,8 @@ static int change_attribute_int(int handle, int attribute, int value) return -EPERM; } + sensor_client_info::get_instance().set_attribute(handle, attribute, value); + return OP_SUCCESS; } @@ -1130,6 +1170,8 @@ API int sensord_set_attribute_str(int handle, int attribute, const char *value, return -EPERM; } + sensor_client_info::get_instance().set_attribute(handle, attribute, value); + return OP_SUCCESS; } diff --git a/src/client/sensor_client_info.cpp b/src/client/sensor_client_info.cpp index 08b5a9d..54a6d7e 100644 --- a/src/client/sensor_client_info.cpp +++ b/src/client/sensor_client_info.cpp @@ -666,6 +666,38 @@ void sensor_client_info::set_pause_policy(sensor_id_t sensor, int pause_policy) } } +bool sensor_client_info::set_attribute(int handle, int attribute, int value) +{ + AUTOLOCK(m_handle_info_lock); + + auto it_handle = m_sensor_handle_infos.find(handle); + + if (it_handle == m_sensor_handle_infos.end()) { + _E("Handle[%d] is not found for client %s", handle, get_client_name()); + return false; + } + + it_handle->second.attributes_int[attribute] = value; + + return true; +} + +bool sensor_client_info::set_attribute(int handle, int attribute, std::string value) +{ + AUTOLOCK(m_handle_info_lock); + + auto it_handle = m_sensor_handle_infos.find(handle); + + if (it_handle == m_sensor_handle_infos.end()) { + _E("Handle[%d] is not found for client %s", handle, get_client_name()); + return false; + } + + it_handle->second.attributes_str[attribute] = value; + + return true; +} + void sensor_client_info::clear(void) { close_command_channel(); diff --git a/src/client/sensor_client_info.h b/src/client/sensor_client_info.h index 7c46323..ab3a384 100644 --- a/src/client/sensor_client_info.h +++ b/src/client/sensor_client_info.h @@ -29,27 +29,14 @@ #include #include #include -#include -#include -#include -#include #include #include #include -using std::unordered_map; -using std::vector; -using std::string; -using std::queue; -using std::mutex; -using std::lock_guard; -using std::unique_lock; -using std::condition_variable; - -typedef vector handle_vector; -typedef vector sensor_id_vector; -typedef unordered_map sensor_handle_info_map; -typedef unordered_map sensor_command_channel_map; +typedef std::vector handle_vector; +typedef std::vector sensor_id_vector; +typedef std::unordered_map sensor_handle_info_map; +typedef std::unordered_map sensor_command_channel_map; typedef struct sensor_rep { bool active; @@ -78,6 +65,9 @@ public: bool get_passive_mode(int handle); bool set_passive_mode(int handle, bool passive); + bool set_attribute(int handle, int attribute, int value); + bool set_attribute(int handle, int attribute, std::string value); + bool set_sensor_pause_policy(int handle, int pause_policy); bool set_event_batch(int handle, unsigned int event_type, unsigned int interval, unsigned int latency); bool set_accuracy(int handle, int accuracy); diff --git a/src/client/sensor_handle_info.h b/src/client/sensor_handle_info.h index c74c3a5..b62f646 100644 --- a/src/client/sensor_handle_info.h +++ b/src/client/sensor_handle_info.h @@ -25,8 +25,12 @@ #include #include #include +#include +#include typedef std::unordered_map event_info_map; +typedef std::map sensor_attribute_int_map; +typedef std::map sensor_attribute_str_map; class sensor_handle_info { public: @@ -59,6 +63,8 @@ public: sensor_accuracy_changed_cb_t m_accuracy_cb; void *m_accuracy_user_data; bool m_passive; + sensor_attribute_int_map attributes_int; + sensor_attribute_str_map attributes_str; private: event_info_map m_reg_event_infos; -- 2.7.4 From 8fe04eb190fda9eb38b93150f9140837d865915c Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Tue, 7 Jun 2016 14:02:41 +0900 Subject: [PATCH 05/16] sensord: set to UINT_MAX batch count when there is no batch latency for sensor - if there is no client which uses batch latency, batch count should be set the default value, not 0 but max batch count. if sensord sets the UINT_MAX as a default value, HAL will set the proper value comparing between this sensor's max batch count and UINT_MAX. Change-Id: I3aff8d24c00ca6b232d33c803b1783cb60325abb Signed-off-by: kibak.yoon --- src/server/sensor_base.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/sensor_base.cpp b/src/server/sensor_base.cpp index 5ff2566..a5a40bb 100644 --- a/src/server/sensor_base.cpp +++ b/src/server/sensor_base.cpp @@ -18,6 +18,7 @@ */ #include +#include #include #include #include @@ -264,10 +265,10 @@ bool sensor_base::delete_batch(int client_id) cur_max = m_sensor_info_list.get_max_batch(); if (!cur_max) { - _I("No latency for sensor[%#llx] by client[%d] deleting latency, so set to default 0 ms", + _I("No latency for sensor[%#llx] by client[%d] deleting latency, so set to default count", get_id(), client_id); - set_batch_latency(0); + set_batch_latency(UINT_MAX); } else if (cur_max != prev_max) { _I("Max latency for sensor[%#llx] is changed from %dms to %dms by client[%d] deleting latency", get_id(), prev_max, cur_max, client_id); -- 2.7.4 From 7df328c69c213aa972f0277fd9390ee332b88be6 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Mon, 20 Jun 2016 12:46:07 +0900 Subject: [PATCH 06/16] sensord: change sensor axis policy by using attribute setting via C-API - SENSORD_AXIS_DEVICE_ORIENTED - SENSORD_AXIS_DISPLAY_ORIENTED Change-Id: Iab201d26c1d957d58ee48a00d4aa1403aa034f9e Signed-off-by: kibak.yoon --- src/client/client.cpp | 1 + src/client/sensor_event_listener.cpp | 14 ++++++++++++-- src/client/sensor_event_listener.h | 4 ++++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index e26ba85..b900db4 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -1080,6 +1080,7 @@ static int change_pause_policy(int handle, int pause) static int change_axis_orientation(int handle, int axis_orientation) { + sensor_event_listener::get_instance().set_sensor_axis(axis_orientation); return OP_SUCCESS; } diff --git a/src/client/sensor_event_listener.cpp b/src/client/sensor_event_listener.cpp index 80c280b..fdc622a 100644 --- a/src/client/sensor_event_listener.cpp +++ b/src/client/sensor_event_listener.cpp @@ -45,6 +45,7 @@ sensor_event_listener::sensor_event_listener() , m_thread_state(THREAD_STATE_TERMINATE) , m_hup_observer(NULL) , m_client_info(sensor_client_info::get_instance()) +, m_axis(SENSORD_AXIS_DEVICE_ORIENTED) , m_display_rotation(AUTO_ROTATION_DEGREE_UNKNOWN) { } @@ -204,11 +205,19 @@ bool sensor_event_listener::is_valid_callback(client_callback_info *cb_info) return m_client_info.is_event_active(cb_info->handle, cb_info->event_type, cb_info->event_id); } +void sensor_event_listener::set_sensor_axis(int axis) +{ + m_axis = axis; +} + void sensor_event_listener::align_sensor_axis(sensor_t sensor, sensor_data_t *data) { sensor_type_t type = sensor_to_sensor_info(sensor)->get_type(); - if (type != ACCELEROMETER_SENSOR && type != GYROSCOPE_SENSOR && type != GRAVITY_SENSOR) + if (m_axis != SENSORD_AXIS_DISPLAY_ORIENTED) + return; + + if (type != ACCELEROMETER_SENSOR && type != GYROSCOPE_SENSOR && type != GRAVITY_SENSOR && type != LINEAR_ACCEL_SENSOR) return; float x, y; @@ -250,7 +259,8 @@ gboolean sensor_event_listener::callback_dispatcher(gpointer data) if (cb_info->accuracy_cb) cb_info->accuracy_cb(cb_info->sensor, cb_info->timestamp, cb_info->accuracy, cb_info->accuracy_user_data); - ((sensor_cb_t) cb_info->cb)(cb_info->sensor, cb_info->event_type, (sensor_data_t *) cb_info->sensor_data.get(), cb_info->user_data); + sensor_event_listener::get_instance().align_sensor_axis(cb_info->sensor, (sensor_data_t *)cb_info->sensor_data.get()); + ((sensor_cb_t) cb_info->cb)(cb_info->sensor, cb_info->event_type, (sensor_data_t *)cb_info->sensor_data.get(), cb_info->user_data); delete cb_info; diff --git a/src/client/sensor_event_listener.h b/src/client/sensor_event_listener.h index 417d0ad..9631a63 100644 --- a/src/client/sensor_event_listener.h +++ b/src/client/sensor_event_listener.h @@ -74,6 +74,8 @@ public: void clear(void); void set_hup_observer(hup_observer_t observer); + + void set_sensor_axis(int axis); void set_display_rotation(int rt); private: @@ -97,6 +99,8 @@ private: sensor_client_info &m_client_info; /* WC1's rotation control */ + /* SENSORD_AXIS_DEVICE_ORIENTED, SENSORD_AXIS_DISPLAY_ORIENTED */ + int m_axis; int m_display_rotation; sensor_event_listener(); -- 2.7.4 From bcc7f159bdef472d1310bc55ce3b829b94456678 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 2 Jun 2016 17:48:10 +0900 Subject: [PATCH 07/16] sensord: add new internal sensor types Change-Id: I9c7bb390184877f41d379fa1bb0115dd7edecc3b Signed-off-by: kibak.yoon --- src/hal/sensor_hal_types.h | 59 +++++++++++++++++++++++++---------------- src/shared/sensor_types.h | 66 ++++++++++++++++++++++++++++++++-------------- 2 files changed, 82 insertions(+), 43 deletions(-) diff --git a/src/hal/sensor_hal_types.h b/src/hal/sensor_hal_types.h index 91630c4..9b7ccde 100644 --- a/src/hal/sensor_hal_types.h +++ b/src/hal/sensor_hal_types.h @@ -71,12 +71,47 @@ typedef enum { SENSOR_DEVICE_HUMAN_PEDOMETER = 0x300, SENSOR_DEVICE_HUMAN_SLEEP_MONITOR, + SENSOR_DEVICE_HUMAN_SLEEP_DETECTOR, + SENSOR_DEVICE_HUMAN_STRESS_MONITOR, + + SENSOR_DEVICE_EXERCISE_WALKING = 0x400, + SENSOR_DEVICE_EXERCISE_RUNNING, + SENSOR_DEVICE_EXERCISE_HIKING, + SENSOR_DEVICE_EXERCISE_CYCLING, + SENSOR_DEVICE_EXERCISE_STAIR_CLIMBING, + SENSOR_DEVICE_EXERCISE_ELLIPTICAL, + SENSOR_DEVICE_EXERCISE_INDOOR_CYCLING, + SENSOR_DEVICE_EXERCISE_ROWING, + SENSOR_DEVICE_EXERCISE_STEPPER, SENSOR_DEVICE_FUSION = 0x900, SENSOR_DEVICE_AUTO_ROTATION, SENSOR_DEVICE_AUTO_BRIGHTNESS, - SENSOR_DEVICE_CONTEXT = 0x1000, + SENSOR_DEVICE_GESTURE_MOVEMENT = 0x1200, + SENSOR_DEVICE_GESTURE_WRIST_UP, + SENSOR_DEVICE_GESTURE_WRIST_DOWN, + SENSOR_DEVICE_GESTURE_MOVEMENT_STATE, + + SENSOR_DEVICE_GPS_BATCH = 0x1A00, + SENSOR_DEVICE_ACTIVITY_TRACKER, + + SENSOR_DEVICE_HRM_CTRL = 0x1A80, + SENSOR_DEVICE_EXERCISE_COACH, + SENSOR_DEVICE_ACTIVITY_LEVEL_MONITOR, + + SENSOR_DEVICE_WEAR_STATUS = 0x2000, + SENSOR_DEVICE_WEAR_ON_MONITOR, + SENSOR_DEVICE_NO_MOVE_DETECTOR, + SENSOR_DEVICE_RESTING_HR, + SENSOR_DEVICE_STEP_LEVEL_MONITOR, + SENSOR_DEVICE_EXERCISE, + SENSOR_DEVICE_EXERCISE_HR, + SENSOR_DEVICE_WORKOUT, + SENSOR_DEVICE_CYCLE_MONITOR, + SENSOR_DEVICE_STAIR_TRACKER, + + SENSOR_DEVICE_CONTEXT = 0x7000, SENSOR_DEVICE_MOTION, SENSOR_DEVICE_PIR, SENSOR_DEVICE_PIR_LONG, @@ -87,32 +122,10 @@ typedef enum { SENSOR_DEVICE_HRM_RAW, SENSOR_DEVICE_TILT, SENSOR_DEVICE_ROTATION_VECTOR_RAW, - SENSOR_DEVICE_EXERCISE, SENSOR_DEVICE_GSR, SENSOR_DEVICE_SIMSENSE, SENSOR_DEVICE_PPG, - SENSOR_DEVICE_GESTURE_MOVEMENT = 0x1200, - SENSOR_DEVICE_GESTURE_WRIST_UP, - SENSOR_DEVICE_GESTURE_WRIST_DOWN, - SENSOR_DEVICE_GESTURE_MOVEMENT_STATE, - - SENSOR_DEVICE_WEAR_STATUS = 0x1A00, - SENSOR_DEVICE_WEAR_ON_MONITOR, - SENSOR_DEVICE_GPS_BATCH, - SENSOR_DEVICE_ACTIVITY_TRACKER, - SENSOR_DEVICE_SLEEP_DETECTOR, - SENSOR_DEVICE_NO_MOVE_DETECTOR = 0x1A80, - SENSOR_DEVICE_HRM_CTRL, - SENSOR_DEVICE_EXERCISE_COACH, - SENSOR_DEVICE_EXERCISE_HR, - SENSOR_DEVICE_RESTING_HR, - SENSOR_DEVICE_STEP_LEVEL_MONITOR, - SENSOR_DEVICE_ACTIVITY_LEVEL_MONITOR, - SENSOR_DEVICE_CYCLE_MONITOR, - SENSOR_DEVICE_STRESS_MONITOR, - SENSOR_DEVICE_AUTOSESSION_EXERCISE, - SENSOR_DEVICE_STAIR_TRACKER, } sensor_device_type; /* diff --git a/src/shared/sensor_types.h b/src/shared/sensor_types.h index cb8e65e..5c890b9 100644 --- a/src/shared/sensor_types.h +++ b/src/shared/sensor_types.h @@ -54,12 +54,47 @@ extern "C" \ DEF_SENSOR_VALUE(HUMAN_PEDOMETER_SENSOR, 0x300) \ DEF_SENSOR(HUMAN_SLEEP_MONITOR_SENSOR) \ + DEF_SENSOR(HUMAN_SLEEP_DETECTOR_SENSOR) \ + DEF_SENSOR(HUMAN_STRESS_MONITOR_SENSOR) \ + \ + DEF_SENSOR_VALUE(EXERCISE_WALKING_SENSOR, 0x400) \ + DEF_SENSOR(EXERCISE_RUNNING_SENSOR) \ + DEF_SENSOR(EXERCISE_HIKING_SENSOR) \ + DEF_SENSOR(EXERCISE_CYCLING_SENSOR) \ + DEF_SENSOR(EXERCISE_STAIR_CLIMBING_SENSOR) \ + DEF_SENSOR(EXERCISE_ELLIPTICAL_SENSOR) \ + DEF_SENSOR(EXERCISE_INDOOR_CYCLING_SENSOR) \ + DEF_SENSOR(EXERCISE_ROWING_SENSOR) \ + DEF_SENSOR(EXERCISE_STEPPER_SENSOR) \ \ DEF_SENSOR_VALUE(FUSION_SENSOR, 0x900) \ DEF_SENSOR(AUTO_ROTATION_SENSOR) \ DEF_SENSOR(AUTO_BRIGHTNESS_SENSOR) \ \ - DEF_SENSOR_VALUE(CONTEXT_SENSOR, 0x1000) \ + DEF_SENSOR_VALUE(GESTURE_MOVEMENT_SENSOR, 0x1200) \ + DEF_SENSOR(GESTURE_WRIST_UP_SENSOR) \ + DEF_SENSOR(GESTURE_WRIST_DOWN_SENSOR) \ + DEF_SENSOR(GESTURE_MOVEMENT_STATE_SENSOR) \ + \ + DEF_SENSOR_VALUE(GPS_BATCH_SENSOR, 0x1A00) \ + DEF_SENSOR(ACTIVITY_TRACKER_SENSOR) \ + \ + DEF_SENSOR_VALUE(HRM_CTRL_SENSOR, 0x1A80) \ + DEF_SENSOR(EXERCISE_COACH_SENSOR) \ + DEF_SENSOR(ACTIVITY_LEVEL_MONITOR_SENSOR) \ + \ + DEF_SENSOR_VALUE(WEAR_STATUS_SENSOR, 0x2000) \ + DEF_SENSOR(WEAR_ON_MONITOR_SENSOR) \ + DEF_SENSOR(NO_MOVE_DETECTOR_SENSOR) \ + DEF_SENSOR(RESTING_HR_SENSOR) \ + DEF_SENSOR(STEP_LEVEL_MONITOR_SENSOR) \ + DEF_SENSOR(EXERCISE_SENSOR) \ + DEF_SENSOR(EXERCISE_HR_SENSOR) \ + DEF_SENSOR(WORKOUT_SENSOR) \ + DEF_SENSOR(CYCLE_MONITOR_SENSOR) \ + DEF_SENSOR(STAIR_TRACKER_SENSOR) \ + \ + DEF_SENSOR_VALUE(CONTEXT_SENSOR, 0x7000) \ DEF_SENSOR(MOTION_SENSOR) \ DEF_SENSOR(PIR_SENSOR) \ DEF_SENSOR(PIR_LONG_SENSOR) \ @@ -70,30 +105,21 @@ extern "C" DEF_SENSOR(HRM_RAW_SENSOR) \ DEF_SENSOR(TILT_SENSOR) \ DEF_SENSOR(RV_RAW_SENSOR) \ - DEF_SENSOR(EXERCISE_SENSOR) \ - \ - DEF_SENSOR_VALUE(GESTURE_MOVEMENT_SENSOR, 0x1200) \ - DEF_SENSOR(GESTURE_WRIST_UP_SENSOR) \ - DEF_SENSOR(GESTURE_WRIST_DOWN_SENSOR) \ - DEF_SENSOR(GESTURE_MOVEMENT_STATE_SENSOR) \ - \ - DEF_SENSOR_VALUE(WEAR_STATUS_SENSOR, 0x1A00) \ - DEF_SENSOR(WEAR_ON_MONITOR_SENSOR) \ - DEF_SENSOR(GPS_BATCH_SENSOR) \ - DEF_SENSOR(ACTIVITY_TRACKER_SENSOR) \ - DEF_SENSOR(SLEEP_DETECTOR_SENSOR) \ -#define BIO_HRM_SENSOR HRM_SENSOR -#define BIO_LED_GREEN_SENSOR HRM_LED_GREEN_SENSOR -#define BIO_LED_IR_SENSOR HRM_LED_IR_SENSOR -#define BIO_LED_RED_SENSOR HRM_LED_RED_SENSOR -#define BIO_SENSOR HRM_RAW_SENSOR +#define BIO_HRM_SENSOR HRM_SENSOR +#define BIO_LED_GREEN_SENSOR HRM_LED_GREEN_SENSOR +#define BIO_LED_IR_SENSOR HRM_LED_IR_SENSOR +#define BIO_LED_RED_SENSOR HRM_LED_RED_SENSOR +#define BIO_SENSOR HRM_RAW_SENSOR +#define SLEEP_DETECTOR_SENSOR HUMAN_SLEEP_DETECTOR_SENSOR +#define STRESS_MONITOR_SENSOR HUMAN_STRESS_MONITOR_SENSOR +#define AUTOSESSION_EXERCISE_SENSOR WORKOUT_SENSOR DECLARE_SENSOR_ENUM(sensor_type_t, SENSOR_TYPE) enum proxi_change_state { - PROXIMITY_STATE_NEAR = 0, - PROXIMITY_STATE_FAR = 1, + PROXIMITY_STATE_NEAR = 0, + PROXIMITY_STATE_FAR = 1, }; enum auto_rotation_state { -- 2.7.4 From 7562c18dbaad2cd013843373635055456120b487 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Tue, 21 Jun 2016 12:45:25 +0900 Subject: [PATCH 08/16] sensord: rename and reorder sensor types - EXERCISE_COACH -> EXERCISE_STANDALONE - EXERCISE -> EXERCISE_COMPANION - EXERCISE_STAIR_CLIMBING -> X Change-Id: I43290e81ad9175bc2c63b46db7d6c98dcea62046 Signed-off-by: kibak.yoon --- src/hal/sensor_hal_types.h | 8 ++++---- src/shared/sensor_types.h | 7 ++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/hal/sensor_hal_types.h b/src/hal/sensor_hal_types.h index 9b7ccde..ffa96f1 100644 --- a/src/hal/sensor_hal_types.h +++ b/src/hal/sensor_hal_types.h @@ -78,7 +78,6 @@ typedef enum { SENSOR_DEVICE_EXERCISE_RUNNING, SENSOR_DEVICE_EXERCISE_HIKING, SENSOR_DEVICE_EXERCISE_CYCLING, - SENSOR_DEVICE_EXERCISE_STAIR_CLIMBING, SENSOR_DEVICE_EXERCISE_ELLIPTICAL, SENSOR_DEVICE_EXERCISE_INDOOR_CYCLING, SENSOR_DEVICE_EXERCISE_ROWING, @@ -97,7 +96,6 @@ typedef enum { SENSOR_DEVICE_ACTIVITY_TRACKER, SENSOR_DEVICE_HRM_CTRL = 0x1A80, - SENSOR_DEVICE_EXERCISE_COACH, SENSOR_DEVICE_ACTIVITY_LEVEL_MONITOR, SENSOR_DEVICE_WEAR_STATUS = 0x2000, @@ -105,7 +103,7 @@ typedef enum { SENSOR_DEVICE_NO_MOVE_DETECTOR, SENSOR_DEVICE_RESTING_HR, SENSOR_DEVICE_STEP_LEVEL_MONITOR, - SENSOR_DEVICE_EXERCISE, + SENSOR_DEVICE_EXERCISE_STANDALONE, SENSOR_DEVICE_EXERCISE_HR, SENSOR_DEVICE_WORKOUT, SENSOR_DEVICE_CYCLE_MONITOR, @@ -219,8 +217,10 @@ typedef struct { } diffs[SENSOR_PEDOMETER_DATA_DIFFS_SIZE]; } sensor_pedometer_data_t; +#define CONVERT_TYPE_ATTR(type, index) ((type) << 8 | 0x80 | (index)) + enum sensor_attribute { - SENSOR_ATTR_ACTIVITY = 0x100, + SENSOR_ATTR_ACTIVITY = CONVERT_TYPE_ATTR(SENSOR_DEVICE_ACTIVITY_TRACKER, 0x1), }; enum sensor_activity { diff --git a/src/shared/sensor_types.h b/src/shared/sensor_types.h index 5c890b9..0612f72 100644 --- a/src/shared/sensor_types.h +++ b/src/shared/sensor_types.h @@ -61,7 +61,6 @@ extern "C" DEF_SENSOR(EXERCISE_RUNNING_SENSOR) \ DEF_SENSOR(EXERCISE_HIKING_SENSOR) \ DEF_SENSOR(EXERCISE_CYCLING_SENSOR) \ - DEF_SENSOR(EXERCISE_STAIR_CLIMBING_SENSOR) \ DEF_SENSOR(EXERCISE_ELLIPTICAL_SENSOR) \ DEF_SENSOR(EXERCISE_INDOOR_CYCLING_SENSOR) \ DEF_SENSOR(EXERCISE_ROWING_SENSOR) \ @@ -78,9 +77,9 @@ extern "C" \ DEF_SENSOR_VALUE(GPS_BATCH_SENSOR, 0x1A00) \ DEF_SENSOR(ACTIVITY_TRACKER_SENSOR) \ + DEF_SENSOR(EXERCISE_COMPANION_SENSOR) \ \ DEF_SENSOR_VALUE(HRM_CTRL_SENSOR, 0x1A80) \ - DEF_SENSOR(EXERCISE_COACH_SENSOR) \ DEF_SENSOR(ACTIVITY_LEVEL_MONITOR_SENSOR) \ \ DEF_SENSOR_VALUE(WEAR_STATUS_SENSOR, 0x2000) \ @@ -88,7 +87,7 @@ extern "C" DEF_SENSOR(NO_MOVE_DETECTOR_SENSOR) \ DEF_SENSOR(RESTING_HR_SENSOR) \ DEF_SENSOR(STEP_LEVEL_MONITOR_SENSOR) \ - DEF_SENSOR(EXERCISE_SENSOR) \ + DEF_SENSOR(EXERCISE_STANDALONE_SENSOR) \ DEF_SENSOR(EXERCISE_HR_SENSOR) \ DEF_SENSOR(WORKOUT_SENSOR) \ DEF_SENSOR(CYCLE_MONITOR_SENSOR) \ @@ -114,6 +113,8 @@ extern "C" #define SLEEP_DETECTOR_SENSOR HUMAN_SLEEP_DETECTOR_SENSOR #define STRESS_MONITOR_SENSOR HUMAN_STRESS_MONITOR_SENSOR #define AUTOSESSION_EXERCISE_SENSOR WORKOUT_SENSOR +#define EXERCISE_COACH_SENSOR EXERCISE_STANDALONE_SENSOR +#define EXERCISE_SENSOR EXERCISE_COMPANION_SENSOR DECLARE_SENSOR_ENUM(sensor_type_t, SENSOR_TYPE) -- 2.7.4 From fda09ec118138917b72afad8ab21f12988ce33e9 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Wed, 22 Jun 2016 19:07:50 +0900 Subject: [PATCH 09/16] sensord: fix the bug which converts wrong pause policy Change-Id: I655ccde45a65637672fb9c23141e66b32d34c2c7 Signed-off-by: kibak.yoon --- src/client/client.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index b900db4..129958c 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -44,9 +44,7 @@ using std::vector; #define DEFAULT_INTERVAL POLL_10HZ_MS -#define CONVERT_OPTION_PAUSE_POLICY(option) \ - (option == SENSOR_OPTION_DEFAULT || option == SENSOR_OPTION_ALWAYS_ON) ? \ - (option ^ 0b11) : option +#define CONVERT_OPTION_PAUSE_POLICY(option) ((option) ^ 0b11) static cmutex lock; -- 2.7.4 From a0b71120db332e7ae23da7ebb3dd1f2c8db2fa91 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Mon, 27 Jun 2016 13:27:25 +0900 Subject: [PATCH 10/16] sensord: clean up switch-case statement if attribute is not global. - if it is a default attribute in switch-case statement, break and call set_attribute_int() function. Change-Id: I1bf0403ad268a8465190439acd9c1ebe320cda2c Signed-off-by: kibak.yoon --- src/client/client.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/client.cpp b/src/client/client.cpp index 129958c..171cb88 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -1129,10 +1129,10 @@ API int sensord_set_attribute_int(int handle, int attribute, int value) case SENSORD_ATTRIBUTE_AXIS_ORIENTATION: return change_axis_orientation(handle, value); default: - return change_attribute_int(handle, attribute, value); + break; } - return OP_SUCCESS; + return change_attribute_int(handle, attribute, value); } API int sensord_set_attribute_str(int handle, int attribute, const char *value, int value_len) -- 2.7.4 From 0bd9a6b6dba2efc5a269279a0eefacd892b885fd Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Wed, 29 Jun 2016 11:51:58 +0900 Subject: [PATCH 11/16] sensord: remove unused sensor_config sources - device_config - virtual_sensor_config Change-Id: I91eb3abf9c062c6dd0576b846440fc199b6be89f Signed-off-by: kibak.yoon --- packaging/sensord.spec | 1 - src/sensor/virtual_sensors.xml | 271 ------------------------------ src/server/CMakeLists.txt | 2 +- src/server/device_config.cpp | 72 -------- src/server/device_config.h | 40 ----- src/server/virtual_sensor_config.cpp | 315 ----------------------------------- src/server/virtual_sensor_config.h | 83 --------- 7 files changed, 1 insertion(+), 783 deletions(-) delete mode 100644 src/sensor/virtual_sensors.xml delete mode 100644 src/server/device_config.cpp delete mode 100644 src/server/device_config.h delete mode 100644 src/server/virtual_sensor_config.cpp delete mode 100644 src/server/virtual_sensor_config.h diff --git a/packaging/sensord.spec b/packaging/sensord.spec index e743bc9..9111df8 100644 --- a/packaging/sensord.spec +++ b/packaging/sensord.spec @@ -12,7 +12,6 @@ Source3: sensord_event.socket BuildRequires: cmake BuildRequires: libattr-devel BuildRequires: pkgconfig(dlog) -BuildRequires: pkgconfig(libxml-2.0) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(vconf) BuildRequires: pkgconfig(libsystemd-daemon) diff --git a/src/sensor/virtual_sensors.xml b/src/sensor/virtual_sensors.xml deleted file mode 100644 index c0c08f5..0000000 --- a/src/sensor/virtual_sensors.xml +++ /dev/null @@ -1,271 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/server/CMakeLists.txt b/src/server/CMakeLists.txt index 50ac418..763e904 100644 --- a/src/server/CMakeLists.txt +++ b/src/server/CMakeLists.txt @@ -1,7 +1,7 @@ CMAKE_MINIMUM_REQUIRED(VERSION 2.6) PROJECT(sensord CXX) -SET(DEPENDENTS "glib-2.0 gio-2.0 dlog libsystemd-daemon libxml-2.0 cynara-client cynara-creds-socket cynara-session") +SET(DEPENDENTS "glib-2.0 gio-2.0 dlog libsystemd-daemon cynara-client cynara-creds-socket cynara-session") INCLUDE(FindPkgConfig) PKG_CHECK_MODULES(SERVER_PKGS REQUIRED ${DEPENDENTS}) diff --git a/src/server/device_config.cpp b/src/server/device_config.cpp deleted file mode 100644 index 082b6d6..0000000 --- a/src/server/device_config.cpp +++ /dev/null @@ -1,72 +0,0 @@ -/* - * sensord - * - * Copyright (c) 2014 Samsung Electronics Co., Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * - */ - -#include -#include -#include - -using std::ifstream; -using std::string; -using std::istringstream; - -device_config::device_config(void) -{ -} - -device_config::~device_config(void) -{ -} - -bool device_config::get_device_id(void) -{ - const string INFO_INI_PATH = "/etc/info.ini"; - const string START_DELIMETER = "Model="; - const string END_DELIMETER = ";"; - string line; - ifstream in_file; - std::size_t start_pos, end_pos; - bool ret = false; - - in_file.open(INFO_INI_PATH); - - if (!in_file.is_open()) - return false; - - while (!in_file.eof()) { - getline(in_file, line); - start_pos = line.find(START_DELIMETER); - - if (start_pos == std::string::npos) - continue; - - start_pos = start_pos + START_DELIMETER.size(); - end_pos = line.find(END_DELIMETER, start_pos); - - if (end_pos == std::string::npos) - continue; - - m_device_id = line.substr(start_pos, end_pos - start_pos); - ret = true; - break; - } - - in_file.close(); - - return ret; -} diff --git a/src/server/device_config.h b/src/server/device_config.h deleted file mode 100644 index 5c73509..0000000 --- a/src/server/device_config.h +++ /dev/null @@ -1,40 +0,0 @@ -/* - * sensord - * - * Copyright (c) 2016 Samsung Electronics Co., Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * - */ - -#ifndef _DEVICE_CONFIG_H_ -#define _DEVICE_CONFIG_H_ - -#include -#include -#include - -class device_config { -public: - device_config(); - virtual ~device_config(); - - bool get_device_id(void); - -protected: - virtual bool load_config(const std::string& config_path) = 0; - - std::string m_device_id; -}; - -#endif /* _DEVICE_CONFIG_H_ */ diff --git a/src/server/virtual_sensor_config.cpp b/src/server/virtual_sensor_config.cpp deleted file mode 100644 index fc57bd8..0000000 --- a/src/server/virtual_sensor_config.cpp +++ /dev/null @@ -1,315 +0,0 @@ -/* - * sensord - * - * Copyright (c) 2014 Samsung Electronics Co., Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * - */ - -#include -#include "sensor_log.h" -#include -#include -#include -#include -#include - -using std::string; -using std::stringstream; - -#define ROOT_ELEMENT "VIRTUAL_SENSOR" -#define DEVICE_TYPE_ATTR "type" -#define TEXT_ELEMENT "text" -#define DEFAULT_ATTR "value" -#define DEFAULT_ATTR1 "value1" -#define DEFAULT_ATTR2 "value2" -#define DEFAULT_ATTR3 "value3" -#define DEFAULT_DEVICE "Default" - -virtual_sensor_config::virtual_sensor_config() -{ -} - -virtual_sensor_config& virtual_sensor_config::get_instance(void) -{ - static bool load_done = false; - static virtual_sensor_config inst; - - if (!load_done) { - inst.load_config(VIRTUAL_SENSOR_CONFIG_FILE_PATH); - inst.get_device_id(); - if (!inst.m_device_id.empty()) - _I("Device ID = %s", inst.m_device_id.c_str()); - else - _E("Failed to get Device ID"); - load_done = true; - } - - return inst; -} - -bool virtual_sensor_config::load_config(const string& config_path) -{ - xmlDocPtr doc; - xmlNodePtr cur; - - _D("virtual_sensor_config::load_config(\"%s\") is called!\n", config_path.c_str()); - - doc = xmlParseFile(config_path.c_str()); - - if (doc == NULL) { - _E("There is no %s\n", config_path.c_str()); - return false; - } - - cur = xmlDocGetRootElement(doc); - if (cur == NULL) { - _E("There is no root element in %s\n", config_path.c_str()); - xmlFreeDoc(doc); - return false; - } - - if (xmlStrcmp(cur->name, (const xmlChar *)ROOT_ELEMENT)) { - _E("Wrong type document: there is no [%s] root element in %s\n", ROOT_ELEMENT, config_path.c_str()); - xmlFreeDoc(doc); - return false; - } - - xmlNodePtr device_node_ptr; - xmlNodePtr virtual_sensor_node_ptr; - xmlNodePtr element_node_ptr; - xmlAttrPtr attr_ptr; - char* prop = NULL; - - device_node_ptr = cur->xmlChildrenNode; - while (device_node_ptr != NULL){ - //skip garbage element, [text] - if (!xmlStrcmp(device_node_ptr->name, (const xmlChar *)TEXT_ELEMENT)) { - device_node_ptr = device_node_ptr->next; - continue; - } - - string device_type; - prop = (char*)xmlGetProp(device_node_ptr, (const xmlChar*)DEVICE_TYPE_ATTR); - device_type = prop; - free(prop); - - //insert device to device_list - m_virtual_sensor_configs[device_type]; - _D("\n", device_type.c_str()); - - virtual_sensor_node_ptr = device_node_ptr->xmlChildrenNode; - - while (virtual_sensor_node_ptr != NULL) { - //skip garbage element, [text] - if (!xmlStrcmp(virtual_sensor_node_ptr->name, (const xmlChar *)TEXT_ELEMENT)) { - virtual_sensor_node_ptr = virtual_sensor_node_ptr->next; - continue; - } - - m_virtual_sensor_configs[device_type][(const char*)virtual_sensor_node_ptr->name]; - _D("<%s>\n", device_type.c_str(), (const char*)virtual_sensor_node_ptr->name); - - element_node_ptr = virtual_sensor_node_ptr->xmlChildrenNode; - while (element_node_ptr != NULL) { - //skip garbage element, [text] - if (!xmlStrcmp(element_node_ptr->name, (const xmlChar *)TEXT_ELEMENT)) { - element_node_ptr = element_node_ptr->next; - continue; - } - - //insert Element to Model - m_virtual_sensor_configs[device_type][(const char*)virtual_sensor_node_ptr->name][(const char*)element_node_ptr->name]; - _D("<%s><%s>\n", device_type.c_str(), (const char*)virtual_sensor_node_ptr->name, (const char*)element_node_ptr->name); - - attr_ptr = element_node_ptr->properties; - while (attr_ptr != NULL) { - string key, value; - key = (char*)attr_ptr->name; - prop = (char*)xmlGetProp(element_node_ptr, attr_ptr->name); - value = prop; - free(prop); - - //insert attribute to Element - m_virtual_sensor_configs[device_type][(const char*)virtual_sensor_node_ptr->name][(const char*)element_node_ptr->name][key] = value; - _D("<%s><%s \"%s\"=\"%s\">\n", device_type.c_str(), (const char*)virtual_sensor_node_ptr->name, (const char*)element_node_ptr->name, key.c_str(), value.c_str()); - attr_ptr = attr_ptr->next; - } - - element_node_ptr = element_node_ptr->next; - } - - _D("\n"); - virtual_sensor_node_ptr = virtual_sensor_node_ptr->next; - } - - device_node_ptr = device_node_ptr->next; - } - - xmlFreeDoc(doc); - return true; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, const string& attr, string& value) -{ - auto it_device_list = m_virtual_sensor_configs.find(m_device_id); - - if (it_device_list == m_virtual_sensor_configs.end()) { - _E("There is no <%s> device\n", m_device_id.c_str()); - - m_device_id = DEFAULT_DEVICE; - it_device_list = m_virtual_sensor_configs.find(m_device_id); - - if (it_device_list == m_virtual_sensor_configs.end()) { - _E("There is no Default device\n"); - return false; - } - - _I("m_device_id is set to Default\n"); - } - - auto it_virtual_sensor_list = it_device_list->second.find(sensor_type); - - if (it_virtual_sensor_list == it_device_list->second.end()) { - _E("There is no <%s> sensor\n", sensor_type.c_str()); - return false; - } - - auto it_element = it_virtual_sensor_list->second.find(element); - - if (it_element == it_virtual_sensor_list->second.end()) { - _E("There is no <%s><%s> element\n", sensor_type.c_str(), element.c_str()); - return false; - } - - auto it_attr = it_element->second.find(attr); - - if (it_attr == it_element->second.end()) { - _D("There is no <%s><%s \"%s\">\n", sensor_type.c_str(), element.c_str(), attr.c_str()); - return false; - } - - value = it_attr->second; - - return true; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, const string& attr, float *value) -{ - string str_value; - - if (get(sensor_type, element, attr, str_value) == false) - return false; - - stringstream str_stream(str_value); - - str_stream >> *value; - - return true; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, const string& attr, int *value) -{ - string str_value; - - if (get(sensor_type, element, attr, str_value) == false) - return false; - - stringstream str_stream(str_value); - - str_stream >> *value; - - return true; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, string& value) -{ - if (get(sensor_type, element, DEFAULT_ATTR, value)) - return true; - - return false; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, float *value, int count) -{ - if (count == 1) { - if (get(sensor_type, element, DEFAULT_ATTR, value)) - return true; - } - - if (count == 3) { - if (!get(sensor_type, element, DEFAULT_ATTR1, value)) - return false; - - value++; - - if (!get(sensor_type, element, DEFAULT_ATTR2, value)) - return false; - - value++; - - if (!get(sensor_type, element, DEFAULT_ATTR3, value)) - return false; - - return true; - } - - _D("Count value not supported.\n"); - - return false; -} - -bool virtual_sensor_config::get(const string& sensor_type, const string& element, int *value, int count) -{ - if (count == 1) { - if (get(sensor_type, element, DEFAULT_ATTR, value)) - return true; - } - - if (count == 3) { - if (!get(sensor_type, element, DEFAULT_ATTR1, value)) - return false; - - value++; - - if (!get(sensor_type, element, DEFAULT_ATTR2, value)) - return false; - - value++; - - if (!get(sensor_type, element, DEFAULT_ATTR3, value)) - return false; - - return true; - } - - _D("Count value not supported.\n"); - - return false; -} - -bool virtual_sensor_config::is_supported(const string& sensor_type) -{ - auto it_device_list = m_virtual_sensor_configs.find(m_device_id); - - if (it_device_list == m_virtual_sensor_configs.end()) - return false; - - auto it_virtual_sensor_list = it_device_list->second.find(sensor_type); - - if (it_virtual_sensor_list == it_device_list->second.end()) - return false; - - return true; -} diff --git a/src/server/virtual_sensor_config.h b/src/server/virtual_sensor_config.h deleted file mode 100644 index 949d840..0000000 --- a/src/server/virtual_sensor_config.h +++ /dev/null @@ -1,83 +0,0 @@ -/* - * sensord - * - * Copyright (c) 2014 Samsung Electronics Co., Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * - */ - -#ifndef _VIRTUAL_SENSOR_CONFIG_H_ -#define _VIRTUAL_SENSOR_CONFIG_H_ - -#include - -#define VIRTUAL_SENSOR_CONFIG_FILE_PATH "/usr/etc/virtual_sensors.xml" - -typedef std::unordered_map Element; -/* -* an Element is a group of attributes -* -* -*/ - -typedef std::unordered_map Virtual_sensor; -/* -* a Virtual_sensor is a group of elements to consist of one virtual sensor's configuration -* -* -* -* ... -*/ - -typedef std::unordered_map virtual_sensor_configs; -/* -* a Virtual_sensor_config represents virtual_sensors.xml -* -* -* -* -*/ - -typedef std::unordered_map virtual_sensor_device_configs; -/* -* a virtual_sensor_device_config represents virtual_sensors.xml -* -* -* -*/ - -class virtual_sensor_config : public device_config { -private: - virtual_sensor_config(); - virtual_sensor_config& operator=(virtual_sensor_config const&); - - bool load_config(const std::string& config_path); - - virtual_sensor_device_configs m_virtual_sensor_configs; - -public: - static virtual_sensor_config& get_instance(void); - - bool get(const std::string& sensor_type, const std::string& element, const std::string& attr, std::string& value); - bool get(const std::string& sensor_type, const std::string& element, const std::string& attr, float *value); - bool get(const std::string& sensor_type, const std::string& element, const std::string& attr, int *value); - - bool get(const std::string& sensor_type, const std::string& element, std::string& value); - bool get(const std::string& sensor_type, const std::string& element, float *value, int count = 1); - bool get(const std::string& sensor_type, const std::string& element, int *value, int count = 1); - - bool is_supported(const std::string &sensor_type); -}; - -#endif /* _VIRTUAL_SENSOR_CONFIG_H_ */ -- 2.7.4 From 54eed59e2f0dc5ba2f3d3bd11d5abf0c78f090bc Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Wed, 29 Jun 2016 17:04:20 +0900 Subject: [PATCH 12/16] sensord: fix wrong log in case of setting batch latency Change-Id: I9254577b0ac02b44645578e1680550e7672b3bef Signed-off-by: kibak.yoon --- src/server/physical_sensor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/physical_sensor.cpp b/src/server/physical_sensor.cpp index 9bc53ea..96cb7f0 100644 --- a/src/server/physical_sensor.cpp +++ b/src/server/physical_sensor.cpp @@ -147,7 +147,7 @@ bool physical_sensor::set_batch_latency(unsigned long latency) if (!m_sensor_device) return false; - _I("Polling interval is set to %dms", latency); + _I("Batch latency is set to %dms", latency); return m_sensor_device->set_batch_latency(m_info->id, latency); } -- 2.7.4 From c1e1d210100f99c32e78588a71abe9e7babdd1ef Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 30 Jun 2016 11:29:22 +0900 Subject: [PATCH 13/16] sensord: version 2.0.6 Change-Id: I03bd5c537de1f3ad27d9f5cc6d5f1ce0f72b90c1 Signed-off-by: kibak.yoon --- packaging/sensord.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/sensord.spec b/packaging/sensord.spec index 9111df8..8af0b2d 100644 --- a/packaging/sensord.spec +++ b/packaging/sensord.spec @@ -1,6 +1,6 @@ Name: sensord Summary: Sensor daemon -Version: 2.0.5 +Version: 2.0.6 Release: 0 Group: System/Sensor Framework License: Apache-2.0 -- 2.7.4 From 1854e42b3a7a86d03267323a875c30043b470f37 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Thu, 30 Jun 2016 23:02:17 +0900 Subject: [PATCH 14/16] sensord: print errno log when proper errors are returned Change-Id: Ib89d28b1b75fc4ef563536f643633928ab0ec17e Signed-off-by: kibak.yoon --- src/shared/csocket.cpp | 53 ++++++++++++++++++++++++-------------------------- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/src/shared/csocket.cpp b/src/shared/csocket.cpp index 09a7d0e..3b55107 100644 --- a/src/shared/csocket.cpp +++ b/src/shared/csocket.cpp @@ -241,29 +241,26 @@ ssize_t csocket::send_for_stream(const void *buffer, size_t size) const do { len = ::send(m_sock_fd, (const void *)((uint8_t *)buffer + total_sent_size), size - total_sent_size, m_send_flags); - if (len >= 0) { - total_sent_size += len; - err = 0; - } else { - _ERRNO(errno, _E, "Failed to send(%d, %#p + %d, %d - %d) = %d for %s", - m_sock_fd, buffer, total_sent_size, size, total_sent_size, - len, get_client_name()); - + if (len < 0) { /* * If socket is not available to use it temporarily, - * EAGAIN(EWOULDBLOCK) is returned by ::send(). + * EAGAIN(EWOULDBLOCK) or EINTR is returned by ::send(). * so in order to prevent that data are omitted, sleep&retry to send it */ - if ((errno == EAGAIN) || (errno == EWOULDBLOCK)) { - usleep(1000); + if ((errno == EINTR) || (errno == EAGAIN) || (errno == EWOULDBLOCK)) { + usleep(10000); continue; } - if (errno != EINTR) { - err = errno; - break; - } + _ERRNO(errno, _E, "Failed to send(%d, %#p + %d, %d - %d) = %d for %s", + m_sock_fd, buffer, total_sent_size, size, total_sent_size, + len, get_client_name()); + + err = errno; + break; } + + total_sent_size += len; } while (total_sent_size < size); return err == 0 ? total_sent_size : -err; @@ -278,33 +275,33 @@ ssize_t csocket::recv_for_stream(void* buffer, size_t size) const do { len = ::recv(m_sock_fd, (void *)((uint8_t *)buffer + total_recv_size), size - total_recv_size, m_recv_flags); - if (len > 0) { - total_recv_size += len; - } else if (len == 0) { + if (len == 0) { _E("recv(%d, %#p + %d, %d - %d) = %d, because the peer of %s performed shutdown!", m_sock_fd, buffer, total_recv_size, size, total_recv_size, len, get_client_name()); err = 1; break; - } else { - _ERRNO(errno, _E, "Failed to recv(%d, %#p + %d, %d - %d) = %d for %s", - m_sock_fd, buffer, total_recv_size, size, total_recv_size, - len, get_client_name()); + } + if (len < 0) { /* * If socket is not available to use it temporarily, * EAGAIN(EWOULDBLOCK) is returned by ::recv(). * so in order to prevent that data are omitted, sleep&retry to receive it */ - if ((errno == EAGAIN) || (errno == EWOULDBLOCK)) { - usleep(1000); + if ((errno != EINTR) || (errno == EAGAIN) || (errno == EWOULDBLOCK)) { + usleep(10000); continue; } - if (errno != EINTR) { - err = errno; - break; - } + _ERRNO(errno, _E, "Failed to recv(%d, %#p + %d, %d - %d) = %d for %s", + m_sock_fd, buffer, total_recv_size, size, total_recv_size, + len, get_client_name()); + + err = errno; + break; } + + total_recv_size += len; } while (total_recv_size < size); return err == 0 ? total_recv_size : -err; -- 2.7.4 From 61f313be33ef4017cc02f370d5c7018380528363 Mon Sep 17 00:00:00 2001 From: "hs81.go" Date: Fri, 1 Jul 2016 14:05:45 +0900 Subject: [PATCH 15/16] sensord: modify enum values for classification Change-Id: I0db7552f2c29f1805a20f13f47a7d79a73f0adec Signed-off-by: kibak.yoon --- src/hal/sensor_hal_types.h | 6 +++--- src/shared/sensor_types.h | 8 +++----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/hal/sensor_hal_types.h b/src/hal/sensor_hal_types.h index ffa96f1..6c30f47 100644 --- a/src/hal/sensor_hal_types.h +++ b/src/hal/sensor_hal_types.h @@ -92,11 +92,11 @@ typedef enum { SENSOR_DEVICE_GESTURE_WRIST_DOWN, SENSOR_DEVICE_GESTURE_MOVEMENT_STATE, - SENSOR_DEVICE_GPS_BATCH = 0x1A00, - SENSOR_DEVICE_ACTIVITY_TRACKER, + SENSOR_DEVICE_ACTIVITY_TRACKER = 0x1A00, + SENSOR_DEVICE_ACTIVITY_LEVEL_MONITOR, + SENSOR_DEVICE_GPS_BATCH, SENSOR_DEVICE_HRM_CTRL = 0x1A80, - SENSOR_DEVICE_ACTIVITY_LEVEL_MONITOR, SENSOR_DEVICE_WEAR_STATUS = 0x2000, SENSOR_DEVICE_WEAR_ON_MONITOR, diff --git a/src/shared/sensor_types.h b/src/shared/sensor_types.h index 0612f72..277cbc4 100644 --- a/src/shared/sensor_types.h +++ b/src/shared/sensor_types.h @@ -75,12 +75,11 @@ extern "C" DEF_SENSOR(GESTURE_WRIST_DOWN_SENSOR) \ DEF_SENSOR(GESTURE_MOVEMENT_STATE_SENSOR) \ \ - DEF_SENSOR_VALUE(GPS_BATCH_SENSOR, 0x1A00) \ - DEF_SENSOR(ACTIVITY_TRACKER_SENSOR) \ - DEF_SENSOR(EXERCISE_COMPANION_SENSOR) \ + DEF_SENSOR_VALUE(ACTIVITY_TRACKER_SENSOR, 0x1A00) \ + DEF_SENSOR(ACTIVITY_LEVEL_MONITOR_SENSOR) \ + DEF_SENSOR(GPS_BATCH_SENSOR) \ \ DEF_SENSOR_VALUE(HRM_CTRL_SENSOR, 0x1A80) \ - DEF_SENSOR(ACTIVITY_LEVEL_MONITOR_SENSOR) \ \ DEF_SENSOR_VALUE(WEAR_STATUS_SENSOR, 0x2000) \ DEF_SENSOR(WEAR_ON_MONITOR_SENSOR) \ @@ -114,7 +113,6 @@ extern "C" #define STRESS_MONITOR_SENSOR HUMAN_STRESS_MONITOR_SENSOR #define AUTOSESSION_EXERCISE_SENSOR WORKOUT_SENSOR #define EXERCISE_COACH_SENSOR EXERCISE_STANDALONE_SENSOR -#define EXERCISE_SENSOR EXERCISE_COMPANION_SENSOR DECLARE_SENSOR_ENUM(sensor_type_t, SENSOR_TYPE) -- 2.7.4 From accdf6fdbbed61452774638acbb7e58ecdb75a15 Mon Sep 17 00:00:00 2001 From: Yunjin Lee Date: Wed, 20 Jul 2016 20:28:46 +0900 Subject: [PATCH 16/16] Set SmackProcessLabel to System Change-Id: Ic6db23e47dfc46aeade072e08a8396b4505774a5 Signed-off-by: Yunjin Lee --- packaging/sensord.service | 1 + 1 file changed, 1 insertion(+) diff --git a/packaging/sensord.service b/packaging/sensord.service index 5cb2e72..031b383 100644 --- a/packaging/sensord.service +++ b/packaging/sensord.service @@ -5,6 +5,7 @@ Description=Sensor Daemon User=sensor Group=input Type=notify +SmackProcessLabel=System ExecStart=/usr/bin/sensord MemoryLimit=20M Sockets=sensord_command.socket -- 2.7.4