From ea9014a9a387dbd7ab72f6288f27b7158fc9a08e Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 9 Apr 2019 15:35:27 +0900 Subject: [PATCH 01/16] Update package version to 1.0.14 Change-Id: I5514d29b09dac9ad9ed3e822640fffe5044d7a2e Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index 29f1026..df069f6 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index 696105e..e58021a 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.13 +Version: 1.0.14 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From 7211bcfb21916cf8037221fc62db016ae261e7ef Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Mon, 15 Apr 2019 17:35:34 +0900 Subject: [PATCH 02/16] Change as appropriate log level Change-Id: Ie53b321666e70bcd2e661cd16453edcbe1359659 Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 14 +++++++------- src/autofill_config.c | 8 +++++--- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index 238fb4e..cfa2de5 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -644,7 +644,7 @@ static void __error_info_recv_cb(void *user_data, int context_id, rpc_port_autof if (sender_client) rpc_port_AutofillAppPort_autofill_error_info_received_cb_invoke(sender_client->error_info_cb, error_info_h); - LOGD("error code : %#x, message : '%s'", error_code, get_error_message(error_code)); + LOGI("error code : %#x, message : '%s'", error_code, get_error_message(error_code)); if (app_id) free(app_id); @@ -677,7 +677,7 @@ static void __on_connected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) int r = rpc_port_proxy_AutofillSvcPort_invoke_Register(h, auth_info_cb_h, fill_response_received_cb_h, error_info_cb_h); if (r != 0) - LOGD("Failed to invoke Register"); + LOGW("Failed to invoke Register"); g_connected = true; } @@ -727,7 +727,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillSvcPort_h h, void *user_dat static void __on_rejected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) { - LOGD("rejected"); + LOGI("rejected"); } //LCOV_EXCL_STOP @@ -849,9 +849,9 @@ static bool connect_service() return true; } - LOGD("get autofill service app id..."); + LOGD("get autofill service app id"); autofill_config_get_autofill_service_app_id(&active_autofill_service_id, &sys_config); - LOGD("active autofill service app id: '%s'", active_autofill_service_id); + LOGI("active autofill service app id: '%s'", active_autofill_service_id); if (!active_autofill_service_id) { active_autofill_service_id = strdup(AUTOFILL_SERVICE_APP_ID); @@ -869,7 +869,7 @@ static bool connect_service() ret = rpc_port_proxy_AutofillSvcPort_create(active_autofill_service_id, &rpc_callback, NULL, &svc_rpc_h); } else if (service_id_len == 0) { - LOGD("No Autofill service to connect"); + LOGW("No Autofill service to connect"); free(active_autofill_service_id); return false; } @@ -880,7 +880,7 @@ static bool connect_service() return false; } - LOGD("Connect to autofill service: '%s'", active_autofill_service_id); + LOGI("Connect to autofill service: '%s'", active_autofill_service_id); free(active_autofill_service_id); ret = rpc_port_proxy_AutofillSvcPort_connect(svc_rpc_h); if (ret != RPC_PORT_ERROR_NONE) { diff --git a/src/autofill_config.c b/src/autofill_config.c index 778d826..a9587ed 100644 --- a/src/autofill_config.c +++ b/src/autofill_config.c @@ -40,16 +40,18 @@ bool autofill_config_get_autofill_service_app_id(char **app_id, bool *sys_config *sys_config = false; if (preference_get_string(SETTING_ACTIVE_AUTOFILL_SERVICE, &active_autofill_service_id) == PREFERENCE_ERROR_NONE) { - LOGD("preference active autofill service : %s", active_autofill_service_id); + LOGI("preference active autofill service : %s", active_autofill_service_id); *app_id = active_autofill_service_id; return true; } - LOGD("Read from config"); + LOGI("Read from config"); pFile = fopen(AUTOFILL_SYSTEM_CONFIG_FILE, "r"); - if (pFile == NULL) + if (pFile == NULL) { + LOGW("Failed to open system config file"); return false; + } while (fgets(strTemp, sizeof(strTemp), pFile) != NULL) { -- 2.7.4 From 03913278bf73f128726838dd2871edf5414dcc7e Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 18 Apr 2019 17:24:57 +0900 Subject: [PATCH 03/16] Update package version to 1.0.15 Change-Id: Icc4d0be9b584fa6f421afbc80ec160ea94415978 Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index df069f6..e7008b6 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index e58021a..411c0de 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.14 +Version: 1.0.15 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From bd1a607d506f45ffd7be4f2d33340a11ab033f8c Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 3 May 2019 11:33:55 +0900 Subject: [PATCH 04/16] Support view title in save view info Change-Id: I1d18d1400dc4826307e48d60cff3ad0ded4b5bf1 Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 13 +++++++++---- tidl/autofill.tidl | 1 + tidl/autofill_service.tidl | 1 + 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index cfa2de5..f8a545f 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -351,6 +351,7 @@ bool __save_item_cb(rpc_port_autofill_save_item_h items, void *user_data) static int __auth_info_request_cb(rpc_port_stub_AutofillAppPort_context_h context, int context_id, rpc_port_autofill_view_info_h vi, void *user_data) { char *sender = NULL; + char *view_id = NULL; if (!g_connected) { LOGW("Not connected to autofill service"); @@ -363,7 +364,6 @@ static int __auth_info_request_cb(rpc_port_stub_AutofillAppPort_context_h contex } rpc_port_stub_AutofillAppPort_context_get_sender(context, &sender); - char *view_id = NULL; rpc_port_autofill_view_info_get_view_id(vi, &view_id); LOGD("app id : %s, view id : %s", sender, view_id); @@ -443,6 +443,7 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont { char *sender = NULL; char *view_id = NULL; + char *view_title = NULL; if (!g_connected) { LOGW("Not connected to autofill service"); @@ -468,10 +469,11 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont } rpc_port_autofill_save_view_info_get_view_id(vi, &view_id); - if (view_id) { - LOGD("view id : %s", view_id); - } + rpc_port_autofill_save_view_info_get_view_title(vi, &view_title); + + LOGD("view id : '%s', view title : '%s'", view_id, view_title); rpc_port_autofill_svc_save_view_info_set_view_id(svi, view_id); + rpc_port_autofill_svc_save_view_info_set_view_title(svi, view_title); rpc_port_autofill_save_view_info_foreach_items(vi, __save_item_cb, svi); @@ -480,6 +482,9 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont if (view_id) free(view_id); + if (view_title) + free(view_title); + rpc_port_autofill_svc_save_view_info_destroy(svi); return 0; diff --git a/tidl/autofill.tidl b/tidl/autofill.tidl index fbf53b4..bfac23d 100644 --- a/tidl/autofill.tidl +++ b/tidl/autofill.tidl @@ -21,6 +21,7 @@ struct autofill_save_item { struct autofill_save_view_info { string view_id; + string view_title; list items; } diff --git a/tidl/autofill_service.tidl b/tidl/autofill_service.tidl index 31a4809..ffe3dc1 100644 --- a/tidl/autofill_service.tidl +++ b/tidl/autofill_service.tidl @@ -23,6 +23,7 @@ struct autofill_svc_save_item { struct autofill_svc_save_view_info { string app_id; string view_id; + string view_title; list items; } -- 2.7.4 From 3115934c057a4526759ee6d130aab8b41dd5ba42 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 23 Apr 2019 18:27:55 +0900 Subject: [PATCH 05/16] Update package version to 1.0.16 Change-Id: Id8c305f0209a197169e4abdd9dc1e648c65761b6 Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index e7008b6..a3187d5 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index 411c0de..26de581 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.15 +Version: 1.0.16 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From b3edeb36b5489789bf6efc0925382cb804bf3a22 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 24 May 2019 19:11:36 +0900 Subject: [PATCH 06/16] Fix crash issue when changing autofill service Change-Id: Iece591b82133bf0f5665f79176960bd76cd8ddef Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 9 ++++++++- src/autofill_config.c | 3 +-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index f8a545f..69519ae 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -738,7 +738,7 @@ static void __on_rejected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_context_h context, const char *app_id, void *user_data) { - LOGD("app id : %s", app_id); + LOGD("autofill service app id: '%s'", app_id); if (app_id) autofill_config_set_autofill_service_app_id(app_id); @@ -750,6 +750,13 @@ static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_ int ret = rpc_port_proxy_AutofillSvcPort_destroy(svc_rpc_h); LOGD("ret : %#x", ret); + if (ret == RPC_PORT_ERROR_NONE) { + fill_response_received_cb_h = NULL; + auth_info_cb_h = NULL; + error_info_cb_h = NULL; + + g_connected = false; + } } svc_rpc_h = NULL; diff --git a/src/autofill_config.c b/src/autofill_config.c index a9587ed..6e5f099 100644 --- a/src/autofill_config.c +++ b/src/autofill_config.c @@ -109,5 +109,4 @@ bool autofill_config_set_autofill_service_app_id(const char *app_id) return true; return false; -} - +} \ No newline at end of file -- 2.7.4 From 75df9bed2d1358d68071f060901c47c6c511c147 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 24 May 2019 20:24:57 +0900 Subject: [PATCH 07/16] Fix memory leak issues Change-Id: I96b42d7b8f15406c7454bf2d8e35cffca7a7cb54 Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index 69519ae..f22e99d 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -455,13 +455,13 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont return 0; } - rpc_port_stub_AutofillAppPort_context_get_sender(context, &sender); - rpc_port_autofill_svc_save_view_info_h svi = NULL; if (rpc_port_autofill_svc_save_view_info_create(&svi) != 0) { return 0; } + rpc_port_stub_AutofillAppPort_context_get_sender(context, &sender); + if (sender) { rpc_port_autofill_svc_save_view_info_set_app_id(svi, sender); LOGD("sender(%s)", sender); @@ -649,6 +649,8 @@ static void __error_info_recv_cb(void *user_data, int context_id, rpc_port_autof if (sender_client) rpc_port_AutofillAppPort_autofill_error_info_received_cb_invoke(sender_client->error_info_cb, error_info_h); + rpc_port_autofill_error_info_destroy(error_info_h); + LOGI("error code : %#x, message : '%s'", error_code, get_error_message(error_code)); if (app_id) -- 2.7.4 From f427a69abd6e3eb5271cd49fde50ce750ee8c5ad Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 24 May 2019 16:21:01 +0900 Subject: [PATCH 08/16] Update package version to 1.0.17 Change-Id: I1a674df00537e5c89bec4047318330699ac205eb Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index a3187d5..04976f3 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index 26de581..8310c9a 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.16 +Version: 1.0.17 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From fe19f87c6075674a022d464a6110b1dac18776f5 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 23 Apr 2019 17:24:13 +0900 Subject: [PATCH 09/16] Support on-demand launch Change-Id: Id8c87ed0a84ed9f172a4ec101d67c7b22dd9d6cb Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- src/autofill-daemon.c | 27 ++++++++++++++++++++------- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index 04976f3..70983fe 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -3,7 +3,7 @@ Jihoon Kim autofilld - + diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index f22e99d..328ac2d 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -48,6 +48,7 @@ static Ecore_Timer *g_connect_timer = NULL; static bool g_connected = false; static bool connect_service(); +static void terminate_autofill_service(); static autofill_client_s * get_autofill_client(const char *app_id, int context_id) @@ -173,6 +174,13 @@ static void __remove_client(rpc_port_stub_AutofillAppPort_context_h context) __client_list = g_list_remove(__client_list, client); __destroy_client(client); + + if (g_list_length(__client_list) == 0) { + terminate_autofill_service(); + + LOGI("terminate autofill daemon"); + service_app_exit(); + } } static void __message_create(rpc_port_stub_AutofillAppPort_context_h context, @@ -738,15 +746,10 @@ static void __on_rejected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) } //LCOV_EXCL_STOP -static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_context_h context, const char *app_id, void *user_data) +static void terminate_autofill_service() { - LOGD("autofill service app id: '%s'", app_id); - - if (app_id) - autofill_config_set_autofill_service_app_id(app_id); - if (svc_rpc_h) { - LOGD("send terminate"); + LOGI("Send terminate message to autofill service"); // terminate service rpc_port_proxy_AutofillSvcPort_invoke_request_terminate(svc_rpc_h); @@ -762,6 +765,16 @@ static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_ } svc_rpc_h = NULL; +} + +static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_context_h context, const char *app_id, void *user_data) +{ + LOGD("autofill service app id: '%s'", app_id); + + if (app_id) + autofill_config_set_autofill_service_app_id(app_id); + + terminate_autofill_service(); connect_service(); -- 2.7.4 From 54281e461e4f82c900c95892d741e6265f4e62c7 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Thu, 13 Jun 2019 11:16:14 +0900 Subject: [PATCH 10/16] Update package version to 1.0.18 Change-Id: Iaa0b47154af8c1fee252afc90146dd0f0fc4882c Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index 70983fe..a7bdce4 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index 8310c9a..d8037b1 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.17 +Version: 1.0.18 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From e601158a61fbb3eba53f4c09ed046008ce90b448 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 3 Jul 2019 16:22:00 +0900 Subject: [PATCH 11/16] Change log level Change-Id: I1538205de57122d32b6d381e238f03172a127778 Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index 328ac2d..2e496d8 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -479,7 +479,7 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont rpc_port_autofill_save_view_info_get_view_id(vi, &view_id); rpc_port_autofill_save_view_info_get_view_title(vi, &view_title); - LOGD("view id : '%s', view title : '%s'", view_id, view_title); + LOGI("view id : '%s', view title : '%s'", view_id, view_title); rpc_port_autofill_svc_save_view_info_set_view_id(svi, view_id); rpc_port_autofill_svc_save_view_info_set_view_title(svi, view_title); @@ -742,7 +742,7 @@ static void __on_disconnected(rpc_port_proxy_AutofillSvcPort_h h, void *user_dat static void __on_rejected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) { - LOGI("rejected"); + LOGW("Rejected to connect autofill service"); } //LCOV_EXCL_STOP @@ -769,7 +769,7 @@ static void terminate_autofill_service() static bool __manager_set_autofill_service_cb(rpc_port_stub_AutofillManagerPort_context_h context, const char *app_id, void *user_data) { - LOGD("autofill service app id: '%s'", app_id); + LOGI("autofill service app id: '%s'", app_id); if (app_id) autofill_config_set_autofill_service_app_id(app_id); @@ -791,7 +791,7 @@ static char * __manager_get_autofill_service_cb(rpc_port_stub_AutofillManagerPor char *app_id = NULL; autofill_config_get_autofill_service_app_id(&app_id, NULL); - LOGD("app id : %s", app_id); + LOGI("app id : %s", app_id); return app_id; } @@ -807,7 +807,7 @@ bool add_autofill_service_cb(app_info_h app_info, void *user_data) return true; } - LOGD("Find autofill service : %s", app_id); + LOGI("Find autofill service : %s", app_id); rpc_port_list_string_add_list_strings(service_info_list, app_id); @@ -939,7 +939,7 @@ bool service_app_create(void *data) ret = rpc_port_stub_AutofillAppPort_register(&callback, NULL); if (ret != 0) - LOGI("Failed to register app port"); + LOGW("Failed to register app port"); else LOGI("Succeeded to register app port"); @@ -954,7 +954,7 @@ bool service_app_create(void *data) ret = rpc_port_stub_AutofillManagerPort_register(&manager_callback, NULL); if (ret != 0) - LOGI("Failed to register manager port"); + LOGW("Failed to register manager port"); else LOGI("Succeeded to register manager port"); -- 2.7.4 From ec83574ba1253188be2d60ef04f45aa1b9a06d20 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 5 Jul 2019 14:03:57 +0900 Subject: [PATCH 12/16] Update package version to 1.0.19 Change-Id: If35951d7965356e46006664054e435757b912547 Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index a7bdce4..9c345af 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index d8037b1..caa8d98 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.18 +Version: 1.0.19 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From dc948d564afa7c706b0d30a02f781797295234d7 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 9 Jul 2019 14:29:42 +0900 Subject: [PATCH 13/16] Rename internal function Change-Id: I4976bc2a2ac526527ee66d78ba8629554148f9ed Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index 2e496d8..b20029d 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -183,7 +183,7 @@ static void __remove_client(rpc_port_stub_AutofillAppPort_context_h context) } } -static void __message_create(rpc_port_stub_AutofillAppPort_context_h context, +static void __client_create(rpc_port_stub_AutofillAppPort_context_h context, void *user_data) { LOGD(""); @@ -197,7 +197,7 @@ static void __message_create(rpc_port_stub_AutofillAppPort_context_h context, free(sender); } -static void __message_terminate(rpc_port_stub_AutofillAppPort_context_h context, +static void __client_terminate(rpc_port_stub_AutofillAppPort_context_h context, void *user_data) { LOGD(""); @@ -213,7 +213,7 @@ static void __message_terminate(rpc_port_stub_AutofillAppPort_context_h context, __remove_client(context); } -static int __message_register(rpc_port_stub_AutofillAppPort_context_h context, +static int __client_register(rpc_port_stub_AutofillAppPort_context_h context, int context_id, rpc_port_AutofillAppPort_autofill_auth_info_received_cb_h auth_info_cb, rpc_port_AutofillAppPort_autofill_fill_response_received_cb_h fill_response_received_cb, @@ -243,7 +243,7 @@ static int __message_register(rpc_port_stub_AutofillAppPort_context_h context, return 0; } -static void __message_unregister(rpc_port_stub_AutofillAppPort_context_h context, int context_id, void *user_data) +static void __client_unregister(rpc_port_stub_AutofillAppPort_context_h context, int context_id, void *user_data) { __remove_client(context); } @@ -928,10 +928,10 @@ bool service_app_create(void *data) int ret; // register app port rpc_port_stub_AutofillAppPort_callback_s callback = { - __message_create, - __message_terminate, - __message_register, - __message_unregister, + __client_create, + __client_terminate, + __client_register, + __client_unregister, __auth_info_request_cb, __autofill_fill_request_cb, __commit_cb, -- 2.7.4 From 866b8f6996f9f7400554fe4a267c87b6fd76a5a7 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 9 Jul 2019 16:04:46 +0900 Subject: [PATCH 14/16] Support to deliver autofill hint in fill response Change-Id: I88ec487c890f6560ba70e1119521b7a6801ca6e9 Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 4 ++++ tidl/autofill.tidl | 1 + tidl/autofill_service.tidl | 1 + 3 files changed, 6 insertions(+) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index b20029d..64483fb 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -505,6 +505,7 @@ bool fill_response_item_cb(rpc_port_autofill_svc_response_item_h response_items, char *id = NULL; char *presentation_text = NULL; char *value = NULL; + int autofill_hint; rpc_port_autofill_response_item_h res_item = NULL; @@ -521,6 +522,9 @@ bool fill_response_item_cb(rpc_port_autofill_svc_response_item_h response_items, rpc_port_autofill_svc_response_item_get_value(response_items, &value); rpc_port_autofill_response_item_set_value(res_item, value); + rpc_port_autofill_svc_response_item_get_autofill_hint(response_items, &autofill_hint); + rpc_port_autofill_response_item_set_autofill_hint(res_item, autofill_hint); + rpc_port_autofill_response_group_add_response_items(res_group, res_item); if (id) diff --git a/tidl/autofill.tidl b/tidl/autofill.tidl index bfac23d..803697e 100644 --- a/tidl/autofill.tidl +++ b/tidl/autofill.tidl @@ -40,6 +40,7 @@ struct autofill_response_item { string id; string presentation_text; string value; + int autofill_hint; } struct autofill_response_group { diff --git a/tidl/autofill_service.tidl b/tidl/autofill_service.tidl index ffe3dc1..06d1aa3 100644 --- a/tidl/autofill_service.tidl +++ b/tidl/autofill_service.tidl @@ -42,6 +42,7 @@ struct autofill_svc_response_item { string id; string presentation_text; string value; + int autofill_hint; } struct autofill_svc_response_group { -- 2.7.4 From 52b5fe723ad9525eb7392f5aeb42de73f2e3fa72 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Wed, 10 Jul 2019 19:11:16 +0900 Subject: [PATCH 15/16] Update package version to 1.0.20 Change-Id: I404150c6bdbf7052aabcb2ed36522c8a852ee529 Signed-off-by: Jihoon Kim --- org.tizen.autofilld.xml | 2 +- packaging/org.tizen.autofilld.spec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.tizen.autofilld.xml b/org.tizen.autofilld.xml index 9c345af..1737e75 100644 --- a/org.tizen.autofilld.xml +++ b/org.tizen.autofilld.xml @@ -1,5 +1,5 @@ - + Jihoon Kim autofilld diff --git a/packaging/org.tizen.autofilld.spec b/packaging/org.tizen.autofilld.spec index caa8d98..4f9ceea 100644 --- a/packaging/org.tizen.autofilld.spec +++ b/packaging/org.tizen.autofilld.spec @@ -1,6 +1,6 @@ Name: org.tizen.autofilld Summary: Autofill Daemon -Version: 1.0.19 +Version: 1.0.20 Release: 1 Group: Graphics & UI Framework/Input License: Apache-2.0 -- 2.7.4 From e2f6ad6cd8a167a0ebca0d332aa76f270b9ee486 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 26 Jul 2019 14:14:23 +0900 Subject: [PATCH 16/16] Reconnect in case of rejecting Change-Id: I39ee186b51f2b5f4d67742901a4c231ef043fffa Signed-off-by: Jihoon Kim --- src/autofill-daemon.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c index 64483fb..5acfa5a 100644 --- a/src/autofill-daemon.c +++ b/src/autofill-daemon.c @@ -29,6 +29,8 @@ #include "autofill_manager_stub.h" #include "autofill_config.h" +#define RECONNECT_PERIOD 1.0 + static rpc_port_proxy_AutofillSvcPort_h svc_rpc_h = NULL; static rpc_port_AutofillSvcPort_autofill_svc_fill_response_cb_h fill_response_received_cb_h = NULL; static rpc_port_AutofillSvcPort_autofill_svc_auth_info_cb_h auth_info_cb_h = NULL; @@ -711,11 +713,8 @@ static Eina_Bool connect_timer_cb(void *data) return ECORE_CALLBACK_RENEW; } -//LCOV_EXCL_START -static void __on_disconnected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) +static void retry_connect_service() { - LOGW("Autofill service is disconnected"); - svc_rpc_h = NULL; if (fill_response_received_cb_h) { @@ -740,13 +739,23 @@ static void __on_disconnected(rpc_port_proxy_AutofillSvcPort_h h, void *user_dat if (g_connect_timer) ecore_timer_del(g_connect_timer); - g_connect_timer = ecore_timer_add(1.0, connect_timer_cb, NULL); + g_connect_timer = ecore_timer_add(RECONNECT_PERIOD, connect_timer_cb, NULL); } } +//LCOV_EXCL_START +static void __on_disconnected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) +{ + LOGW("Autofill service is disconnected"); + + retry_connect_service(); +} + static void __on_rejected(rpc_port_proxy_AutofillSvcPort_h h, void *user_data) { LOGW("Rejected to connect autofill service"); + + retry_connect_service(); } //LCOV_EXCL_STOP -- 2.7.4