From c7ce4c8134a5792f4302100c71436db8dea52610 Mon Sep 17 00:00:00 2001 From: Eunhye Choi Date: Thu, 22 Jul 2021 18:03:44 +0900 Subject: [PATCH] [0.6.257] fix coverity issue Change-Id: I5ba21aa62ca611c0e81fed3b458e6cd757f937c9 --- packaging/libmm-player.spec | 2 +- src/mm_player_priv.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec index 65bce65..7e27f27 100644 --- a/packaging/libmm-player.spec +++ b/packaging/libmm-player.spec @@ -1,6 +1,6 @@ Name: libmm-player Summary: Multimedia Framework Player Library -Version: 0.6.256 +Version: 0.6.257 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 73046be..9700190 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -2121,13 +2121,6 @@ _mmplayer_update_video_overlay_param(mmplayer_t *player, const char *param_name) MMPLAYER_FENTER(); - mm_attrs_get_int_by_name(player->attrs, "display_surface_type", &curr_type); - - if (curr_type != MM_DISPLAY_SURFACE_OVERLAY && curr_type != MM_DISPLAY_SURFACE_OVERLAY_SYNC_UI) { - LOGE("current type(%d) is wrong", curr_type); - return MM_ERROR_PLAYER_INTERNAL; - } - if (!player || !player->pipeline || !player->pipeline->mainbin || !player->pipeline->videobin || !player->pipeline->videobin[MMPLAYER_V_BIN].gst || !player->pipeline->videobin[MMPLAYER_V_SINK].gst) { @@ -2135,6 +2128,13 @@ _mmplayer_update_video_overlay_param(mmplayer_t *player, const char *param_name) return MM_ERROR_PLAYER_NOT_INITIALIZED; } + mm_attrs_get_int_by_name(player->attrs, "display_surface_type", &curr_type); + + if (curr_type != MM_DISPLAY_SURFACE_OVERLAY && curr_type != MM_DISPLAY_SURFACE_OVERLAY_SYNC_UI) { + LOGE("current type(%d) is wrong", curr_type); + return MM_ERROR_PLAYER_INTERNAL; + } + if (strcmp(player->ini.videosink_element_overlay, "tizenwlsink")) { LOGE("invalid videosink [%s]", player->ini.videosink_element_overlay); return MM_ERROR_PLAYER_INTERNAL; -- 2.7.4