From c7c083ff81e2875ebaa7d12c9aba8bd4b81a19ec Mon Sep 17 00:00:00 2001 From: Slawomir Cygan Date: Fri, 17 Feb 2023 12:58:04 +0100 Subject: [PATCH] Do not check framework-provided VK1.3.robustImageAccess feature In f7a8ccc2 the value of robustImageAccess reported and requested by the framework was forced to be always-FALSE, as it had potential overhead on some implementations. However, the extension support check for VK_EXT_image_robustness extension was still relying on it, so related tests are now unrunnable - they always return not supported. As related tests seem to do own feature checks and custom device creation, it looks safe to remove checking for feature from extension support check. VK-GL-CTS Issue: 4241 Components: Vulkan, Framework Affects: dEQP-VK.robustness.pipeline_robustness.image_robustness.* dEQP-VK.robustness.image_robustness.* dEQP-VK.* Change-Id: I3f9f9c09ce271a965e2a8625ce010b9efd1abc34 --- external/vulkancts/modules/vulkan/vktTestCase.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/external/vulkancts/modules/vulkan/vktTestCase.cpp b/external/vulkancts/modules/vulkan/vktTestCase.cpp index f7e5444..bce34eb 100644 --- a/external/vulkancts/modules/vulkan/vktTestCase.cpp +++ b/external/vulkancts/modules/vulkan/vktTestCase.cpp @@ -533,8 +533,6 @@ bool Context::isDeviceFunctionalitySupported (const std::string& extension) cons return !!vk12Features.shaderOutputViewportIndex && !!vk12Features.shaderOutputLayer; const auto& vk13Features = m_device->getVulkan13Features(); - if (extension == "VK_EXT_image_robustness") - return !!vk13Features.robustImageAccess; if (extension == "VK_EXT_inline_uniform_block") return !!vk13Features.inlineUniformBlock; if (extension == "VK_EXT_pipeline_creation_cache_control") -- 2.7.4