From c739afa4e034d73cd39c81cca568f48732ce4099 Mon Sep 17 00:00:00 2001 From: Hyunil Date: Fri, 17 Jan 2020 09:56:03 +0900 Subject: [PATCH] fix coverity issue Change-Id: I57023d27c897fd2d6bf16c0b1cef12d52874f6f8 Signed-off-by: Hyunil --- test/player_test.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test/player_test.c b/test/player_test.c index a3b9ae3..1d23e1f 100644 --- a/test/player_test.c +++ b/test/player_test.c @@ -701,6 +701,7 @@ static void reset_display() static void input_filename(char *filename) { int len = 0; + gsize src_size = 0; int i = 0; if (!filename) @@ -721,7 +722,9 @@ static void input_filename(char *filename) g_print("player create is failed\n"); } - g_strlcpy(g_uri, filename, MAX_STRING_LEN); + src_size = g_strlcpy(g_uri, filename, MAX_STRING_LEN); + if (src_size != len) + return; #if 0 /* ned(APPSRC_TEST) */ @@ -1917,11 +1920,15 @@ static void get_display_visible(bool *visible) static void input_subtitle_filename(char *subtitle_filename) { int len = strlen(subtitle_filename); + gsize src_size = 0; if (len < 1 || len > MAX_STRING_LEN - 1) return; - g_strlcpy(g_subtitle_uri, subtitle_filename, MAX_STRING_LEN); + src_size = g_strlcpy(g_subtitle_uri, subtitle_filename, MAX_STRING_LEN); + if (src_size != len) + return; + g_print("subtitle uri is set to %s\n", g_subtitle_uri); player_set_subtitle_path(g_player[0], g_subtitle_uri); player_set_subtitle_updated_cb(g_player[0], subtitle_updated_cb, (void *)g_player[0]); -- 2.7.4