From bb0cc5ac97db8499c5f40d706b8dc05c530c57b0 Mon Sep 17 00:00:00 2001 From: Zbigniew Kostrzewa Date: Thu, 3 Oct 2013 07:20:42 +0200 Subject: [PATCH] Fix Prevent issue [Issue#] CID: 33265 [Problem] Resource leak. [Cause] Allocated memory is not released. [Solution] Fix the code so that allocated memory is assigned to pointer from outer scope which is passed to the EVAS_CALLBACK_DEL callback (in which the memory is released). [Verification] 1. Build repository 2. Run a test that will display pop-up from security origin. Change-Id: Ic03284cb9b696e4d5aa8329d081700d2bd086381 --- src/view/common/view_logic_certificate_support.cpp | 2 +- src/view/common/view_logic_security_origin_support.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/common/view_logic_certificate_support.cpp b/src/view/common/view_logic_certificate_support.cpp index a4291e8..9cd535e 100644 --- a/src/view/common/view_logic_certificate_support.cpp +++ b/src/view/common/view_logic_certificate_support.cpp @@ -173,7 +173,7 @@ Evas_Object* CertificateSupportUtil::createPopup( CallbackData* callbackData = NULL; if (keyCallback) { - CallbackData* callbackData = new CallbackData; + callbackData = new CallbackData; callbackData->eaKeyCallback = keyCallback; ea_object_event_callback_add(popup, EA_CALLBACK_BACK, keyCallback, data); } diff --git a/src/view/common/view_logic_security_origin_support.cpp b/src/view/common/view_logic_security_origin_support.cpp index dcebefc..fcb98bd 100644 --- a/src/view/common/view_logic_security_origin_support.cpp +++ b/src/view/common/view_logic_security_origin_support.cpp @@ -169,7 +169,7 @@ Evas_Object* SecurityOriginSupportUtil::createPopup( CallbackData* callbackData = NULL; if (keyCallback) { - CallbackData* callbackData = new CallbackData; + callbackData = new CallbackData; callbackData->eaKeyCallback = keyCallback; ea_object_event_callback_add(popup, EA_CALLBACK_BACK, keyCallback, data); } -- 2.7.4