From a894a5f0f77c04256e13c5aa8f08a5b282bcb720 Mon Sep 17 00:00:00 2001 From: Suyeon Hwang Date: Wed, 19 Apr 2023 11:43:53 +0900 Subject: [PATCH] Pass missing parameter to real function - Issue: After reprepare_on_demand(), the client handle is missing. - Solution: Previous code does not pass all neccessary parameters, so the function can write value into arbitrary pointer. And this pointer access can cause critical memory crash. Thus, this patch fixes the code to make sure the tts_ipc module pass all proper parameters to actual function in tts_dbus and tts_tidl module. Change-Id: I2276c05e3b29f070664b8fad607cc1d13ddb9cee Signed-off-by: Suyeon Hwang --- client/tts_ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/tts_ipc.c b/client/tts_ipc.c index 8e75326..5229a56 100644 --- a/client/tts_ipc.c +++ b/client/tts_ipc.c @@ -136,7 +136,7 @@ int tts_ipc_request_initialize(unsigned int uid, tts_mode_e mode, tts_playing_mo RETVM_IF(false == tts_client_is_valid_uid(uid), TTS_ERROR_INVALID_PARAMETER, "Fail to get tts_client with uid(%u)", uid); RETVM_IF(NULL == g_vtable, TTS_ERROR_OPERATION_FAILED, "[ERROR] IPC method is not set"); - return g_vtable[REQUEST_INITIALIZE](uid, mode, registered_event_mask, service_state, credential_needed); + return g_vtable[REQUEST_INITIALIZE](uid, mode, playing_mode, registered_event_mask, service_state, credential_needed); } int tts_ipc_request_finalize(unsigned int uid) -- 2.7.4