From 9cf2d308ce289293932d40d70005e3e4e67f64d1 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 11 Jul 2018 16:16:38 +0100 Subject: [PATCH] dbus_server_listen: Don't leak first_connect_error If an implementation fails to listen, and a subsequent implementation succeeds, then we would have leaked this. Detected by running tests/loopback.c under valgrind. Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107194 (cherry picked from commit b14a4517a82f7e7e4c0b59cb663ebf77563decda) --- dbus/dbus-server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c index d91df83..7a1243b 100644 --- a/dbus/dbus-server.c +++ b/dbus/dbus-server.c @@ -680,6 +680,7 @@ dbus_server_listen (const char *address, } else { + dbus_error_free (&first_connect_error); _DBUS_ASSERT_ERROR_IS_CLEAR (error); return server; } -- 2.7.4