From 7e0008803c8b7f9f90baa04cb322e0efb49599eb Mon Sep 17 00:00:00 2001 From: Jihoon Chung Date: Tue, 1 Oct 2013 17:18:08 +0900 Subject: [PATCH] Fixed wrong argument usage for geolocation permission popup [Issue#] N/A [Problem] Fail to set "allow"/"deny" even though user selects button on the permision request popup [Cause] Wrong argument passed to "SecurityOriginSupportUtil::getResult" API. - Wrong Usage : popup evas_object - Right Usage : button evas_object [Solution] Change argument to correct evas_object for "button". [SCMRequest] N/A Change-Id: I6b02599837d5680747a9a2337cf3d6f29ef41c12 --- src/view/webkit/view_logic_geolocation_support.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/view/webkit/view_logic_geolocation_support.cpp b/src/view/webkit/view_logic_geolocation_support.cpp index 7c6921b..4648863 100644 --- a/src/view/webkit/view_logic_geolocation_support.cpp +++ b/src/view/webkit/view_logic_geolocation_support.cpp @@ -101,16 +101,17 @@ void setPermissionResult(PermissionData* permData, Result result) void popupCallback(void* data, Evas_Object* obj, void* eventInfo) { _D("called"); - DPL_UNUSED_PARAM(eventInfo); - Assert(data); Assert(obj); + Assert(data); - PermissionData* permData = static_cast(data); - Evas_Object* popup = getPopup(obj); - setPermissionResult(permData, getResult(popup)); + DPL_UNUSED_PARAM(eventInfo); + PermissionData* permData = static_cast(data); + setPermissionResult(permData, getResult(obj)); delete permData; + + Evas_Object* popup = getPopup(obj); evas_object_hide(popup); evas_object_del(popup); } -- 2.7.4