From 5226ce9395749259cdc3bab8a94c0244ae3315ac Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 2 Apr 2013 17:53:36 +0100 Subject: [PATCH] By default, do debug output iff at least one debug domain is enabled Previously, debug output (and expensive checks that are enabled alongside debug output) was always enabled unless explicitly disabled, but Philip noted that this was not intentional. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687161 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall --- folks/debug.vala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/folks/debug.vala b/folks/debug.vala index 11c5f9e..fb30f81 100644 --- a/folks/debug.vala +++ b/folks/debug.vala @@ -89,7 +89,7 @@ public class Folks.Debug : Object } } - private bool _debug_output_enabled = true; + private bool _debug_output_enabled = false; /** * Whether debug output is enabled. This is orthogonal to the set of enabled @@ -254,6 +254,7 @@ public class Folks.Debug : Object } } + retval.debug_output_enabled = (retval._all || !retval._domains.is_empty); retval.colour_enabled = colour_enabled; return retval; -- 2.7.4