From 233e1c443293461ff31edea55bbf2ef6bd31bf0e Mon Sep 17 00:00:00 2001 From: "Hyuntae, Kim" Date: Wed, 19 Oct 2016 12:34:10 +0900 Subject: [PATCH] [libmm-camcorder] memory leak with g_path_get_dirname Change-Id: Iecc3c25576b062ebe44b8199ef5fd1aaa7e19120 --- packaging/libmm-camcorder.spec | 2 +- src/mm_camcorder_audiorec.c | 2 ++ src/mm_camcorder_gstcommon.c | 2 +- src/mm_camcorder_videorec.c | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packaging/libmm-camcorder.spec b/packaging/libmm-camcorder.spec index dabdf82..719e619 100644 --- a/packaging/libmm-camcorder.spec +++ b/packaging/libmm-camcorder.spec @@ -1,6 +1,6 @@ Name: libmm-camcorder Summary: Camera and recorder library -Version: 0.10.82 +Version: 0.10.83 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_camcorder_audiorec.c b/src/mm_camcorder_audiorec.c index 1876b9b..70eb27a 100644 --- a/src/mm_camcorder_audiorec.c +++ b/src/mm_camcorder_audiorec.c @@ -442,6 +442,8 @@ _mmcamcorder_audio_command(MMHandleType handle, int command) err = _mmcamcorder_get_storage_info(dir_name, hcamcorder->root_directory, &hcamcorder->storage_info); if (err != 0) { _mmcam_dbg_err("get storage info failed"); + g_free(dir_name); + dir_name = NULL; return MM_ERROR_OUT_OF_STORAGE; } diff --git a/src/mm_camcorder_gstcommon.c b/src/mm_camcorder_gstcommon.c index 267fb0c..317bb6b 100644 --- a/src/mm_camcorder_gstcommon.c +++ b/src/mm_camcorder_gstcommon.c @@ -1832,7 +1832,7 @@ static GstPadProbeReturn __mmcamcorder_video_dataprobe_push_buffer_to_record(Gst /* push buffer in appsrc to encode */ if (!sc->info_video) { _mmcam_dbg_warn("sc->info_video is NULL!!"); - return FALSE; + return GST_PAD_PROBE_DROP; } if (sc->info_video->push_encoding_buffer == PUSH_ENCODING_BUFFER_RUN && diff --git a/src/mm_camcorder_videorec.c b/src/mm_camcorder_videorec.c index 04c2a21..cb18b85 100644 --- a/src/mm_camcorder_videorec.c +++ b/src/mm_camcorder_videorec.c @@ -557,6 +557,8 @@ int _mmcamcorder_video_command(MMHandleType handle, int command) ret = _mmcamcorder_get_storage_info(dir_name, hcamcorder->root_directory, &hcamcorder->storage_info); if (ret != 0) { _mmcam_dbg_err("get storage info failed"); + g_free(dir_name); + dir_name = NULL; return MM_ERROR_OUT_OF_STORAGE; } -- 2.7.4