From 798adad9f38dbe22286eef3052363cefa7e5d0a1 Mon Sep 17 00:00:00 2001 From: Youngjae Shin Date: Mon, 12 Apr 2021 15:33:18 +0900 Subject: [PATCH] prevent invalid releasing memory Change-Id: Iea4a87692ff1f9b8a8d4cdd40e65ae1b8d42378e --- src/trigger/context_trigger.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/trigger/context_trigger.cpp b/src/trigger/context_trigger.cpp index 928246f..91962f9 100644 --- a/src/trigger/context_trigger.cpp +++ b/src/trigger/context_trigger.cpp @@ -644,11 +644,12 @@ static bool __is_valid_pkg_id(const char* pkgId) { IF_FAIL_RETURN(pkgId, false); - pkgmgrinfo_pkginfo_h pkgInfo; + pkgmgrinfo_pkginfo_h pkgInfo = NULL; int err = pkgmgrinfo_pkginfo_get_usr_pkginfo(pkgId, getuid(), &pkgInfo); - pkgmgrinfo_pkginfo_destroy_pkginfo(pkgInfo); + IF_FAIL_RETURN_TAG(err == PMINFO_R_OK, false, _E, "pkgmgrinfo_pkginfo_get_usr_pkginfo() Fail"); - return (PMINFO_R_OK == err); + pkgmgrinfo_pkginfo_destroy_pkginfo(pkgInfo); + return true; } EXPORT_API int context_trigger_rule_custom_event_create(const char* event_item, const char* provider, context_trigger_logical_type_e logical_type, context_trigger_rule_entry_h* entry) -- 2.7.4