From 7e891a61acb0e3c782180d49e8b827427d481948 Mon Sep 17 00:00:00 2001 From: Shinwoo Kim Date: Tue, 23 Mar 2021 19:47:05 +0900 Subject: [PATCH] atspi: emit i18n name change signal only for highlighted object User could change genlist item text even though it does not have highlight. And if user changes for all items, then it make unnecessary ipc call. There was a problem that too much signal was generated. It seems that there would be root reason of this problem. Before finding it, this could be reasonable solution. *tizen_fix Change-Id: I93d7c914d1693e18670c2169536a4041526b21ca --- src/lib/elementary/elm_genlist.c | 10 ++++++++-- src/lib/elementary_tizen/elm_genlist.c | 10 ++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index 449c567..aad9406 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -401,7 +401,10 @@ _item_text_realize(Elm_Gen_Item *it, edje_object_signal_emit(target, buf, "elm"); } if (_elm_atspi_enabled()) - efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); + //TIZEN_ONLY(20210323): reduce unnecessary signal + if (EO_OBJ(it) == _elm_object_accessibility_currently_highlighted_get()) + // + efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); } } @@ -6386,7 +6389,10 @@ _elm_genlist_efl_ui_widget_screen_reader(Eo *obj EINA_UNUSED, Elm_Genlist_Data * efl_access_children_changed_added_signal_emit(EO_OBJ(it), content); } } - efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); + //TIZEN_ONLY(20210323): reduce unnecessary signal + if (EO_OBJ(it) == _elm_object_accessibility_currently_highlighted_get()) + // + efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); } else { diff --git a/src/lib/elementary_tizen/elm_genlist.c b/src/lib/elementary_tizen/elm_genlist.c index 48496b8..36948a3 100644 --- a/src/lib/elementary_tizen/elm_genlist.c +++ b/src/lib/elementary_tizen/elm_genlist.c @@ -920,7 +920,10 @@ _item_text_realize(Elm_Gen_Item *it, } edje_object_message_signal_process(target); if (_elm_atspi_enabled()) - efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); + //TIZEN_ONLY(20210323): reduce unnecessary signal + if (EO_OBJ(it) == _elm_object_accessibility_currently_highlighted_get()) + // + efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); } } @@ -7926,7 +7929,10 @@ _elm_genlist_efl_ui_widget_screen_reader(Eo *obj EINA_UNUSED, Elm_Genlist_Data * efl_access_children_changed_added_signal_emit(EO_OBJ(it), content); } } - efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); + //TIZEN_ONLY(20210323): reduce unnecessary signal + if (EO_OBJ(it) == _elm_object_accessibility_currently_highlighted_get()) + // + efl_access_i18n_name_changed_signal_emit(EO_OBJ(it)); } else { -- 2.7.4