From 04d1dbacf6aabbb44f16f6776496192964d460d8 Mon Sep 17 00:00:00 2001 From: Jaehyun Kim Date: Wed, 2 Dec 2020 17:50:42 +0900 Subject: [PATCH] Fix derefrencing of NULL pointer Return value of a function '__connman_service_get_network' is dereferenced without checking. Change-Id: Ib66474b2fc6924d50eb8b35206251938ba63baad Signed-off-by: Jaehyun Kim --- src/service.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index dd4f191..a72a169 100755 --- a/src/service.c +++ b/src/service.c @@ -8555,12 +8555,15 @@ static struct connman_device *default_connecting_device = NULL; static void __connman_service_disconnect_default(struct connman_service *service) { struct connman_device *default_device = NULL; + struct connman_network *network = __connman_service_get_network(service); + + if (!network) + return; if (default_connecting_device == NULL) return; - default_device = connman_network_get_device( - __connman_service_get_network(service)); + default_device = connman_network_get_device(network); DBG("Disconnecting service %p %s", service, service->path); DBG("Disconnecting device %p %p %s", -- 2.7.4