From c955b04ec785ee8bfcb5df372625580988317369 Mon Sep 17 00:00:00 2001 From: hyunuktak Date: Tue, 3 Apr 2018 14:25:40 +0900 Subject: [PATCH] Fixed some coverity CID : 113930, 108826, 107165, 107210, 105204 Change-Id: Ic36d775ea1e782571a3b35062479593b9a754a2c Signed-off-by: hyunuktak --- packaging/net-config.spec | 2 +- src/mptcp-internal.c | 7 ++++++- src/network-state.c | 6 ++++-- src/wifi-config.c | 1 + src/wifi-netlink-scan.c | 1 + 5 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packaging/net-config.spec b/packaging/net-config.spec index b241c69..6658ab5 100755 --- a/packaging/net-config.spec +++ b/packaging/net-config.spec @@ -1,6 +1,6 @@ Name: net-config Summary: TIZEN Network Configuration service -Version: 1.1.129 +Version: 1.1.130 Release: 3 Group: System/Network License: Apache-2.0 diff --git a/src/mptcp-internal.c b/src/mptcp-internal.c index 7b3b6e5..72223d1 100755 --- a/src/mptcp-internal.c +++ b/src/mptcp-internal.c @@ -92,12 +92,17 @@ gint mptcp_get_enabled() { const char* sysctlname = "mptcp_enabled"; char* buf; + int enabled = -1; + if ((buf = __read_mptcp_parameter(sysctlname)) == NULL) { ERR("Fail to read %s, sysctlname"); return -1; } - return atoi(buf); + enabled = atoi(buf); + g_free(buf); + + return enabled; } gboolean mptcp_set_path_manager(const gchar* pm) diff --git a/src/network-state.c b/src/network-state.c index bbd34a4..4d363af 100755 --- a/src/network-state.c +++ b/src/network-state.c @@ -560,7 +560,8 @@ static char *__netconfig_get_preferred_ipv6_address(char *profile) while (g_variant_iter_loop(sub_iter, "{sv}", &sub_key, &variant)) { if (g_strcmp0(sub_key, "Address") == 0) { value = g_variant_get_string(variant, NULL); - preferred_address6 = g_strdup(value); + if (!preferred_address6) + preferred_address6 = g_strdup(value); } } g_variant_iter_free(sub_iter); @@ -1256,7 +1257,8 @@ char *netconfig_get_ifname(const char *profile) while (g_variant_iter_loop(next, "{sv}", &key1, &variant)) { if (g_strcmp0(key1, "Interface") == 0) { value = g_variant_get_string(variant, NULL); - ifname = g_strdup(value); + if (!ifname) + ifname = g_strdup(value); g_free(key1); g_variant_unref(variant); break; diff --git a/src/wifi-config.c b/src/wifi-config.c index 51981b7..aea051b 100755 --- a/src/wifi-config.c +++ b/src/wifi-config.c @@ -165,6 +165,7 @@ static gboolean __get_group_name(const gchar *prefix, const gchar *config_id, gc ret = __get_mac_address(&mac_address); if ((ret != TRUE) || (strlen(mac_address) == 0)) { ERR("Cannot get WIFI MAC address"); + g_free(mac_address); return FALSE; } diff --git a/src/wifi-netlink-scan.c b/src/wifi-netlink-scan.c index 1e2356f..e008fd2 100755 --- a/src/wifi-netlink-scan.c +++ b/src/wifi-netlink-scan.c @@ -494,6 +494,7 @@ static int __netconfig_netlink_scan_cb(struct nl_msg *msg, void *user_data) struct bss_scan_info_t *bss_info = (struct bss_scan_info_t *)list->data; if ((g_strcmp0(bss_info->ssid, ssid) == 0) && (bss_info->security_type == sec_type) && (bss_info->encryption_type == enc_type)) { + g_free(vsie); return NL_SKIP; } } -- 2.7.4