From ec6688b345266900ba1da021c5586351bc5744d6 Mon Sep 17 00:00:00 2001 From: Gilbok Lee Date: Fri, 4 Sep 2020 10:23:49 +0900 Subject: [PATCH] [0.6.236] Fix memory leak due to without unref caps Change-Id: Ibb732660de1b7ab2e1d335870ca4ad18f6c6ec12 --- packaging/libmm-player.spec | 2 +- src/mm_player_priv.c | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec index e3e5f6d..534cbd7 100644 --- a/packaging/libmm-player.spec +++ b/packaging/libmm-player.spec @@ -1,6 +1,6 @@ Name: libmm-player Summary: Multimedia Framework Player Library -Version: 0.6.235 +Version: 0.6.236 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 7107352..d10bfa4 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -1720,7 +1720,8 @@ __mmplayer_gst_create_sink_bin(GstElement *elem, GstPad *pad, GstCaps *ref_caps, MMPLAYER_GST_GET_CAPS_INFO(ref_caps, str, name, caps_ret); if (!caps_ret) goto ERROR; - + if (caps) + gst_caps_unref(caps); caps = gst_caps_ref(ref_caps); } @@ -2309,10 +2310,6 @@ __mmplayer_gst_caps_notify_cb(GstPad *pad, GParamSpec *unused, gpointer data) MMPLAYER_RETURN_IF_FAIL(unused); MMPLAYER_RETURN_IF_FAIL(data); - caps = gst_pad_get_current_caps(pad); - if (!caps) - return; - MMPLAYER_GST_GET_CAPS_INFO_FROM_PAD(pad, caps, str, name, caps_ret); if (!caps_ret) goto ERROR; -- 2.7.4