From 87d2be4f4048e9948ee6b09aba8adc83dcadc749 Mon Sep 17 00:00:00 2001 From: Eunhye Choi Date: Tue, 11 Feb 2020 15:30:34 +0900 Subject: [PATCH] souphttpsrc: fix coverity issue Change-Id: If2e63b989241207cfbf4277c5d5aed1653e5b6ed --- ext/soup/gstsouphttpsrc.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c index 40abf46..6031346 100644 --- a/ext/soup/gstsouphttpsrc.c +++ b/ext/soup/gstsouphttpsrc.c @@ -628,6 +628,8 @@ gst_soup_http_src_set_property (GObject * object, guint prop_id, { char **array; SoupURI *base_uri; + SoupCookie *cookie_parsed = NULL; + g_strfreev (src->cookies); src->cookies = g_strdupv (g_value_get_boxed (value)); @@ -635,8 +637,9 @@ gst_soup_http_src_set_property (GObject * object, guint prop_id, base_uri = soup_uri_new (src->location); GST_INFO_OBJECT (src, "request to set cookies..."); while (*array != NULL) { - soup_cookie_jar_add_cookie (src->cookie_jar, - soup_cookie_parse (*array++, base_uri)); + cookie_parsed = soup_cookie_parse (*array++, base_uri); + if (cookie_parsed && cookie_parsed->domain) + soup_cookie_jar_add_cookie (src->cookie_jar, cookie_parsed); } soup_uri_free (base_uri); } else { @@ -929,7 +932,7 @@ _append_extra_header (GQuark field_id, const GValue * value, gpointer user_data) cookie_parsed = soup_cookie_parse(tmp_field, uri); GST_DEBUG_OBJECT (src, "cookie parsed = %p", cookie_parsed); - if (src->cookie_jar) + if (src->cookie_jar && cookie_parsed && cookie_parsed->domain) soup_cookie_jar_add_cookie (src->cookie_jar, cookie_parsed); tmp_field = strtok_r (NULL, ";", &saveptr); @@ -1034,7 +1037,7 @@ gst_soup_http_src_session_open (GstSoupHTTPSrc * src) base_uri = soup_uri_new (src->location); while (*array != NULL) { soup_cookie = soup_cookie_parse (*array++, base_uri); - if (soup_cookie != NULL) { + if (soup_cookie && soup_cookie->domain) { GST_INFO_OBJECT (src, "adding cookies.."); soup_cookie_jar_add_cookie (src->cookie_jar, soup_cookie); } -- 2.7.4