From 867bacc2c6ff158cc74a4d65fe3412fca75e1ada Mon Sep 17 00:00:00 2001 From: Michal Bloch Date: Mon, 7 Dec 2020 22:09:12 +0100 Subject: [PATCH] Fix a memleak Change-Id: I8387f40aa78f329b3c2f3293765e1f38ae0a6447 Signed-off-by: Michal Bloch (cherry picked from commit 394f4ab4498610ac3b8112c7a5ba7b42edc60933) --- src/util/peripheral_privilege.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/util/peripheral_privilege.c b/src/util/peripheral_privilege.c index 335f9b9..443964b 100644 --- a/src/util/peripheral_privilege.c +++ b/src/util/peripheral_privilege.c @@ -82,21 +82,23 @@ int peripheral_privilege_check(GDBusMethodInvocation *invocation, GDBusConnectio if (!session || !client || !user) { _E("Failed to get client info"); - return -1; + ret = -1; + goto cleanup; } ret = cynara_check(__cynara, client, session, user, PERIPHERAL_PRIVILEGE); if (ret != CYNARA_API_ACCESS_ALLOWED) { _E("Failed to check privilege"); - g_free(session); - g_free(client); - g_free(user); - return -EACCES; + ret = -EACCES; + goto cleanup; } + ret = 0; + +cleanup: g_free(session); g_free(client); g_free(user); - return 0; + return ret; } -- 2.7.4