From fdd684b6eacbe487a0223c850732436024f47e7c Mon Sep 17 00:00:00 2001 From: Abhishek Sansanwal Date: Fri, 4 Aug 2017 14:51:33 +0530 Subject: [PATCH 1/1] Fix returned value's in connection_profile_get_dhcp_lease_duration Description: Return invalid parameter in case the passed address of dhcp_lease_duration in NULL. Return not supported in case CAPI is called for IPV6 address family. Change-Id: Iafe92b2714c9044f23665d5135e949133bb0b7c0 Signed-off-by: Abhishek Sansanwal --- src/connection_profile.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/connection_profile.c b/src/connection_profile.c index e617348..7f54484 100755 --- a/src/connection_profile.c +++ b/src/connection_profile.c @@ -691,11 +691,18 @@ EXPORT_API int connection_profile_get_dhcp_lease_duration( CHECK_FEATURE_SUPPORTED(TELEPHONY_FEATURE, WIFI_FEATURE, TETHERING_BLUETOOTH_FEATURE, ETHERNET_FEATURE); if (!(_connection_libnet_check_profile_validity(profile)) || - (address_family != CONNECTION_ADDRESS_FAMILY_IPV4)) { + (address_family != CONNECTION_ADDRESS_FAMILY_IPV4 && + address_family != CONNECTION_ADDRESS_FAMILY_IPV6) || + dhcp_lease_duration == NULL) { CONNECTION_LOG(CONNECTION_ERROR, "Invalid parameter"); return CONNECTION_ERROR_INVALID_PARAMETER; } + if (address_family == CONNECTION_ADDRESS_FAMILY_IPV6) { + CONNECTION_LOG(CONNECTION_ERROR, "Not supported"); + return CONNECTION_ERROR_ADDRESS_FAMILY_NOT_SUPPORTED; + } + net_profile_info_t *profile_info = profile; net_dev_info_t *net_info = __profile_get_net_info(profile_info); if (net_info == NULL) -- 2.7.4