From 5c236f10a9c526b91140bbd6be0d3e1eae9f5d05 Mon Sep 17 00:00:00 2001 From: Eunhye Choi Date: Fri, 5 Apr 2024 14:33:02 +0900 Subject: [PATCH] [0.6.276] Remove unused reference to fix mem leak Change-Id: I8902cd3d42c462294fc6dbb13d45bdc1def8e5ce --- packaging/libmm-player.spec | 2 +- src/include/mm_player_priv.h | 4 ---- src/mm_player_gst.c | 33 --------------------------------- 3 files changed, 1 insertion(+), 38 deletions(-) diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec index 3c54fab..5cec31e 100644 --- a/packaging/libmm-player.spec +++ b/packaging/libmm-player.spec @@ -1,6 +1,6 @@ Name: libmm-player Summary: Multimedia Framework Player Library -Version: 0.6.275 +Version: 0.6.276 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/include/mm_player_priv.h b/src/include/mm_player_priv.h index 4d9df97..74add5d 100644 --- a/src/include/mm_player_priv.h +++ b/src/include/mm_player_priv.h @@ -766,10 +766,6 @@ typedef struct { GCond subtitle_info_cond; GMutex subtitle_info_mutex; - /* stream collection */ - GstStreamCollection *collection; - guint stream_notify_id; - mmplayer_track_t track[MM_PLAYER_TRACK_TYPE_MAX]; guint internal_text_idx; diff --git a/src/mm_player_gst.c b/src/mm_player_gst.c index b873d71..9f03b36 100644 --- a/src/mm_player_gst.c +++ b/src/mm_player_gst.c @@ -1923,30 +1923,6 @@ __mmplayer_dump_collection(GstStreamCollection * collection) } } -static void -__mmplayer_stream_notify_cb(GstStreamCollection *collection, - GstStream *stream, GParamSpec *pspec, gpointer data) -{ - LOGD ("Got stream-notify from stream %s for %s (collection %p)\n", - gst_stream_get_stream_id(stream), pspec->name, collection); - if (g_str_equal(pspec->name, "caps")) { - GstCaps *caps = gst_stream_get_caps(stream); - MMPLAYER_LOG_GST_CAPS_TYPE(caps); - gst_caps_unref(caps); - } - -#ifdef __DEBUG__ - if (g_str_equal (pspec->name, "tags")) { - GstTagList *tags = gst_stream_get_tags(stream); - if (tags) { - LOGD (" tags:\n"); - gst_tag_list_foreach(tags, __mmplayer_print_tag_foreach, GUINT_TO_POINTER(MMPLAYER_TAG_INDENT)); - gst_tag_list_unref(tags); - } - } -#endif -} - static void __mmplayer_gst_bus_msg_callback(GstMessage *msg, gpointer data) { @@ -2059,15 +2035,6 @@ __mmplayer_gst_bus_msg_callback(GstMessage *msg, gpointer data) gst_message_parse_stream_collection(msg, &collection); if (collection) { __mmplayer_dump_collection(collection); - if (player->collection && player->stream_notify_id) { - g_signal_handler_disconnect(player->collection, player->stream_notify_id); - player->stream_notify_id = 0; - } - gst_object_replace((GstObject **)&player->collection, (GstObject *)collection); - if (player->collection) { - player->stream_notify_id = g_signal_connect(player->collection, "stream-notify", - (GCallback)__mmplayer_stream_notify_cb, player); - } gst_object_unref(collection); } } break; -- 2.34.1