From 1f89f16555a89b63ef8dce64d11b7ba0824db39a Mon Sep 17 00:00:00 2001 From: "aman.jeph" Date: Tue, 15 Sep 2020 19:47:06 +0530 Subject: [PATCH] fixed coverity issues Change-Id: I889bf1593a653b48e4b8dd30a5d2e5e42acaaac8 Signed-off-by: aman.jeph --- src/gallery-efl.c | 2 +- src/view/ge-albums.c | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) mode change 100644 => 100755 src/gallery-efl.c mode change 100644 => 100755 src/view/ge-albums.c diff --git a/src/gallery-efl.c b/src/gallery-efl.c old mode 100644 new mode 100755 index c8b1c2e..c2138c3 --- a/src/gallery-efl.c +++ b/src/gallery-efl.c @@ -376,13 +376,13 @@ static int _ge_parse_param(ge_ugdata * ugd, app_control_h service) if (ret != APP_CONTROL_ERROR_NONE) { if (total_size) { ugd->limitsize = atol(total_size); - GE_FREE(total_size); } else { ugd->limitsize = -1; } } else { ugd->limitsize = -1; } + GE_FREE(total_size); app_control_get_extra_data(service, APP_CONTROL_DATA_SELECTION_MODE, &select_mode); diff --git a/src/view/ge-albums.c b/src/view/ge-albums.c old mode 100644 new mode 100755 index 9061ea5..6c5733f --- a/src/view/ge-albums.c +++ b/src/view/ge-albums.c @@ -524,17 +524,16 @@ __ge_gallery_ug_result_cb(app_control_h request, app_control_h reply, ug_send_result_full(ugd->ug, ugd->service, APP_CONTROL_RESULT_SUCCEEDED); - if (pathArray) { - for (i = 0; i < arrayLength; i++) { - GE_FREEIF(pathArray[i]); - } - GE_FREE(pathArray); - } - if (!ugd->is_attach_panel) { ug_destroy_me(ugd->ug); } } + if (pathArray) { + for (i = 0; i < arrayLength; i++) { + GE_FREEIF(pathArray[i]); + } + GE_FREE(pathArray); + } } /** -- 2.7.4