From a0641d739e1ae1ef26b9022d30ee995cc0e58662 Mon Sep 17 00:00:00 2001 From: Minje Ahn Date: Tue, 31 Mar 2020 12:33:58 +0900 Subject: [PATCH] Fix return value when access failure Change-Id: I0fa8d10fc63b776127fb9ad27c4f53d021d967fa Signed-off-by: Minje Ahn --- src/thumbnail_util.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/thumbnail_util.c b/src/thumbnail_util.c index 88e4292..7045c56 100644 --- a/src/thumbnail_util.c +++ b/src/thumbnail_util.c @@ -602,16 +602,21 @@ int thumbnail_util_extract_to_file(const char *path, unsigned int width, unsigne /* check thumbnail path is writable */ check_str = g_path_get_dirname(thumbnail_path); - if (check_str != NULL) { - if (access(check_str, W_OK) != 0) { + if (access(check_str, W_OK) != 0) { + if (errno == EACCES || errno == EPERM) { thumbnail_util_error("No permission to write[%s]", check_str); - SAFE_FREE(check_str); - return THUMBNAIL_UTIL_ERROR_PERMISSION_DENIED; + ret = THUMBNAIL_UTIL_ERROR_PERMISSION_DENIED; } else { - SAFE_FREE(check_str); + thumbnail_util_error("Does not exists[%s]", check_str); + ret = THUMBNAIL_UTIL_ERROR_INVALID_PARAMETER; } + + SAFE_FREE(check_str); + return ret; } + SAFE_FREE(check_str); + /* If video file, thumbnail extension is only JPEG */ if (type == THUMBNAIL_UTIL_VIDEO) { char ext[255] = { 0 }; -- 2.34.1