From 7277ff862a8635da8ee259acedb9323783b48b5d Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C5=81ukasz=20Stelmach?= Date: Fri, 10 Sep 2021 20:02:53 +0200 Subject: [PATCH] WIP: handle error values from filp_open() Change-Id: I5a694555bcd082506330e08f48ed4b7043c4e120 --- kernel/logger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/logger.c b/kernel/logger.c index 48dbf4a..811e745 100644 --- a/kernel/logger.c +++ b/kernel/logger.c @@ -484,10 +484,13 @@ static struct file *make_new_file(struct file *file) nfile = filp_open(p, O_WRONLY, 0); kfree(pbuf); - if (!nfile) { + if (IS_ERR_OR_NULL(nfile)) { + pr_err("filp_open(%s): %ld\n", pbuf, PTR_ERR(nfile)); + kfree(pbuf); return ERR_PTR(-EFAULT); } + kfree(pbuf); nwriter = nfile->private_data; nwriter->prio = writer->prio; nwriter->tag = kstrdup(writer->tag, GFP_KERNEL); -- 2.34.1