From 29d6e3ffc9b987ab06e920de288f634b78341c90 Mon Sep 17 00:00:00 2001 From: Jung Jihoon Date: Wed, 10 Jul 2019 16:52:39 +0900 Subject: [PATCH] Fix Side effect from "Fix Coverity issues" Change-Id: I67e9aade4eb955cd081dffad8ca996619684269f Signed-off-by: Jung Jihoon --- test/main.c | 3 +++ test/mdg-manager.c | 14 +++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/test/main.c b/test/main.c index 477af92..6714239 100644 --- a/test/main.c +++ b/test/main.c @@ -33,6 +33,7 @@ extern struct menu_data menu_mdg_manager[]; extern GList *found_group_list; extern GList *found_device_list; +extern GList *found_invited_device_list; extern mdg_h handle; #define CASE_TO_STR(x) case x: return #x; @@ -158,6 +159,8 @@ OUT: g_list_free_full(found_group_list, _free_group); if (found_device_list) g_list_free_full(found_device_list, _free_device); + if (found_invited_device_list) + g_list_free_full(found_invited_device_list, _free_device); mdg_deinitialize(handle); diff --git a/test/mdg-manager.c b/test/mdg-manager.c index 9babdee..8006911 100755 --- a/test/mdg-manager.c +++ b/test/mdg-manager.c @@ -531,7 +531,9 @@ bool _device_found_cb(mdg_device_h device, void *user_data) } if (is_exist == FALSE) { - found_device_list = g_list_append(found_device_list, device); + mdg_device_h cloned_device; + mdg_device_info_clone(&cloned_device, device); + found_device_list = g_list_append(found_device_list, cloned_device); msgp("\r[ID] %s [Type] %s [Name] %s", device_id, __device_type_to_string(device_type), model_name); } @@ -730,6 +732,7 @@ static void _destroy_mdg_group_info(gpointer data) bool _group_found_cb(mdg_group_type_e type, mdg_group_h group, void *user_data) { char *group_name; + mdg_group_h cloned_group; mdg_group_info_get_name(group, &group_name); @@ -738,7 +741,9 @@ bool _group_found_cb(mdg_group_type_e type, mdg_group_h group, void *user_data) else msgp("\rfound group type : REMOTE, name : %s", group_name); - found_group_list = g_list_append(found_group_list, group); + mdg_group_info_clone(&cloned_group, group); + + found_group_list = g_list_append(found_group_list, cloned_group); if (group_name != NULL) free(group_name); @@ -907,6 +912,7 @@ bool _invited_device_found_cb(mdg_device_h device, void *user_data) { char *device_id = NULL; mdg_device_type_e device_type; + mdg_device_h cloned_device; mdg_device_info_get_device_id(device, &device_id); mdg_device_info_get_type(device, &device_type); @@ -916,7 +922,9 @@ bool _invited_device_found_cb(mdg_device_h device, void *user_data) if (device_id) free(device_id); - found_invited_device_list = g_list_append(found_invited_device_list, device); + mdg_device_info_clone(&cloned_device, device); + + found_invited_device_list = g_list_append(found_invited_device_list, cloned_device); return TRUE; } -- 2.7.4