From 8e79fe41ab94e1bbdd12ee57d7db04f382a07304 Mon Sep 17 00:00:00 2001 From: "kibak.yoon" Date: Tue, 18 Jul 2017 18:06:49 +0900 Subject: [PATCH] sensor: capi: remove unnecessary paramter check code - key and attribute cannot be negative. - it is okay even if developer puts a negative number forcibly. Change-Id: Ib984d2d64e75920d1fc309ef87b52bce9f835464 Signed-off-by: kibak.yoon --- src/sensor_recorder.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/sensor_recorder.cpp b/src/sensor_recorder.cpp index c16dd4c..cb5c267 100644 --- a/src/sensor_recorder.cpp +++ b/src/sensor_recorder.cpp @@ -240,8 +240,6 @@ int sensor_recorder_option_set_int(sensor_recorder_option_h option, sensor_recor { if (!option) return SENSOR_ERROR_INVALID_PARAMETER; - if (attribute < 0) - return SENSOR_ERROR_INVALID_PARAMETER; if (option_keys.find(attribute) == option_keys.end()) return SENSOR_ERROR_INVALID_PARAMETER; @@ -286,8 +284,6 @@ int sensor_recorder_query_set_int(sensor_recorder_query_h query, sensor_recorder { if (!query) return SENSOR_ERROR_INVALID_PARAMETER; - if (attribute < 0) - return SENSOR_ERROR_INVALID_PARAMETER; if (query_keys.find(attribute) == query_keys.end()) return SENSOR_ERROR_INVALID_PARAMETER; if (attribute == SENSOR_RECORDER_QUERY_TIME_INTERVAL && value < 0) @@ -308,8 +304,6 @@ int sensor_recorder_query_set_time(sensor_recorder_query_h query, sensor_recorde if (!query) return SENSOR_ERROR_INVALID_PARAMETER; - if (attribute < 0) - return SENSOR_ERROR_INVALID_PARAMETER; if (query_keys.find(attribute) == query_keys.end()) return SENSOR_ERROR_INVALID_PARAMETER; if (t < 0) @@ -446,8 +440,6 @@ int sensor_recorder_data_get_int(sensor_recorder_data_h data, sensor_recorder_da if (!data || !value) return SENSOR_ERROR_INVALID_PARAMETER; - if (key < 0) - return SENSOR_ERROR_INVALID_PARAMETER; if (data_keys.find(key) == data_keys.end()) return SENSOR_ERROR_INVALID_PARAMETER; @@ -472,8 +464,6 @@ int sensor_recorder_data_get_double(sensor_recorder_data_h data, sensor_recorder if (!data || !value) return SENSOR_ERROR_INVALID_PARAMETER; - if (key < 0) - return SENSOR_ERROR_INVALID_PARAMETER; if (data_keys.find(key) == data_keys.end()) return SENSOR_ERROR_INVALID_PARAMETER; -- 2.34.1