From df2b14364f4bf23fddffc98947dc02ab1eb1a562 Mon Sep 17 00:00:00 2001 From: Seung-Woo Kim Date: Fri, 23 Sep 2022 11:03:57 +0900 Subject: [PATCH] pass: Fix to return proper value for dbus signal handler From the dbus-stub generated code, signal handler should return TRUE if it handles invocation. Even ret value is error, fix to return TRUE after handling invocation. Below is dbus-stub comment about signal handler: If a signal handler returns %TRUE, it means the signal handler will handle the invocation and no other signal handlers will run. If no signal handler handles the invocation, the %G_DBUS_ERROR_UNKNOWN_METHOD error is returned. Returns: %G_DBUS_METHOD_INVOCATION_HANDLED or %TRUE if the invocation was handled, %G_DBUS_METHOD_INVOCATION_UNHANDLED or %FALSE to let other signal handlers run. NOTE: GLIB related asan heap-buffer-overflow issue is from the wrong return. Change-Id: I11e684101efb68e625a742b4d0655056299fd106 Suggested-by: Sangjung Woo Signed-off-by: Seung-Woo Kim --- src/pass/pass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pass/pass.c b/src/pass/pass.c index 112fa81..295e23f 100644 --- a/src/pass/pass.c +++ b/src/pass/pass.c @@ -148,7 +148,7 @@ static gboolean dbus_cb_core_start(SystemPassCore *obj, _E("failed to initialize PASS Core of the daemon " "in dbus callback for a start message\n"); - return FALSE; + return TRUE; } /** -- 2.7.4