From 69605b14bea1939e0aebdd40c36cfd41b291c2c8 Mon Sep 17 00:00:00 2001 From: "sanghyeok.oh" Date: Mon, 11 Dec 2017 11:59:35 +0900 Subject: [PATCH] Coverity Fix Change-Id: I3c8da6926230ff3e4e53f2fcc449b0e73c521cca Signed-off-by: sanghyeok.oh (cherry picked from commit e8fc72d02063c99ae14b4847a096fd2c9353ae7e) --- src/lib/gum-group.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/lib/gum-group.c b/src/lib/gum-group.c index cb6d321..a03c9a6 100755 --- a/src/lib/gum-group.c +++ b/src/lib/gum-group.c @@ -874,7 +874,14 @@ gum_group_get_by_name ( GumGroupCb callback, gpointer user_data) { - GumGroup *group = GUM_GROUP (g_object_new (GUM_TYPE_GROUP, NULL)); + GumGroup *group = NULL; + + if (!groupname) { + WARN ("groupname not specified"); + return NULL; + } + + group = GUM_GROUP (g_object_new (GUM_TYPE_GROUP, NULL)); if (!group) return NULL; @@ -883,14 +890,11 @@ gum_group_get_by_name ( return NULL; } - if (!groupname) { - WARN ("groupname not specified"); - return NULL; - } _create_op (group, callback, user_data); gum_dbus_group_service_call_get_group_by_name (group->priv->dbus_service, groupname, group->priv->cancellable, _on_get_group_by_name_cb, group); + return group; } -- 2.7.4