From 4961d18e50be8a326a86dda02d6ba661faab367c Mon Sep 17 00:00:00 2001 From: Sangyoon Jang Date: Thu, 23 Mar 2023 09:13:41 +0900 Subject: [PATCH] Fix static analysis issues Change-Id: Iba46bb2ddb6359bf54f0a15e1c4e922b87a3c421 Signed-off-by: Sangyoon Jang --- src/wgt/utils/extension_config_parser.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/wgt/utils/extension_config_parser.cc b/src/wgt/utils/extension_config_parser.cc index 93d0abf..7583c46 100644 --- a/src/wgt/utils/extension_config_parser.cc +++ b/src/wgt/utils/extension_config_parser.cc @@ -58,6 +58,10 @@ std::string ExtensionConfigParser::GetNodeDir( if (xmlStrEqual(prop->name, kDirAttributeKey)) { char* prop_value = reinterpret_cast(xmlNodeListGetString( node->doc, prop->children, 1)); + if (!prop_value) { + LOG(ERROR) << "Failed to get value string"; + return {}; + } dir = prop_value; xmlFree(prop_value); break; @@ -116,6 +120,10 @@ std::unique_ptr xmlAttr* prop = nullptr; for (prop = root->properties; prop; prop = prop->next) { xmlChar* value_ptr = xmlNodeListGetString(root->doc, prop->children, 1); + if (!value_ptr) { + LOG(ERROR) << "Failed to get value string"; + continue; + } std::string prop_value(reinterpret_cast(value_ptr)); xmlFree(value_ptr); if (IsPropSupportDir(root, prop)) -- 2.7.4