From 673c6533e3364856b77ece7002e791d02d083c61 Mon Sep 17 00:00:00 2001 From: INSUN PYO Date: Thu, 24 Nov 2016 16:03:42 +0900 Subject: [PATCH] kdbus: Remove the unnecessary code that unlink the reply twice. In sync call situation, kdbus_conn_reply() calls kdbus_reply_unlink(reply). Then, kdbus_conn_entry_sync_attach() also calls kdbus_reply_unlink(reply_wake), so it is called twice. Even it has no problems because kdbus_reply_unlink() does't free twice, but it is unnecessary. Signed-off-by: INSUN PYO Change-Id: Ia2b3552ee2e6a49ff97bb9d8f6e62964fe6d2cbf (cherry picked from commit 81c82865a0f660cf3d552ca5879f674222e7060a) --- ipc/kdbus/connection.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index 2dd907e4288b..02deba366839 100644 --- a/ipc/kdbus/connection.c +++ b/ipc/kdbus/connection.c @@ -871,7 +871,6 @@ static int kdbus_conn_entry_sync_attach(struct kdbus_conn *conn_dst, remote_ret = -EREMOTEIO; kdbus_sync_reply_wakeup(reply_wake, remote_ret); - kdbus_reply_unlink(reply_wake); mutex_unlock(&reply_wake->reply_dst->lock); return ret; -- 2.34.1