From 5ef9c9555b3dafccfc493d335230393952ecaf7b Mon Sep 17 00:00:00 2001 From: Wook Song Date: Tue, 28 Feb 2017 15:54:07 +0900 Subject: [PATCH] pass: pmqos: Prevent from accessing variables before initialization This patch modifies the callback function of DEVICE_NOTIFIER_PMQOS notifier to prevent from accessing variables before their initialization. Change-Id: Idc8a760ec8a6a53a1cfbc34f17626ea6c186ed57 Signed-off-by: Wook Song Reviewed-by: Chanwoo Choi --- src/pass/pass-pmqos.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/pass/pass-pmqos.c b/src/pass/pass-pmqos.c index 20be7e4..3929dff 100644 --- a/src/pass/pass-pmqos.c +++ b/src/pass/pass-pmqos.c @@ -95,9 +95,9 @@ static int find_scenario_index(struct pass_scenario_policy *scenario, #define MAX(a,b) (a > b ? a : b) int pass_notifier_pmqos_func(struct pass_policy *policy, void *data) { - struct pass_resource *pass_res = to_pass_resource(policy); - struct pass_conf_data *cdata = &pass_res->cdata; - struct pass_scenario_policy *scenario = &policy->scenario; + struct pass_resource *pass_res; + struct pass_conf_data *cdata; + struct pass_scenario_policy *scenario; struct pass_scenario *scn = NULL; enum pass_state locked = PASS_UNUSED; char name[PASS_NAME_LEN] = {""}; @@ -109,6 +109,10 @@ int pass_notifier_pmqos_func(struct pass_policy *policy, void *data) if (!is_pmqos_enabled(policy)) return 0; + pass_res = to_pass_resource(policy); + cdata = &pass_res->cdata; + scenario = &policy->scenario; + /* * Parse scenario name(data) whether to include 'Lock' or 'Unlock' * string and divide correct scenario name. -- 2.7.4