From 04df0ad5f440d3b16174218ade8e7f58092dae46 Mon Sep 17 00:00:00 2001 From: Himanshu Maithani Date: Tue, 28 May 2019 14:18:27 +0530 Subject: [PATCH] remove unused DBusError in kdbus_read_message() The function defines and initializes local DBusError. It is not used in kdbus_decode_msg() and function relies on assert for error. So, remove the DBusError variable in kdbus_decode_msg(). Change-Id: Ic726f2a161f06766b081f1a98e83ff4f3834f75b Signed-off-by: Himanshu Maithani Signed-off-by: Gaurav Gupta --- dbus/dbus-transport-kdbus.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/dbus/dbus-transport-kdbus.c b/dbus/dbus-transport-kdbus.c index 4697972..84e2030 100755 --- a/dbus/dbus-transport-kdbus.c +++ b/dbus/dbus-transport-kdbus.c @@ -3343,8 +3343,7 @@ kdbus_decode_msg (const struct kdbus_msg *msg, char *data, DBusTransportKdbus *kdbus_transport, int *fds, - int *n_fds, - DBusError *error) + int *n_fds) { int ret_size = 0; @@ -3396,9 +3395,6 @@ kdbus_read_message (DBusTransportKdbus *kdbus_transport, int start; dbus_uint64_t flags = 0; int ret; - DBusError error; - - dbus_error_init (&error); start = _dbus_string_get_length (buffer); @@ -3431,7 +3427,7 @@ kdbus_read_message (DBusTransportKdbus *kdbus_transport, } data = _dbus_string_get_data_len (buffer, start, buf_size); - ret_size = kdbus_decode_msg (msg, data, kdbus_transport, fds, n_fds, &error); + ret_size = kdbus_decode_msg (msg, data, kdbus_transport, fds, n_fds); if (ret_size == -1) /* error */ _dbus_string_set_length (buffer, start); -- 2.7.4