From 5167f388520b06e824a64a1ff6ee0651f30e1fbb Mon Sep 17 00:00:00 2001 From: Tomasz Marciniak Date: Mon, 25 Jul 2016 10:01:05 +0200 Subject: [PATCH] [Download] Added checking if returned object is not null. [Verification] Code compiles. TCT pass rate did not change. Change-Id: I8cb7e446736b42891823e16ed8536468748024d2 Signed-off-by: Tomasz Marciniak --- src/download/download_instance.cc | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/download/download_instance.cc b/src/download/download_instance.cc index ad114c01..eeb071bc 100755 --- a/src/download/download_instance.cc +++ b/src/download/download_instance.cc @@ -247,6 +247,10 @@ gboolean DownloadInstance::OnProgressChanged(void* user_data) { } DownloadInfoPtr diPtr = downCbPtr->instance->diMap[downCbPtr->callbackId]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", downCbPtr->callbackId); + return FALSE; + } picojson::value::object out; out["status"] = picojson::value("progress"); @@ -278,6 +282,10 @@ void DownloadInstance::OnStart(int download_id, void* user_data) { SLoggerD("OnStart for callbackId %d Called", downCbPtr->callbackId); DownloadInfoPtr diPtr = downCbPtr->instance->diMap[downCbPtr->callbackId]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", downCbPtr->callbackId); + return; + } download_get_content_size(download_id, &totalSize); @@ -296,6 +304,10 @@ gboolean DownloadInstance::OnFinished(void* user_data) { int callback_id = downCbPtr->callbackId; DownloadInfoPtr diPtr = downCbPtr->instance->diMap[callback_id]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", downCbPtr->callbackId); + return FALSE; + } LoggerD("OnFinished for callbackID %d Called", callback_id); @@ -344,6 +356,10 @@ gboolean DownloadInstance::OnPaused(void* user_data) { int callback_id = downCbPtr->callbackId; DownloadInfoPtr diPtr = downCbPtr->instance->diMap[callback_id]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", downCbPtr->callbackId); + return FALSE; + } LoggerD("OnPaused for callbackID %d Called", callback_id); @@ -366,6 +382,10 @@ gboolean DownloadInstance::OnCanceled(void* user_data) { int callback_id = downCbPtr->callbackId; DownloadInfoPtr diPtr = downCbPtr->instance->diMap[callback_id]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", callback_id); + return FALSE; + } LoggerD("OnCanceled for callbackID %d Called", callback_id); @@ -409,6 +429,10 @@ gboolean DownloadInstance::OnFailed(void* user_data) { int callback_id = downCbPtr->callbackId; DownloadInfoPtr diPtr = downCbPtr->instance->diMap[callback_id]; + if (!diPtr) { + LoggerW("Download handle does not exist for callback id %d", callback_id); + return FALSE; + } LoggerD("OnFailed for callbackID %d called", callback_id); -- 2.34.1