From 0d1ac1fb3ac367bdb9fbbfb71cbd54340966870f Mon Sep 17 00:00:00 2001 From: Sejun Park Date: Mon, 16 Oct 2017 15:50:01 +0900 Subject: [PATCH] fixed coverity issues Change-Id: Iebb50b802a5e286d8ac9480fff34e76b992a3496 --- packaging/capi-media-tool.spec | 2 +- src/media_packet_pool.c | 5 ++++- test/media_packet_test.c | 6 ------ 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packaging/capi-media-tool.spec b/packaging/capi-media-tool.spec index 856bc7a..79f3b21 100755 --- a/packaging/capi-media-tool.spec +++ b/packaging/capi-media-tool.spec @@ -1,7 +1,7 @@ Name: capi-media-tool Summary: A Core API media tool library in Tizen Native API Version: 0.1.8 -Release: 2 +Release: 3 Group: Multimedia/API License: Apache-2.0 Source0: %{name}-%{version}.tar.gz diff --git a/src/media_packet_pool.c b/src/media_packet_pool.c index 5776fcc..ed6e15b 100755 --- a/src/media_packet_pool.c +++ b/src/media_packet_pool.c @@ -235,7 +235,10 @@ int media_packet_pool_acquire_packet(media_packet_pool_h pool, media_packet_h *p break; } else { - g_cond_wait_until(&pool_handle->queue_cond, &pool_handle->mutex, wait_until); + if (!g_cond_wait_until(&pool_handle->queue_cond, &pool_handle->mutex, wait_until)) { + LOGW("signal not received"); + break; + } LOGD("Queue is Empty, waiting for timeout %" G_GSIZE_FORMAT "", wait_until); packet = g_queue_pop_head(pool_handle->queue); if (!packet) { diff --git a/test/media_packet_test.c b/test/media_packet_test.c index fc3f174..8959594 100755 --- a/test/media_packet_test.c +++ b/test/media_packet_test.c @@ -565,12 +565,6 @@ static void _media_packet_get_buffer_data_ptr(void) { void *ptr; media_packet_s *packet = g_media_packet[0]; - ptr = (void *)malloc(sizeof(packet->size)); - - if (ptr) - memset(packet, 0, sizeof(packet->size)); - else - g_print("_get_buffer_ptr , malloc failed..."); if (media_packet_get_buffer_data_ptr(g_media_packet[0], &ptr) == MEDIA_PACKET_ERROR_NONE) { g_print("media_packet_get_buffer_data_ptr is sucess!!"); -- 2.34.1