From f26c4fef8f7f6b8944071279993181dbb00f57ca Mon Sep 17 00:00:00 2001 From: Shinwoo Kim Date: Fri, 23 Apr 2021 15:59:13 +0900 Subject: [PATCH] atspi: move atspi bridge init to elm_run We moved initialization to elm_run by following commit already. commit 273ad815147a7916c426b6dd60fe45a523ccf048 Author: Lukasz Stanislawski Date: Mon Nov 27 14:18:57 2017 +0530 atspi: move atspi initialization to elm_run. Change-Id: Ib0656d1312367ee214f4cb2b236f28a4d73a1dfe But in accident, it resurrected with following commit. commit 87d7ed882cc130dd92c1bd7677e3223fc0fe6870 Author: Alastair Poole Date: Mon Jul 30 11:42:28 2018 -0400 efl_selection: reintroduce missing ELM_CNP_EVENT_SELECTION_CHANGED symbol. Summary: During the 1.21 development cycle the symbol ELM_CNP_EVENT_SELECTION_CHANGED was lost. The commit which introduced this: e88bbaa1e314751e5c1a04dec7f1f179188428ae This patch re-introduced the symbol and expected behaviour. Reviewers: #committers, zmike, bu5hm4n, herb Reviewed By: #committers, zmike Subscribers: herb, ManMower, segfaultxavi, stefan_schmidt, cedric, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6689 This could be migration error. So I would like to move atspi bridge init to elm_run again. AFAIK, if we create DBus connection at elm_init, there is a security issue. I am not sure if this is still living issue or not. Because we have done atspi init from 2018 (above second commit). Change-Id: I0ca58fa915634cf75367383a3f4c38eb8657d0f1 --- src/lib/elementary/elm_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/elementary/elm_main.c b/src/lib/elementary/elm_main.c index 21f83ac..258ffd9 100644 --- a/src/lib/elementary/elm_main.c +++ b/src/lib/elementary/elm_main.c @@ -455,8 +455,12 @@ elm_init(int argc, char **argv) ELM_CNP_EVENT_SELECTION_CHANGED = ecore_event_type_new(); + //TIZEN_ONLY(20210423): move atspi init to elm_run + /* if (_elm_config->atspi_mode != ELM_ATSPI_MODE_OFF) _elm_atspi_bridge_init(); + */ + // if (!_elm_config->web_backend) _elm_config->web_backend = eina_stringshare_add("none"); if (!_elm_web_init(_elm_config->web_backend)) -- 2.7.4