From 00c5cf1ce7bc4285ab1638ef91db5eac769c67e2 Mon Sep 17 00:00:00 2001 From: "venu.musham" Date: Fri, 16 Feb 2024 16:34:40 +0530 Subject: [PATCH] [v8] Enable v8 optimization. V8 lite mode was enabled during upversion to resolve build issues during bringup. lite mode disables v8 optimizations, hence canvas performance was low. Enable V8 optimizations. Change-Id: I705d25fd91d7b3c6bc11006ac92a1dca1799fbdc Signed-off-by: venu.musham --- v8/gni/v8.gni | 3 +-- v8/src/wasm/std-object-sizes.h | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/v8/gni/v8.gni b/v8/gni/v8.gni index 8607310..1168953 100644 --- a/v8/gni/v8.gni +++ b/v8/gni/v8.gni @@ -63,8 +63,7 @@ declare_args() { # Lite mode disables a number of performance optimizations to reduce memory # at the cost of performance. # Sets -DV8_LITE_MODE. - # FIXME(bringup m114): need to disable for tizen after resolving linker error - v8_enable_lite_mode = true + v8_enable_lite_mode = false # Enable the Turbofan compiler. # Sets -dV8_ENABLE_TURBOFAN. diff --git a/v8/src/wasm/std-object-sizes.h b/v8/src/wasm/std-object-sizes.h index 6b16ef2..776b917 100644 --- a/v8/src/wasm/std-object-sizes.h +++ b/v8/src/wasm/std-object-sizes.h @@ -62,9 +62,9 @@ inline size_t ContentSize(std::unordered_set set) { // When one of these checks fails, that probably means you've added fields to // a class guarded by it. Update the respective EstimateCurrentMemoryConsumption // function accordingly, and then update the check's expected size. -#if V8_TARGET_ARCH_X64 && defined(__clang__) && V8_TARGET_OS_LINUX && \ - !V8_USE_ADDRESS_SANITIZER && !V8_USE_MEMORY_SANITIZER && defined(DEBUG) && \ - V8_COMPRESS_POINTERS && !defined(V8_GC_MOLE) && defined(_LIBCPP_VERSION) +#if defined(V8_TARGET_ARCH_X64) && defined(__clang__) && defined(V8_TARGET_OS_LINUX) && \ + !defined(V8_USE_ADDRESS_SANITIZER) && !defined(V8_USE_MEMORY_SANITIZER) && defined(DEBUG) && \ + defined(V8_COMPRESS_POINTERS) && !defined(V8_GC_MOLE) && defined(_LIBCPP_VERSION) #define UPDATE_WHEN_CLASS_CHANGES(classname, size) \ static_assert(sizeof(classname) == size, \ "Update {EstimateCurrentMemoryConsumption} when adding " \ -- 2.7.4