From 4dbcdebdac3dc54df2c4fe0efaa32cbccabbf4f8 Mon Sep 17 00:00:00 2001 From: Seung-Woo Kim Date: Fri, 29 Jan 2021 19:27:56 +0900 Subject: [PATCH] halapi: Check enum range for backend_abi_min_version To avoid out-of-bounds access of version str array, check value range for data->backend_abi_min_version always. Change-Id: I3fb05ab9a27394f817937b589ce7751da0467a69 Signed-off-by: Seung-Woo Kim --- src/hal-api-common.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/hal-api-common.c b/src/hal-api-common.c index c4e2372..c476024 100644 --- a/src/hal-api-common.c +++ b/src/hal-api-common.c @@ -227,6 +227,13 @@ int hal_common_check_backend_abi_version(enum hal_module module, if (g_platform_curr_abi_version != data->platform_abi_version) continue; + if (data->backend_min_abi_version <= HAL_ABI_VERSION_UNKNOWN || + data->backend_min_abi_version >= HAL_ABI_VERSION_END) { + _E("wrong data in backend_min_abi_version %d\n", + data->backend_min_abi_version); + return TIZEN_ERROR_INVALID_PARAMETER; + } + if (abi_version <= data->platform_abi_version && abi_version >= data->backend_min_abi_version) return TIZEN_ERROR_NONE; -- 2.7.4