From 81cff70ca7676b33cc6e57dd052f97e3efc7807a Mon Sep 17 00:00:00 2001 From: "jinbong.lee" Date: Tue, 9 Jul 2024 12:35:50 +0000 Subject: [PATCH] Revert "wl_egl: add exception checking to find invalid wl_egl_buffer" This reverts commit c74b4ab60aa2a82a66b01fac6125af0566fc73da. - That exception check doesn't protected with wl_egl_surface->buffers_mutex. - _thread_wl_surface_commit function is called inside of wl_egl_buffer->mutex is locked. - It means wl_egl_buffer is available when _thread_wl_surface_commit is called. - If wl_egl_surface->buffers_mutex is used inside of wl_egl_buffer->mutex then deadlock will be occurred. Change-Id: I688f963827590f045bd3f97a7d6298e5281fb6e1 --- src/tpl_wl_egl_thread.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/tpl_wl_egl_thread.c b/src/tpl_wl_egl_thread.c index 5fccfd5..a514131 100755 --- a/src/tpl_wl_egl_thread.c +++ b/src/tpl_wl_egl_thread.c @@ -3678,12 +3678,6 @@ _thread_wl_surface_commit(tpl_wl_egl_surface_t *wl_egl_surface, TPL_CHECK_ON_FALSE_ASSERT_FAIL(wl_egl_buffer != NULL, "wl_egl_buffer sould be not NULL"); - if (__tpl_list_get_count(wl_egl_surface->buffers) == 0) { - TPL_ERR("wl_egl_buffer(%p) already has been removed from wl_egl_surface(%p)", - wl_egl_buffer, wl_egl_surface); - return; - } - if (wl_egl_buffer->wl_buffer == NULL) { wl_egl_buffer->wl_buffer = (struct wl_proxy *)wayland_tbm_client_create_buffer( -- 2.34.1