From 3a4688bce95f7e064593fcee80dc2c513860f32c Mon Sep 17 00:00:00 2001 From: Lukasz Stanislawski Date: Fri, 11 Sep 2015 09:48:07 +0200 Subject: [PATCH] spinner: change accessibility role to FILLER. According to UX guidline elm_spinner should be treated as layout, - only its content should be accessible for Assistive Technology. Conflicts: src/lib/elm_spinner.c Change-Id: I9f1ae58635e312e51a2c98ccd3dd35107eb0908b --- src/lib/elm_spinner.c | 16 +--------------- src/lib/elm_spinner.eo | 1 - 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c index ac5918c..1e15849 100644 --- a/src/lib/elm_spinner.c +++ b/src/lib/elm_spinner.c @@ -1353,7 +1353,7 @@ _elm_spinner_eo_base_constructor(Eo *obj, Elm_Spinner_Data *_pd EINA_UNUSED) eo_do(obj, evas_obj_type_set(MY_CLASS_NAME_LEGACY), evas_obj_smart_callbacks_descriptions_set(_smart_callbacks), - elm_interface_atspi_accessible_role_set(ELM_ATSPI_ROLE_SPIN_BUTTON)); + elm_interface_atspi_accessible_role_set(ELM_ATSPI_ROLE_FILLER)); return obj; } @@ -1570,20 +1570,6 @@ _elm_spinner_class_constructor(Eo_Class *klass) _elm_spinner_smart_focus_next_enable = EINA_TRUE; } -EOLIAN static const Elm_Atspi_Action * -_elm_spinner_elm_interface_atspi_widget_action_elm_actions_get(Eo *obj EINA_UNUSED, Elm_Spinner_Data *sd EINA_UNUSED) -{ - static Elm_Atspi_Action atspi_actions[] = { - { "spin,left", "spin", "left", _key_action_spin}, - { "spin,right", "spin", "right", _key_action_spin}, - { "spin,up", "spin", "up", _key_action_spin}, - { "spin,down", "spin", "down", _key_action_spin}, - { "toggle", "toggle", NULL, _key_action_toggle}, - { NULL, NULL, NULL, NULL } - }; - return &atspi_actions[0]; -} - // A11Y Accessibility EOLIAN static void diff --git a/src/lib/elm_spinner.eo b/src/lib/elm_spinner.eo index cd8b400..1b20461 100644 --- a/src/lib/elm_spinner.eo +++ b/src/lib/elm_spinner.eo @@ -237,7 +237,6 @@ class Elm.Spinner (Elm.Layout, Elm_Interface_Atspi_Value, Elm_Interface_Atspi_Wi Elm_Interface_Atspi_Value.value_and_text.set; Elm_Interface_Atspi_Value.range.get; Elm_Interface_Atspi_Value.increment.get; - Elm_Interface_Atspi_Widget_Action.elm_actions.get; } events { changed; -- 2.7.4