From b7496cae4a1ccb6e86fe3586c26784a547f385d5 Mon Sep 17 00:00:00 2001 From: Anamika Singh Date: Tue, 10 Jan 2017 18:28:12 +0530 Subject: [PATCH] Add return value check. Change-Id: If2bebc87b5ba75c286bae6c7215055938d506c7b Signed-off-by: Anamika Singh Signed-off-by: Boram Park --- src/tdm_display.c | 2 ++ src/tdm_helper.c | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/tdm_display.c b/src/tdm_display.c index 9cd7c4a..a8fa694 100644 --- a/src/tdm_display.c +++ b/src/tdm_display.c @@ -1157,6 +1157,7 @@ _tdm_output_commit(tdm_output *output, int sync, tdm_output_commit_handler func, private_output->regist_commit_cb = 1; ret = func_output->output_set_commit_handler(private_output->output_backend, tdm_output_cb_commit); + TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, commit_failed); } output_commit_handler = calloc(1, sizeof(tdm_private_output_commit_handler)); @@ -1376,6 +1377,7 @@ tdm_output_set_dpms(tdm_output *output, tdm_output_dpms dpms_value) private_output->regist_dpms_cb = 1; ret = func_output->output_set_dpms_handler(private_output->output_backend, tdm_output_cb_dpms, private_output); + TDM_RETURN_VAL_IF_FAIL(ret == TDM_ERROR_NONE, ret); } } diff --git a/src/tdm_helper.c b/src/tdm_helper.c index a72f3eb..87df714 100644 --- a/src/tdm_helper.c +++ b/src/tdm_helper.c @@ -534,7 +534,12 @@ tdm_helper_get_fd(const char *env) TDM_INFO("%s: fd(%d) newfd(%d)", env, fd, newfd); - fcntl(newfd, F_SETFD, flags | FD_CLOEXEC); + ret = fcntl(newfd, F_SETFD, flags | FD_CLOEXEC); + if (ret == -1) { + TDM_ERR("fcntl failed: %m"); + close(newfd); + return -1; + } return newfd; } -- 2.7.4