From 4f17f7f71a21a0f8d1e26f72dbea6f05d34cb580 Mon Sep 17 00:00:00 2001 From: Junghyun Yeon Date: Thu, 21 Sep 2017 20:24:03 +0900 Subject: [PATCH] Fix memory leak - Newly allocated manifest variable is not assigned at installer context at that time and it will be leaked if any of function calls in FillManifestX has failed. Change-Id: I33c4525d37a2f9a3a19074288246ce6e06af749a Signed-off-by: Junghyun Yeon --- src/common/step/configuration/step_parse_manifest.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/step/configuration/step_parse_manifest.cc b/src/common/step/configuration/step_parse_manifest.cc index 0816899..767957c 100644 --- a/src/common/step/configuration/step_parse_manifest.cc +++ b/src/common/step/configuration/step_parse_manifest.cc @@ -1179,6 +1179,7 @@ Step::Status StepParseManifest::process() { if (!FillManifestX(const_cast(manifest))) { LOG(ERROR) << "[Parse] Storing manifest_x failed. " << parser_->GetErrorMessage(); + pkgmgr_parser_free_manifest_xml(manifest); return Step::Status::PARSE_ERROR; } -- 2.7.4