From 014dad151e586a4b873d3c1ff076a4378325b0fa Mon Sep 17 00:00:00 2001 From: Seunghun Lee Date: Thu, 8 Jun 2023 09:32:49 +0900 Subject: [PATCH] e_comp_object: Remove unreachable code The while statement can be removed because it has been excuted once because of the break at the end of the loop. Plus, this patch also removes meaningless condition check whether `ok` is true. Change-Id: I736cd2046d142c8cea15966a586cd1d8729e9781 --- src/bin/e_comp_object.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c index d538099..50d1b4c 100644 --- a/src/bin/e_comp_object.c +++ b/src/bin/e_comp_object.c @@ -3737,21 +3737,13 @@ e_comp_object_util_add(Evas_Object *obj) if (skip) evas_object_data_set(o, "comp_object_skip", (void*)1); - while (!ok) + if (conf->shadow_style) { - if (conf->shadow_style) - { - if (!ok) - { - snprintf(buf, sizeof(buf), "e/comp/frame/%s", conf->shadow_style); - ok = e_theme_edje_object_set(o, "base/theme/comp", buf); - } - if (ok) break; - } - if (!ok) - ok = e_theme_edje_object_set(o, "base/theme/comp", "e/comp/frame/default"); - break; + snprintf(buf, sizeof(buf), "e/comp/frame/%s", conf->shadow_style); + ok = e_theme_edje_object_set(o, "base/theme/comp", buf); } + if (!ok) + e_theme_edje_object_set(o, "base/theme/comp", "e/comp/frame/default"); if (e_util_strcmp(evas_object_type_get(obj), "edje") || (!edje_object_data_get(obj, "noshadow"))) edje_object_signal_emit(o, "e,state,shadow,on", "e"); else -- 2.7.4