From 252191483511ee4cb2d3613141532beaf8e73cea Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Fri, 30 Jun 2017 10:24:30 +0900 Subject: [PATCH] Fix memory leak issue related to elm_genlist_item_class_new Dynamic memory referenced by 'ttc' was allocated at elm_genlist.c:9006 by calling function 'elm_genlist_item_class_new' at input_method_setting_selector_ui.cpp:464 and lost at input_method_setting_selector_ui.cpp:467 Change-Id: I843f7cdaafd43196ae78f2f14d2f363fde820863 Signed-off-by: Jihoon Kim --- im_setting_list/input_method_setting_list_popup_view.cpp | 6 ++++-- im_setting_selector/input_method_setting_selector_ui.cpp | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/im_setting_list/input_method_setting_list_popup_view.cpp b/im_setting_list/input_method_setting_list_popup_view.cpp index 5b29f76..37f94d6 100644 --- a/im_setting_list/input_method_setting_list_popup_view.cpp +++ b/im_setting_list/input_method_setting_list_popup_view.cpp @@ -376,10 +376,12 @@ static void im_setting_list_screen_create(void *data) { appdata *ad = NULL; Evas_Object *genlist = NULL; - Elm_Genlist_Item_Class *ttc = elm_genlist_item_class_new(); ad = (appdata *) data; - if (ad == NULL || !ttc) return; + if (ad == NULL) return; + + Elm_Genlist_Item_Class *ttc = elm_genlist_item_class_new(); + if (!ttc) return; ttc->item_style = "title"; ttc->func.text_get = im_setting_list_default_keyboard_title_text_get; diff --git a/im_setting_selector/input_method_setting_selector_ui.cpp b/im_setting_selector/input_method_setting_selector_ui.cpp index 6ec7561..e0af4c9 100644 --- a/im_setting_selector/input_method_setting_selector_ui.cpp +++ b/im_setting_selector/input_method_setting_selector_ui.cpp @@ -446,10 +446,12 @@ static void im_setting_selector_screen_create(void *data) { appdata *ad = NULL; Evas_Object *genlist = NULL; - Elm_Genlist_Item_Class *ttc = elm_genlist_item_class_new(); ad = (appdata *) data; - if (ad == NULL || !ttc) return; + if (ad == NULL) return; + + Elm_Genlist_Item_Class *ttc = elm_genlist_item_class_new(); + if (!ttc) return; ttc->item_style = "title"; ttc->func.text_get = im_setting_selector_title_text_get; -- 2.34.1