From 3e3c91162509a01fcc50ab6dae399edb1ea41528 Mon Sep 17 00:00:00 2001 From: Andrey Klimenko Date: Thu, 8 Sep 2016 15:35:02 +0300 Subject: [PATCH] Removed redundant TODOs Change-Id: Icb9f73ef2972eae62a84cc4ebe4c3de74c960e72 Signed-off-by: Andrey Klimenko --- src/Common/ContactManager/src/ContactManager.cpp | 2 -- src/Common/MsgEngine/src/MsgEngine.cpp | 1 - src/Common/View/src/NaviFrameItem.cpp | 1 - src/Common/View/src/View.cpp | 1 - src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp | 1 - src/Conversation/ConvList/Controller/src/ConvList.cpp | 2 +- src/Viewer/Controller/src/SmilPage.cpp | 5 ----- 7 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/Common/ContactManager/src/ContactManager.cpp b/src/Common/ContactManager/src/ContactManager.cpp index 4ead015..646df7e 100644 --- a/src/Common/ContactManager/src/ContactManager.cpp +++ b/src/Common/ContactManager/src/ContactManager.cpp @@ -140,7 +140,6 @@ ContactPersonNumberRef ContactManager::getContactPersonNumber(int phoneNumId) { - // TODO: impl cache policy if needed contacts_filter_h filter = nullptr; contacts_filter_create(_contacts_contact_number._uri, &filter); contacts_filter_add_int(filter, _contacts_person_number.number_id, CONTACTS_MATCH_EQUAL, phoneNumId); @@ -417,7 +416,6 @@ void ContactManager::invalidateCache() { - // TODO: invalidate cache by uri table MSG_LOG(""); m_AddressMap.clear(); m_OwnerProfile.reset(); diff --git a/src/Common/MsgEngine/src/MsgEngine.cpp b/src/Common/MsgEngine/src/MsgEngine.cpp index 9ac27c4..1660539 100644 --- a/src/Common/MsgEngine/src/MsgEngine.cpp +++ b/src/Common/MsgEngine/src/MsgEngine.cpp @@ -24,7 +24,6 @@ #include "private/MsgSettingsPrivate.h" #include "private/MsgComposerPrivate.h" #else - // TODO: msg public headers #endif #include diff --git a/src/Common/View/src/NaviFrameItem.cpp b/src/Common/View/src/NaviFrameItem.cpp index 4612721..fd7639b 100644 --- a/src/Common/View/src/NaviFrameItem.cpp +++ b/src/Common/View/src/NaviFrameItem.cpp @@ -288,7 +288,6 @@ void NaviFrameItem::NaviBar::setColor(NaviColorId id) void NaviFrameItem::NaviBar::setButtonText(NaviButtonId id, const std::string &text) { - //TODO: implement text color in edc TextStyle style; switch(m_CurrentColor) diff --git a/src/Common/View/src/View.cpp b/src/Common/View/src/View.cpp index 7ec00b8..6cfcdd1 100644 --- a/src/Common/View/src/View.cpp +++ b/src/Common/View/src/View.cpp @@ -69,7 +69,6 @@ void View::setEo(Evas_Object *eo) { if(m_pEo) { - // TODO: impl. reset EO if nedded MSG_LOG_ERROR("m_pEo not null"); assert(false); } diff --git a/src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp b/src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp index 31d98f2..6364b13 100644 --- a/src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp +++ b/src/Conversation/ConvList/Controller/src/BubbleEntityFactory.cpp @@ -83,7 +83,6 @@ BubbleEntity *BubbleEntityFactory::createEntity(const std::string &filePath, con switch(msgMediaType) { case MsgMedia::ImageType: - // TODO: msg service corrupts thumbnail's metadata, so it lost rotation. Use getPath instead getThumbPath until fix return new BubbleImageEntity(filePath, direction); case MsgMedia::AudioType: return new BubbleAudioEntity(filePath, fileName, bgType, direction); diff --git a/src/Conversation/ConvList/Controller/src/ConvList.cpp b/src/Conversation/ConvList/Controller/src/ConvList.cpp index d18e843..ed6c537 100644 --- a/src/Conversation/ConvList/Controller/src/ConvList.cpp +++ b/src/Conversation/ConvList/Controller/src/ConvList.cpp @@ -395,7 +395,7 @@ void ConvList::onMsgStorageInsert(const MsgIdList &msgIdList) } } if(inserted) - navigateToBottom(); // TODO: navigate to last inserted message or to compose item ? + navigateToBottom(); } void ConvList::onMsgStorageDelete(const MsgIdList &msgIdList) diff --git a/src/Viewer/Controller/src/SmilPage.cpp b/src/Viewer/Controller/src/SmilPage.cpp index 13f125e..09d5222 100644 --- a/src/Viewer/Controller/src/SmilPage.cpp +++ b/src/Viewer/Controller/src/SmilPage.cpp @@ -130,8 +130,6 @@ void SmilPage::build(const MsgPage &page) m_Attachments.push_back(list[i].getFilePath()); } - // TODO: image/video, text order - const MsgMedia *video = getMedia(page, MsgMedia::VideoType); if(video) buildVideo(*video); @@ -283,7 +281,6 @@ void SmilPage::onSaveButtonClicked(SmilAttachmentItemView &item) MSG_LOG(""); if(FileUtils::saveFileToStorage(item.getFilePath())) notification_status_message_post(msg("IDS_MSGF_POP_SAVED_IN_MY_FILES").cStr()); - // TODO: else } void SmilPage::onItemClicked(SmilSaveAllItemView &item) @@ -291,6 +288,4 @@ void SmilPage::onItemClicked(SmilSaveAllItemView &item) MSG_LOG(""); if(!m_Attachments.empty() && FileUtils::saveFilesToStorage(m_Attachments)) notification_status_message_post(msg("IDS_MSGF_POP_SAVED_IN_MY_FILES").cStr()); - // TODO: else - } -- 2.7.4