From 845f23c7127ecd90492e2fb6b0fc5f2174ccbff3 Mon Sep 17 00:00:00 2001 From: Jihoon Kim Date: Tue, 23 Aug 2022 10:53:30 +0900 Subject: [PATCH] Fix head-use-after-free issue detected by ASAN Change-Id: I4d8a29a67ef5d9595b20c5b9f9c59958d219b1a0 Signed-off-by: Jihoon Kim --- ism/src/scim_module.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ism/src/scim_module.cpp b/ism/src/scim_module.cpp index 3a74bcf..a99e18f 100644 --- a/ism/src/scim_module.cpp +++ b/ism/src/scim_module.cpp @@ -316,15 +316,15 @@ Module::unload () if (is_resident ()) return false; + std::vector ::iterator it = + std::find (_scim_modules.begin (), _scim_modules.end (), m_impl->init); + if (m_impl->exit) { try { m_impl->exit (); } catch (...) { } } lt_dlclose (m_impl->handle); - std::vector ::iterator it = - std::find (_scim_modules.begin (), _scim_modules.end (), m_impl->init); - if (it != _scim_modules.end ()) _scim_modules.erase (it); -- 2.7.4