From 75ba053f545907ccda0a75a69bdb697b3ed04d19 Mon Sep 17 00:00:00 2001 From: "jiyong.min" Date: Tue, 10 Mar 2020 13:30:54 +0900 Subject: [PATCH] Remove unnecessary variables at dbus listener Change-Id: I0116e1d67200f0e6ece96ca5744534120cfbea47 --- include/media_controller_private.h | 2 -- src/media_controller_ipc.c | 8 ++------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/include/media_controller_private.h b/include/media_controller_private.h index 800c6cb..ea038f6 100644 --- a/include/media_controller_private.h +++ b/include/media_controller_private.h @@ -414,8 +414,6 @@ typedef void(*mc_signal_received_cb)(const char *interface_name, const char *sig typedef struct { GDBusConnection *dbus_conn; - char *interface_name; - char *signal_name; mc_signal_received_cb callback; char *user_data; guint handler; diff --git a/src/media_controller_ipc.c b/src/media_controller_ipc.c index 520776f..beea1e7 100644 --- a/src/media_controller_ipc.c +++ b/src/media_controller_ipc.c @@ -87,8 +87,8 @@ static void __mc_ipc_signal_cb(GDBusConnection *connection, found_item = g_list_find_custom(*listener_list, key, __find_listener_by_key); if (found_item && found_item->data) { listener = found_item->data; - mc_secure_debug("Received : [%s] (req_id = %s) from %s.%s", message, request_id, listener->interface_name, listener->signal_name); - listener->callback(listener->interface_name, listener->signal_name, message, request_id, listener->user_data); + mc_secure_debug("Received : [%s] (req_id = %s) from %s.%s", message, request_id, interface_name, signal_name); + listener->callback(interface_name, signal_name, message, request_id, listener->user_data); } else { mc_secure_error("listener[%s] not found", key); } @@ -102,8 +102,6 @@ static void __mc_destroy_listener(gpointer data) if (listener) { mc_debug("listener[%s] will be unregistered.", listener->key); _mc_ipc_signal_unsubscribe(listener->dbus_conn, listener->handler); - MC_SAFE_FREE(listener->interface_name); - MC_SAFE_FREE(listener->signal_name); MC_SAFE_G_FREE(listener->key); MC_SAFE_FREE(listener); } @@ -228,8 +226,6 @@ int _mc_ipc_register_listener(GList **listener_list, GDBusConnection *connection } listener->dbus_conn = connection; - listener->interface_name = strdup(interface_name); - listener->signal_name = strdup(signal_name); listener->callback = callback; listener->user_data = user_data; listener->key = key; -- 2.7.4