From c6e25594f7389704be20636664aa352e51289241 Mon Sep 17 00:00:00 2001 From: coderhyme Date: Fri, 3 Nov 2017 08:21:32 +0900 Subject: [PATCH] [Multimedia] Fixed bugs. - Index error in ObjectDescriptionBuilder. - For Player, The display should be set in the PrepareAsync method every time, because the native implementation automatically resets display setting when unprepared. Change-Id: I4778dba2ffe0332223fc88088d9adae4b756d846 Signed-off-by: coderhyme --- src/Tizen.Multimedia.MediaPlayer/Player/Player.Properties.cs | 1 - src/Tizen.Multimedia.MediaPlayer/Player/Player.cs | 2 ++ src/Tizen.Multimedia.Metadata/ObjectDescriptionBuilder.cs | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Tizen.Multimedia.MediaPlayer/Player/Player.Properties.cs b/src/Tizen.Multimedia.MediaPlayer/Player/Player.Properties.cs index 6dc0322..70e66fa 100644 --- a/src/Tizen.Multimedia.MediaPlayer/Player/Player.Properties.cs +++ b/src/Tizen.Multimedia.MediaPlayer/Player/Player.Properties.cs @@ -265,7 +265,6 @@ namespace Tizen.Multimedia throw new ArgumentException("The display has already been assigned to another."); } - SetDisplay(value).ThrowIfFailed("Failed to set the display to the player"); ReplaceDisplay(value); } diff --git a/src/Tizen.Multimedia.MediaPlayer/Player/Player.cs b/src/Tizen.Multimedia.MediaPlayer/Player/Player.cs index 6eece57..ffb066b 100644 --- a/src/Tizen.Multimedia.MediaPlayer/Player/Player.cs +++ b/src/Tizen.Multimedia.MediaPlayer/Player/Player.cs @@ -271,6 +271,8 @@ namespace Tizen.Multimedia ValidatePlayerState(PlayerState.Idle); + SetDisplay(_display).ThrowIfFailed("Failed to configure display of the player"); + OnPreparing(); var completionSource = new TaskCompletionSource(); diff --git a/src/Tizen.Multimedia.Metadata/ObjectDescriptionBuilder.cs b/src/Tizen.Multimedia.Metadata/ObjectDescriptionBuilder.cs index 96f1f68..44c7802 100644 --- a/src/Tizen.Multimedia.Metadata/ObjectDescriptionBuilder.cs +++ b/src/Tizen.Multimedia.Metadata/ObjectDescriptionBuilder.cs @@ -50,7 +50,7 @@ namespace Tizen.Multimedia } if (sb.Length >= 2) { - sb.Remove(sb.Length - 1, 2); + sb.Remove(sb.Length - 2, 2); } return sb.ToString(); -- 2.7.4