From 567b24f1805c41acfa296ea0a47eac76522a89b3 Mon Sep 17 00:00:00 2001 From: "dongsug.song" Date: Tue, 23 Feb 2016 22:14:33 +0900 Subject: [PATCH] Revert "[3.0] Fix crash in wayland" This reverts commit 21c083bc22a013a441e243175795c314ec295046. Change-Id: Id5d4291a29d7ce906c9a24b722d8fc296a95805c --- adaptors/ecore/wayland/window-impl-ecore-wl.cpp | 8 +++----- .../ecore/wayland/window-render-surface-ecore-wl.cpp | 19 ++++--------------- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/adaptors/ecore/wayland/window-impl-ecore-wl.cpp b/adaptors/ecore/wayland/window-impl-ecore-wl.cpp index e2ad5d6..0202d5f 100644 --- a/adaptors/ecore/wayland/window-impl-ecore-wl.cpp +++ b/adaptors/ecore/wayland/window-impl-ecore-wl.cpp @@ -63,8 +63,6 @@ struct Window::EventHandler */ EventHandler( Window* window ) : mWindow( window ), - mWindowPropertyHandler( NULL ), - mClientMessageHandler( NULL ), mEcoreWindow( 0 ) { } @@ -78,9 +76,9 @@ struct Window::EventHandler { ecore_event_handler_del( mWindowPropertyHandler ); } - if ( mClientMessageHandler ) + if ( mClientMessagehandler ) { - ecore_event_handler_del( mClientMessageHandler ); + ecore_event_handler_del( mClientMessagehandler ); } } @@ -101,7 +99,7 @@ struct Window::EventHandler // Data Window* mWindow; Ecore_Event_Handler* mWindowPropertyHandler; - Ecore_Event_Handler* mClientMessageHandler; + Ecore_Event_Handler* mClientMessagehandler; Ecore_Wl_Window* mEcoreWindow; }; diff --git a/adaptors/ecore/wayland/window-render-surface-ecore-wl.cpp b/adaptors/ecore/wayland/window-render-surface-ecore-wl.cpp index 40cd572..532c47f 100644 --- a/adaptors/ecore/wayland/window-render-surface-ecore-wl.cpp +++ b/adaptors/ecore/wayland/window-render-surface-ecore-wl.cpp @@ -23,7 +23,7 @@ #include // INTERNAL INCLUDES -#include +#include #include #include #include @@ -50,8 +50,7 @@ WindowRenderSurface::WindowRenderSurface( Dali::PositionSize positionSize, const std::string& name, bool isTransparent) : EcoreWlRenderSurface( positionSize, surface, name, isTransparent ), - mEglWindow( NULL ), - mNeedToApproveDeiconify( false ) + mNeedToApproveDeiconify(false) { DALI_LOG_INFO( gRenderSurfaceLogFilter, Debug::Verbose, "Creating Window\n" ); Init( surface ); @@ -59,12 +58,6 @@ WindowRenderSurface::WindowRenderSurface( Dali::PositionSize positionSize, WindowRenderSurface::~WindowRenderSurface() { - if( mEglWindow != NULL ) - { - wl_egl_window_destroy(mEglWindow); - mEglWindow = NULL; - } - if( mOwnSurface ) { ecore_wl_window_free( mWlWindow ); @@ -130,12 +123,8 @@ void WindowRenderSurface::DestroyEglSurface( EglInterface& eglIf ) Internal::Adaptor::EglImplementation& eglImpl = static_cast( eglIf ); eglImpl.DestroySurface(); - - if( mEglWindow != NULL ) - { - wl_egl_window_destroy(mEglWindow); - mEglWindow = NULL; - } + wl_egl_window_destroy(mEglWindow); + mEglWindow = NULL; } bool WindowRenderSurface::ReplaceEGLSurface( EglInterface& egl ) -- 2.7.4